From patchwork Mon Jan 25 15:59:30 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101110 Delivered-To: patch@linaro.org Received: by 10.112.130.2 with SMTP id oa2csp1441150lbb; Mon, 25 Jan 2016 08:00:50 -0800 (PST) X-Received: by 10.66.141.109 with SMTP id rn13mr26359911pab.83.1453737650361; Mon, 25 Jan 2016 08:00:50 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i79si34500287pfj.103.2016.01.25.08.00.50; Mon, 25 Jan 2016 08:00:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933349AbcAYQAr (ORCPT + 30 others); Mon, 25 Jan 2016 11:00:47 -0500 Received: from mout.kundenserver.de ([212.227.126.134]:58153 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932984AbcAYQAR (ORCPT ); Mon, 25 Jan 2016 11:00:17 -0500 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue004) with ESMTPA (Nemesis) id 0MTcE0-1aWUxj1vlY-00QRXc; Mon, 25 Jan 2016 16:59:43 +0100 From: Arnd Bergmann To: Alexander Shishkin Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , linux-kernel@vger.kernel.org Subject: [PATCH] stm: add proper dependencies on the subsystem Date: Mon, 25 Jan 2016 16:59:30 +0100 Message-Id: <1453737579-1960217-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:Vgzvab+O+WRs6XWLxnNqULjaZp8gEchEGWbo9Pm55q1Ch/t5WpI UpR8GjLaj1wVrljvYXnQ2QUck/p9NKOs5RX22VWZskwj1XH6nBjBGGzsDltBp2LVTDaQsnB QtRhkwhAHydZ/rlLT+DzSZXMrlC1bP5eFDzS2aK0p/aX1RplnzHz7Iw5Md2/+mrgz2EC9pn RPZIaebwR4rC0l6CFRzew== X-UI-Out-Filterresults: notjunk:1; V01:K0:Yyp7eB6nmYE=:85x9YZAPS6LFroE2i2lIgS TDU1lxWKTpnNVGjJOqYXXbHoFo7aP6nH5bRaQ7O6KSS6NoCXP+aC/6qL16jA/so6SywkZSjxG ++s6EaR+UnzPUwDKB/7LVlAbwXl4u9ritEzQ8o6tyYT4P0/8N0bOBdC9UfBo/BictTsaFRBtG ZvOWkqvab/W6dUhTogvOr45eKLWqDf7NGEdwI3qdEcqaDjiNNUNU9nA5wdMAv8eiwp2JGwhY4 T5xKuEcOPmspNF210FDcuf/FYR3ptvMQ/DzI8kFVoq/+TPZ8wtgZ1sRhxpVu5LM1rBEabUdWV 74vmOBKeZyTwPnJSGmx4IANjWfC2Pwlpv+dVUtB1iU6wXw3ocDn8uQBUN5hMcFleiRALH0JjL 6kIcSbVG1NE61wpDEbH6Ag+mgMUedEIZARd7YzZ8KlMj9OCxp748o6tOHijSxXvU9qsMPVjtn QSMRxVY9AaMzYlgjHKQ4XiPdYes9PWPQXEdsh+4Him0CJLO1+0y4JWy3lmBQKP4GzNEMH0ZG5 tfzbtgwrHZMTvQlVU27S0Hqz+YoXENxf2Akbl7JM2AEZhxWf+NEtQeJpPkNxQVyA1usQGsmLP MN24yRy5Ec22wCGHEDXZ47jfVYLKdIYtNe5wresh2n1VpinKjISscUtGojg/+vl3/UmICF2mn 9fSbhcAmyhkMoismhRnZj8BRIoP6gj8pcVL+0Z3bUpbreLm6vxS5599pLrYN+9Qspwrs= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As several people have pointed out, the Kconfig dependencies for stm are confusing, because you can enable the individual features even when the subsystem itself is disabled. It turns out that randconfig tests even show the a build-time bug because of this: drivers/hwtracing/stm/built-in.o: In function `dummy_stm_init': drivers/hwtracing/stm/dummy_stm.c:53: undefined reference to `stm_register_device' drivers/hwtracing/stm/built-in.o: In function `dummy_stm_exit': drivers/hwtracing/stm/dummy_stm.c:58: undefined reference to `stm_unregister_device' drivers/hwtracing/stm/built-in.o:(.debug_addr+0x14): undefined reference to `stm_register_device' drivers/hwtracing/stm/built-in.o:(.debug_addr+0x1c): undefined reference to `stm_unregister_device' This adds the missing 'depends on STM' lines. Signed-off-by: Arnd Bergmann Fixes: 2c41538191e1 ("stm class: dummy_stm: Add dummy driver for testing stm class") --- drivers/hwtracing/stm/Kconfig | 2 ++ 1 file changed, 2 insertions(+) -- 2.7.0 diff --git a/drivers/hwtracing/stm/Kconfig b/drivers/hwtracing/stm/Kconfig index 83e9f591a54b..7780be86d913 100644 --- a/drivers/hwtracing/stm/Kconfig +++ b/drivers/hwtracing/stm/Kconfig @@ -10,6 +10,7 @@ config STM config STM_DUMMY tristate "Dummy STM driver" + depends on STM help This is a simple dummy device that pretends to be an stm device and discards your data. Use for stm class testing. @@ -18,6 +19,7 @@ config STM_DUMMY config STM_SOURCE_CONSOLE tristate "Kernel console over STM devices" + depends on STM help This is a kernel space trace source that sends kernel log messages to trace hosts over STM devices.