From patchwork Thu Jan 14 18:57:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 59765 Delivered-To: patch@linaro.org Received: by 10.112.130.2 with SMTP id oa2csp68232lbb; Thu, 14 Jan 2016 10:58:36 -0800 (PST) X-Received: by 10.98.31.8 with SMTP id f8mr8354127pff.71.1452797915215; Thu, 14 Jan 2016 10:58:35 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 12si10874952pfn.169.2016.01.14.10.58.34; Thu, 14 Jan 2016 10:58:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dkim=pass header.i=@linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932202AbcANS6a (ORCPT + 29 others); Thu, 14 Jan 2016 13:58:30 -0500 Received: from mail-pa0-f47.google.com ([209.85.220.47]:33827 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932170AbcANS6Z (ORCPT ); Thu, 14 Jan 2016 13:58:25 -0500 Received: by mail-pa0-f47.google.com with SMTP id uo6so365694772pac.1 for ; Thu, 14 Jan 2016 10:58:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=YgMHPooNTEEgV/AGMSCehNecAIJr93AK9JuYNjD4EMM=; b=E86anBWs3c9go3roP15o6FC50/14llLTCMPyWCrRWSY1G/IbIGPlNBZLut9wqMmelQ FkMVIy0sOlmvFTa6DYw7oD4d9t/4udQ9ixWLdcpsveHHWG5rr+I/0zt8FhsyzDGFru0i Gh1Lxm3ixZclEQl6qneODZ6ubXeBs2L39eNjY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=YgMHPooNTEEgV/AGMSCehNecAIJr93AK9JuYNjD4EMM=; b=mPNDLh7D9bV200nXVhHRjiHhSX/x7PzXjTGjqzkI6qnq36gcobP+iFPR7d3EfrACbF h24ASlShq0jmEniNU4XXygI625kpiKhy6PgFyYSYFKjN5qpiZTJ4XGcPTfg3vqt4xx60 58gvEd9j8zgFVNCy5dQ+jRoTbPoRujMPGSuORs9JKKxJZyC8E990TrGr5t+FZapxlRLD zFyvYBlaveBNARunAZbtCP2F6Jxra8KWWU0RGk7F7XmEW2lPFOHQf0rOb/ML76Rl2UE6 nBLpCA1MMr3AfiOwPsT0Lx7878K4gbjoPp0Rsy/VRf+HwPMrZV/zie0z2ESupybLcFmS owzA== X-Gm-Message-State: ALoCoQlmLqSZO4WdVrjmN1L8vVUiIgUczsbPRbOX8DDEBRLaIM88cb6Iq3rSC1++riZqKpW1qU5FuB95Lu4229IQDiVHrdxqRw== X-Received: by 10.66.158.169 with SMTP id wv9mr8343611pab.138.1452797904921; Thu, 14 Jan 2016 10:58:24 -0800 (PST) Received: from t430.cg.shawcable.net ([184.64.168.246]) by smtp.gmail.com with ESMTPSA id p87sm10854256pfi.94.2016.01.14.10.58.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 14 Jan 2016 10:58:24 -0800 (PST) From: Mathieu Poirier To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Mathieu Poirier Subject: [PATCH 3/5] coresight: coresight_unregister() function cleanup Date: Thu, 14 Jan 2016 11:57:58 -0700 Message-Id: <1452797880-4365-4-git-send-email-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1452797880-4365-1-git-send-email-mathieu.poirier@linaro.org> References: <1452797880-4365-1-git-send-email-mathieu.poirier@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In its current form the code never frees csdev->refcnt allocated in coresight_register(). There is also a problem with csdev->conns that is freed before device_unregister() rather than in the device release function. This patch addresses both issues by moving kfree(csdev->conns) to coresight_device_release() and freeing csdev->refcnt, also in the same function. Reported-by: Rabin Vincent Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.1.4 diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c index 41b42018b660..8872db4410eb 100644 --- a/drivers/hwtracing/coresight/coresight.c +++ b/drivers/hwtracing/coresight/coresight.c @@ -481,6 +481,8 @@ static void coresight_device_release(struct device *dev) { struct coresight_device *csdev = to_coresight_device(dev); + kfree(csdev->conns); + kfree(csdev->refcnt); kfree(csdev); } @@ -713,7 +715,6 @@ EXPORT_SYMBOL_GPL(coresight_register); void coresight_unregister(struct coresight_device *csdev) { - kfree(csdev->conns); device_unregister(&csdev->dev); } EXPORT_SYMBOL_GPL(coresight_unregister);