From patchwork Thu Jan 14 07:11:29 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 59710 Delivered-To: patch@linaro.org Received: by 10.112.130.2 with SMTP id oa2csp3830995lbb; Wed, 13 Jan 2016 23:14:09 -0800 (PST) X-Received: by 10.98.13.77 with SMTP id v74mr3732184pfi.162.1452755649783; Wed, 13 Jan 2016 23:14:09 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h3si7530364pfd.89.2016.01.13.23.14.09; Wed, 13 Jan 2016 23:14:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dkim=pass header.i=@linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752309AbcANHOF (ORCPT + 29 others); Thu, 14 Jan 2016 02:14:05 -0500 Received: from mail-wm0-f48.google.com ([74.125.82.48]:37479 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751058AbcANHNm (ORCPT ); Thu, 14 Jan 2016 02:13:42 -0500 Received: by mail-wm0-f48.google.com with SMTP id f206so411731268wmf.0 for ; Wed, 13 Jan 2016 23:13:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ezb/aqnkIRj+INKB2Idj1rPK6DPl4GzF/uIdHfGZtSo=; b=TX9mAvtJvZDOFdyOVbwQ4d0sVSEciuS+xTCeLsDC5s1hhzPNk7AQXTd+IxyvmayoBQ PUyfb2av3o3uP02189ip5Rs3VQg1pliwaI9Dv0pZNhxUftWJuwRPmW2vqEWxT5MOwpKD y0x+nlDOHo7IwgOOhc1Lslkd97RThqLiSFfFw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ezb/aqnkIRj+INKB2Idj1rPK6DPl4GzF/uIdHfGZtSo=; b=kGwLweF2jjcNoExmxjmybgpBoG7VZ8XJwnwd+0+FmLn+HqteRHiJkRPoIOcfSUAoql +miAlQRQNIqk/s3fXNaspcBJz8jPopPabulNysQQ7Flpm/Cw23LAYcYB7BF78WCeiFjp gkKcgq22uQpcZ1C+/aef9h4W0Ui04liSiop+WYTkeqXklIl6EtpkSHRTEYJ/7+bv52RQ OjlXA1GkofsNPwfNNeg2ObXfLpNPp2l5zJUjy9mmVZKm3n9iKu20ZVRZgXFKEu7OQUo1 vu0GfIubP1fEyo8tmuZPCDwNoBwWsE2LSkiV4RqhUlHlK4tuMTAtCluJfAURTT+CVETY Enww== X-Gm-Message-State: ALoCoQm0tyjbOvAM68zi5aMJX4YxkIu58ARAmg3Zhzih3/OWN0NjGZvc6J2bOmR4isJQ1nQbBRZXgLKy8HQtDoGXscwemCNDPw== X-Received: by 10.28.21.6 with SMTP id 6mr3306307wmv.46.1452755620919; Wed, 13 Jan 2016 23:13:40 -0800 (PST) Received: from localhost.localdomain ([217.46.108.250]) by smtp.gmail.com with ESMTPSA id c185sm23828522wma.5.2016.01.13.23.13.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 13 Jan 2016 23:13:40 -0800 (PST) From: Lee Jones To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: kernel@stlinux.com, maxime.coquelin@st.com, jassisinghbrar@gmail.com, dan.carpenter@oracle.com, seraphin.bonnaffe@st.com, Lee Jones Subject: [PATCH 4/4] mailbox: Stop using ENOSYS for anything other than unimplemented syscalls Date: Thu, 14 Jan 2016 07:11:29 +0000 Message-Id: <1452755489-18736-5-git-send-email-lee.jones@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1452755489-18736-1-git-send-email-lee.jones@linaro.org> References: <1452755489-18736-1-git-send-email-lee.jones@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In accordance with e15f431fe2d5 ("errno.h: Improve ENOSYS's comment") and 91c9afaf97ee ("checkpatch.pl: new instances of ENOSYS are errors") we're converting from the old meaning of: ENOSYS "Function not implemented" to a more standard EINVAL. Reported-by: Seraphin Bonnaffe Signed-off-by: Lee Jones --- drivers/mailbox/mailbox.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 1.9.1 diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index 6a4811f..4a36632 100644 --- a/drivers/mailbox/mailbox.c +++ b/drivers/mailbox/mailbox.c @@ -375,13 +375,13 @@ struct mbox_chan *mbox_request_channel_byname(struct mbox_client *cl, if (!np) { dev_err(cl->dev, "%s() currently only supports DT\n", __func__); - return ERR_PTR(-ENOSYS); + return ERR_PTR(-EINVAL); } if (!of_get_property(np, "mbox-names", NULL)) { dev_err(cl->dev, "%s() requires an \"mbox-names\" property\n", __func__); - return ERR_PTR(-ENOSYS); + return ERR_PTR(-EINVAL); } of_property_for_each_string(np, "mbox-names", prop, mbox_name) {