From patchwork Wed Dec 9 06:19:27 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Muckle X-Patchwork-Id: 57930 Delivered-To: patch@linaro.org Received: by 10.112.147.194 with SMTP id tm2csp480489lbb; Tue, 8 Dec 2015 22:21:48 -0800 (PST) X-Received: by 10.98.74.72 with SMTP id x69mr10609371pfa.88.1449642108118; Tue, 08 Dec 2015 22:21:48 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n1si10341552pap.152.2015.12.08.22.21.47; Tue, 08 Dec 2015 22:21:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dkim=neutral (body hash did not verify) header.i=@linaro-org.20150623.gappssmtp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753312AbbLIGUm (ORCPT + 28 others); Wed, 9 Dec 2015 01:20:42 -0500 Received: from mail-pf0-f173.google.com ([209.85.192.173]:35949 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752186AbbLIGTp (ORCPT ); Wed, 9 Dec 2015 01:19:45 -0500 Received: by pfdd184 with SMTP id d184so24744009pfd.3 for ; Tue, 08 Dec 2015 22:19:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=R1w/jySmlCR6x4xa8FPyFNmFIGB0+h64VyPzAd0rdWA=; b=d0Ww4x2PbTJ7KxLawkq+9kQShJJy/DlhOONoqtWronrpq9ORygxC+VLtdloNhWiA9B JFrSA77qCK1EZk5XzF9l0FeBZtc4Tdt7ooaFWddfVS7qCjvN6e2RVvqHcd/4cf+oZETP LmVEqako7xowMVxQHoZx4H2c3MT00cIqC+LsOYr0TI1e1BdIW/2jPfsFPFF3xRtw7G1K jiQztMrKkASdKmJnuce1nLVwNw0GWL8edyRL0NdB+YUCb4MQ6ClunU9IygS/QeB05Fvv CGLzuUF16JIT+85h28Y4ar6flGjl2YaCtArn/nN2me7eoRrSF99WBlLkUjCMY4+kKH8X a9ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=R1w/jySmlCR6x4xa8FPyFNmFIGB0+h64VyPzAd0rdWA=; b=g4sxcRnWiHWItMrpFgmDPaOkzIkBrPWj7zSCGHS5ooZMC7uQrx/5cpW4E3BxVynlCP Y8uDtDTXRcdetJpCBFoivnx9jo29HSQuF0w5Ffe6BJZLMFMwX5Ol7xOabkFyexFlDWmx jgIOoXvvaFFrH+xLIs4i/0+ZB4/Q7fZw3nivx4k6alUwnMuIkHlijgJdeizchM0rcMMe 2hzMo7n1SQDUvfnxQRVu/8erZrw1VMLfcsvtPntxF9Z3tWMVW/KXXkKw1ANRZnuszXaP DeK1g50Usdm+b9O0zdp+QKKq4qKr0cGDDv0vkqVpyHPLeYR6OZGLes4H5SrZ5md+jj+8 HrLA== X-Gm-Message-State: ALoCoQk+EkpKS9BXR5Y020YtqqN55qpp1SULFuYpaEBt3Z40AjXn4WZ3lgwMbQgKnyf4rX5lhlhlc6+QCP6Vr0KK/aq+milcfg== X-Received: by 10.98.86.10 with SMTP id k10mr10643453pfb.85.1449641985195; Tue, 08 Dec 2015 22:19:45 -0800 (PST) Received: from graphite.smuckle.net (cpe-75-80-155-7.san.res.rr.com. [75.80.155.7]) by smtp.gmail.com with ESMTPSA id l84sm8643078pfb.15.2015.12.08.22.19.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 08 Dec 2015 22:19:44 -0800 (PST) From: Steve Muckle X-Google-Original-From: Steve Muckle To: Peter Zijlstra , Ingo Molnar Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Vincent Guittot , Morten Rasmussen , Dietmar Eggemann , Juri Lelli , Patrick Bellasi , Michael Turquette , Juri Lelli Subject: [RFCv6 PATCH 06/10] sched/fair: cpufreq_sched triggers for load balancing Date: Tue, 8 Dec 2015 22:19:27 -0800 Message-Id: <1449641971-20827-7-git-send-email-smuckle@linaro.org> X-Mailer: git-send-email 2.4.10 In-Reply-To: <1449641971-20827-1-git-send-email-smuckle@linaro.org> References: <1449641971-20827-1-git-send-email-smuckle@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Juri Lelli As we don't trigger freq changes from {en,de}queue_task_fair() during load balancing, we need to do explicitly so on load balancing paths. [smuckle@linaro.org: move update_capacity_of calls so rq lock is held] cc: Ingo Molnar cc: Peter Zijlstra Signed-off-by: Juri Lelli Signed-off-by: Steve Muckle --- kernel/sched/fair.c | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) -- 2.4.10 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 1bfbbb7..880ceee 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -6023,6 +6023,10 @@ static void attach_one_task(struct rq *rq, struct task_struct *p) { raw_spin_lock(&rq->lock); attach_task(rq, p); + /* + * We want to potentially raise target_cpu's OPP. + */ + update_capacity_of(cpu_of(rq)); raw_spin_unlock(&rq->lock); } @@ -6044,6 +6048,11 @@ static void attach_tasks(struct lb_env *env) attach_task(env->dst_rq, p); } + /* + * We want to potentially raise env.dst_cpu's OPP. + */ + update_capacity_of(env->dst_cpu); + raw_spin_unlock(&env->dst_rq->lock); } @@ -7183,6 +7192,11 @@ more_balance: * ld_moved - cumulative load moved across iterations */ cur_ld_moved = detach_tasks(&env); + /* + * We want to potentially lower env.src_cpu's OPP. + */ + if (cur_ld_moved) + update_capacity_of(env.src_cpu); /* * We've detached some tasks from busiest_rq. Every @@ -7547,8 +7561,13 @@ static int active_load_balance_cpu_stop(void *data) schedstat_inc(sd, alb_count); p = detach_one_task(&env); - if (p) + if (p) { schedstat_inc(sd, alb_pushed); + /* + * We want to potentially lower env.src_cpu's OPP. + */ + update_capacity_of(env.src_cpu); + } else schedstat_inc(sd, alb_failed); }