From patchwork Mon Dec 7 11:50:20 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 57768 Delivered-To: patch@linaro.org Received: by 10.202.179.86 with SMTP id c83csp944716oif; Mon, 7 Dec 2015 03:51:21 -0800 (PST) X-Received: by 10.98.17.131 with SMTP id 3mr42226704pfr.57.1449489081850; Mon, 07 Dec 2015 03:51:21 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 72si1190352pfb.21.2015.12.07.03.51.21; Mon, 07 Dec 2015 03:51:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dkim=neutral (body hash did not verify) header.i=@linaro-org.20150623.gappssmtp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932227AbbLGLu7 (ORCPT + 28 others); Mon, 7 Dec 2015 06:50:59 -0500 Received: from mail-wm0-f49.google.com ([74.125.82.49]:33438 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932086AbbLGLus (ORCPT ); Mon, 7 Dec 2015 06:50:48 -0500 Received: by wmec201 with SMTP id c201so161528082wme.0 for ; Mon, 07 Dec 2015 03:50:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro-org.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references; bh=+pD6xF/xWFJCKlrmCokMdHQ2/hNKHPlZIzHlORpIoY0=; b=yFdap6prY6huY8SYVp+tBo/FaXm+O7nf+EtRTOHg8nQOpbi+tBNxMnPz1Cb8P1Tfds yxz04rB/3JHXNCYSqAhRm4s/RT45S4p5rIskl/yvFtZkRgzTw8wkZmakUOql4txffBju gBQdN1+xSLD0NjVu6URo2QWLVEcVANMtqVKZLeP9f/rNAM0JlBX61OvwyhUR6+hABy7A WWDet818mH/bR0LXPXumR/6MiJl1dqoXnU5ZNIHVXyZ4BNiKoqKoXKYYYErRoUsy/eWK P3MpxanBo9pDmLoRZRqLae4HGvdiZ6HNaj4NN6uAJKRwMc/YN+1ydmAy5xcxIdlANuCY btjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=+pD6xF/xWFJCKlrmCokMdHQ2/hNKHPlZIzHlORpIoY0=; b=a1iQWRCwXxErviJfzj8JiGoG0tAmExMBNLGYqgrX/drlyYEmgoApezrTKwx+cmqZDN QLmp//pc1RFATHgivnLBPiAYiqASpYDDo9zKQ/G8duNHwoYQp/1wtnzKTuHlkLETiNe2 f7uGvlFX3Q+ooFOxFAZsl0ZzLGsBBNGremCjV66C/3dGdWHzMCks/O/z2BatGH6bnfSh r5reh2WT4ODac7gKMIh3s9HWH3AVEBBj/yW3RNtDosYN0DcVgjUioN6odRw7u7ZTWesg Irn/cHZNeS7CyZSOnRKeNWHf5rOYzvd+NK9tznxm9v8VzdX9yyQlXBWNDTHyaIURnBak rJoA== X-Gm-Message-State: ALoCoQn7bqUS4kHzXKH1shouH0vwacm4PwQN6Z/eEbSLQRMVx/nv+pW79Wjn/b2qTQRVka/5oBLi X-Received: by 10.195.18.6 with SMTP id gi6mr35569454wjd.83.1449489047195; Mon, 07 Dec 2015 03:50:47 -0800 (PST) Received: from localhost.localdomain (host81-129-174-134.range81-129.btcentralplus.com. [81.129.174.134]) by smtp.gmail.com with ESMTPSA id z1sm24806533wje.35.2015.12.07.03.50.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 07 Dec 2015 03:50:46 -0800 (PST) From: Lee Jones To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 07/19] mfd: ab8500-sysctrl: Fix Constify, printk => pr_info and formatting issues Date: Mon, 7 Dec 2015 11:50:20 +0000 Message-Id: <1449489032-14374-8-git-send-email-lee.jones@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1449489032-14374-1-git-send-email-lee.jones@linaro.org> References: <1449489032-14374-1-git-send-email-lee.jones@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org WARNING: char * array declaration might be better as static const + static char *pss[] = {"ab8500_ac", "pm2301", "ab8500_usb"}; WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... + printk(KERN_INFO WARNING: quoted string split across lines + "Charger \"%s\" is connected with known battery." + " Rebooting.\n", WARNING: quoted string split across lines + "unable to set sysClkReq%dRfClkBuf: " + "%d\n", j + 1, ret); total: 0 errors, 4 warnings, 199 lines checked Cc: Linus Walleij Signed-off-by: Lee Jones --- drivers/mfd/ab8500-sysctrl.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ diff --git a/drivers/mfd/ab8500-sysctrl.c b/drivers/mfd/ab8500-sysctrl.c index 0d18256..b9f0010 100644 --- a/drivers/mfd/ab8500-sysctrl.c +++ b/drivers/mfd/ab8500-sysctrl.c @@ -27,7 +27,7 @@ static void ab8500_power_off(void) { sigset_t old; sigset_t all; - static char *pss[] = {"ab8500_ac", "pm2301", "ab8500_usb"}; + static const char * const pss[] = {"ab8500_ac", "pm2301", "ab8500_usb"}; int i; bool charger_present = false; union power_supply_propval val; @@ -68,10 +68,9 @@ static void ab8500_power_off(void) ret = power_supply_get_property(psy, POWER_SUPPLY_PROP_TECHNOLOGY, &val); if (!ret && val.intval != POWER_SUPPLY_TECHNOLOGY_UNKNOWN) { - printk(KERN_INFO - "Charger \"%s\" is connected with known battery." - " Rebooting.\n", - pss[i]); + pr_info("Charger '%s' is connected with known battery", + pss[i]); + pr_info(" - Rebooting.\n"); machine_restart("charging"); } power_supply_put(psy); @@ -161,8 +160,8 @@ static int ab8500_sysctrl_probe(struct platform_device *pdev) pdata->initial_req_buf_config[j]); if (ret < 0) { dev_err(&pdev->dev, - "unable to set sysClkReq%dRfClkBuf: " - "%d\n", j + 1, ret); + "Can't set sysClkReq%dRfClkBuf: %d\n", + j + 1, ret); } } }