From patchwork Mon Dec 7 11:50:28 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 57776 Delivered-To: patch@linaro.org Received: by 10.202.179.86 with SMTP id c83csp945089oif; Mon, 7 Dec 2015 03:53:07 -0800 (PST) X-Received: by 10.98.80.20 with SMTP id e20mr42153595pfb.23.1449489187074; Mon, 07 Dec 2015 03:53:07 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h82si681236pfd.71.2015.12.07.03.53.06; Mon, 07 Dec 2015 03:53:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dkim=neutral (body hash did not verify) header.i=@linaro-org.20150623.gappssmtp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932312AbbLGLxA (ORCPT + 28 others); Mon, 7 Dec 2015 06:53:00 -0500 Received: from mail-wm0-f44.google.com ([74.125.82.44]:33571 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932151AbbLGLuy (ORCPT ); Mon, 7 Dec 2015 06:50:54 -0500 Received: by wmec201 with SMTP id c201so161532220wme.0 for ; Mon, 07 Dec 2015 03:50:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro-org.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references; bh=j8Hn8CSvcMQkKFdEFKFlkJPZzDhUjvT9WnVG6f5EqFY=; b=HuPGk6Frg0vrCv0AOg93NPvpNJ6tvm6XM5YCbiYVUcNnlzj97cfXyqpxFoZ455x1yi H1quUkn3vG8/NZHeN4ZkO4vqtgCpJU3CExm+eFPrQDDFIRbILlTW6q0GUk59HFD/NUsk /ga6AD00N0MMpFaZpjjB1FRARNkYPG2DoCcrjbtkl6ueN+WKp8/3mjKwHF4ASskAl0VU t5OoCiJETKWxcObeb0GQDWXqViJ7+LFkcg5HHskDHL0OL9D1l1lcL8YhDBCuiAfEDogs 8EbwL90RlcemTIdxKO23BFDV2OxE7WkioQxPCib72P8NB2BhiytwWYXdngEK3BVW60qh OyqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=j8Hn8CSvcMQkKFdEFKFlkJPZzDhUjvT9WnVG6f5EqFY=; b=Vs6gDzO6awqYdmGdZBmD9RG9uZ4KLm1VZN5V6L8k8/gValqZeDWHMFy71T6+fqkyIm ZbRZQY0WmmDrSUnsOYvzUCiGxOwXmGDfZtgNu7q1w6woaD2pGSoxafDLG61V7g2tdOOq UlvZXs7oesgwumPao2neQ+cYZCYacJCsZUdi4W3gotSnhEKRbbv5yvZJQUmbJbevcY2m rLerHrjvXeIs/hjfR1IWX7QVSRUG6Joy5J2LIpbqXLYjujIYpww332r8ZTw5bA8cFLbd WkmMavc5YM1ZZWRq/ePR8oQ37F85jd1vWzT5Q8NCHKILbQpZyXBDgYYwbrVZ7EJzBIru L+Aw== X-Gm-Message-State: ALoCoQnDjaEF1sczx49wSrwyPGNHtu8aDlLWa4SftefBiUfy3hYdmXIf8rDHECuaHyIM9UVWdAI4 X-Received: by 10.194.87.170 with SMTP id az10mr32145325wjb.144.1449489053374; Mon, 07 Dec 2015 03:50:53 -0800 (PST) Received: from localhost.localdomain (host81-129-174-134.range81-129.btcentralplus.com. [81.129.174.134]) by smtp.gmail.com with ESMTPSA id z1sm24806533wje.35.2015.12.07.03.50.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 07 Dec 2015 03:50:52 -0800 (PST) From: Lee Jones To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 15/19] mfd: cs5535-mfd: Add missing line spacing and make local array static Date: Mon, 7 Dec 2015 11:50:28 +0000 Message-Id: <1449489032-14374-16-git-send-email-lee.jones@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1449489032-14374-1-git-send-email-lee.jones@linaro.org> References: <1449489032-14374-1-git-send-email-lee.jones@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org WARNING: Missing a blank line after declarations + struct resource *res; + res = platform_get_resource(pdev, IORESOURCE_IO, 0); WARNING: char * array declaration might be better as static const + const char *acpi_clones[] = { "olpc-xo1-pm-acpi", "olpc-xo1-sci-acpi" }; total: 0 errors, 2 warnings, 192 lines checked Signed-off-by: Lee Jones --- drivers/mfd/cs5535-mfd.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ diff --git a/drivers/mfd/cs5535-mfd.c b/drivers/mfd/cs5535-mfd.c index be91cb5..f9d277ff 100644 --- a/drivers/mfd/cs5535-mfd.c +++ b/drivers/mfd/cs5535-mfd.c @@ -60,6 +60,7 @@ static int cs5535_mfd_res_enable(struct platform_device *pdev) static int cs5535_mfd_res_disable(struct platform_device *pdev) { struct resource *res; + res = platform_get_resource(pdev, IORESOURCE_IO, 0); if (!res) { dev_err(&pdev->dev, "can't fetch device resource info\n"); @@ -114,7 +115,10 @@ static struct mfd_cell cs5535_mfd_cells[] = { #ifdef CONFIG_OLPC static void cs5535_clone_olpc_cells(void) { - const char *acpi_clones[] = { "olpc-xo1-pm-acpi", "olpc-xo1-sci-acpi" }; + static const char *acpi_clones[] = { + "olpc-xo1-pm-acpi", + "olpc-xo1-sci-acpi" + }; if (!machine_is_olpc()) return;