From patchwork Wed Dec 2 10:25:26 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 57549 Delivered-To: patch@linaro.org Received: by 10.112.155.196 with SMTP id vy4csp2772648lbb; Wed, 2 Dec 2015 02:26:54 -0800 (PST) X-Received: by 10.67.2.73 with SMTP id bm9mr3442820pad.94.1449052012834; Wed, 02 Dec 2015 02:26:52 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s131si3883134pfs.12.2015.12.02.02.26.52; Wed, 02 Dec 2015 02:26:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dkim=neutral (body hash did not verify) header.i=@baylibre-com.20150623.gappssmtp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756929AbbLBK0T (ORCPT + 28 others); Wed, 2 Dec 2015 05:26:19 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:38527 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756145AbbLBKZo (ORCPT ); Wed, 2 Dec 2015 05:25:44 -0500 Received: by wmec201 with SMTP id c201so51285058wme.1 for ; Wed, 02 Dec 2015 02:25:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Dk9VOx6iTo256zJ57MB6HrT+TSLKzoRpe1BpkzN+gh0=; b=Lch8RE4yG3DT/NQi48Es8Z1vCj767af1WxPU3C8I27DArU3KWI1ay8c9kU7St/zYhK LpTvQJPkZaEluDyMxEpxiqNwO0a7UOaxIYX4CTuGVhIIXS6NwyP1eaNES5f3RNYDnUKM dmcwO/g43oydLDRqYw2tI+6c7H2WtB436x5gSKVeRfvjqw+oRodbiB8L3D6aaTESY0Tk LdRhbcnKSxtcknJYQag0hojZq3Ae/l54kiJkr0dH65g/yJVlwzvd36OUTfxJkHN4kGo6 BU3WAqeA4DLfQGB0MnPo3nJwu1bqme3U7F8+9XjLya7E6YJtpTqC8zcdAsAIkpRhw6jY RNVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Dk9VOx6iTo256zJ57MB6HrT+TSLKzoRpe1BpkzN+gh0=; b=eyEdRV8jqM9HLNSgawuFVhzVhY6UHlILFw5dBXCWJHhnkINQAh2U/P0e/tFdxmL9Sf ODHg2wbzrXDXPAtubELYuoA2BAvcwkZ5MyYZgIuXewQWjk9LXDqeTZZki90C9XBQvbgj nZW+2Lj+CsOgZgaKwafgOmB8RlS2O07MTjh0bWrZEvWWAITiXuF0JSi/OUhFLjbCEsv8 /70AeJ+vATNQFKoqSXJ1jr9vUuJjrSjsSi53b+l3ruqSs6JG/mgOg8g0vFsVbXDywZqg P/3ve2OHe5/TnU2hcau4tRV5P7hubXD9+miefwOEXDlk2SYMGJmNqZs//yguX1GLUQGH AvyQ== X-Gm-Message-State: ALoCoQmm9tRHjQWeVH/NlI5w29j09H126oZtPG0aWkumgyFd1RrI57jK7lD35e0t75q24wwXE99x X-Received: by 10.28.153.130 with SMTP id b124mr45156231wme.12.1449051943238; Wed, 02 Dec 2015 02:25:43 -0800 (PST) Received: from bgdev-debian.home ([90.63.244.31]) by smtp.gmail.com with ESMTPSA id bg10sm2077707wjb.46.2015.12.02.02.25.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 02 Dec 2015 02:25:42 -0800 (PST) From: Bartosz Golaszewski To: Wolfram Sang Cc: linux-i2c , LKML , Bartosz Golaszewski Subject: [RESEND PATCH v2 9/9] eeprom: at24: readability tweaks Date: Wed, 2 Dec 2015 11:25:26 +0100 Message-Id: <1449051926-21918-10-git-send-email-bgolaszewski@baylibre.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1449051926-21918-1-git-send-email-bgolaszewski@baylibre.com> References: <1449051926-21918-1-git-send-email-bgolaszewski@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Move the macro definitions above the struct definitions and add some tabs for better readability. Signed-off-by: Bartosz Golaszewski --- drivers/misc/eeprom/at24.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c index 1288193..3238bf6 100644 --- a/drivers/misc/eeprom/at24.c +++ b/drivers/misc/eeprom/at24.c @@ -53,6 +53,14 @@ * which won't work on pure SMBus systems. */ +#define AT24_SIZE_BYTELEN 5 +#define AT24_SIZE_FLAGS 8 + +#define AT24_BITMASK(x) (BIT(x) - 1) + +#define AT24CS_SERIAL_SIZE 16 +#define AT24CS_SERIAL_ADDR(addr) (addr + 0x08) + struct at24_data { struct at24_platform_data chip; struct memory_accessor macc; @@ -99,14 +107,6 @@ static unsigned write_timeout = 25; module_param(write_timeout, uint, 0); MODULE_PARM_DESC(write_timeout, "Time (in ms) to try writes (default 25)"); -#define AT24_SIZE_BYTELEN 5 -#define AT24_SIZE_FLAGS 8 - -#define AT24_BITMASK(x) (BIT(x) - 1) - -#define AT24CS_SERIAL_SIZE 16 -#define AT24CS_SERIAL_ADDR(addr) (addr + 0x08) - /* create non-zero magic value for given eeprom parameters */ #define AT24_DEVICE_MAGIC(_len, _flags) \ ((1 << AT24_SIZE_FLAGS | (_flags)) \