From patchwork Tue Nov 17 09:52:30 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 56760 Delivered-To: patch@linaro.org Received: by 10.112.155.196 with SMTP id vy4csp1829071lbb; Tue, 17 Nov 2015 01:53:01 -0800 (PST) X-Received: by 10.68.69.109 with SMTP id d13mr39297677pbu.68.1447753980861; Tue, 17 Nov 2015 01:53:00 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id kh9si46235205pab.241.2015.11.17.01.53.00; Tue, 17 Nov 2015 01:53:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dkim=neutral (body hash did not verify) header.i=@baylibre_com.20150623.gappssmtp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753553AbbKQJw5 (ORCPT + 28 others); Tue, 17 Nov 2015 04:52:57 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:36528 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753514AbbKQJwo (ORCPT ); Tue, 17 Nov 2015 04:52:44 -0500 Received: by wmww144 with SMTP id w144so145904464wmw.1 for ; Tue, 17 Nov 2015 01:52:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Dk9VOx6iTo256zJ57MB6HrT+TSLKzoRpe1BpkzN+gh0=; b=1XKquLhZUHPaEjPEHCHgolnXAXBCWHT1Yjyja1/siskLRhEOZhqlthHwgCogAee7dt m/MxiFa0PFArG70jVHFDHxKKGxjBCeNRY0bC0c4rHitsQ1T1DElH9Vj6V12grJdn4XoJ 8prIb/RTbt4w8CDfml0JCRDebBNsFD4pkqvWw/iacr5X3b4C6dH8MSBIB9/pe4mdDnw7 ElBLP+5HvXakZeGZwdu5Hk6Rxr9ykwbrnWmUIKzKD9hQZk8JQKR/aR0VOimaAV5vC9vP QrtOufSD1TAAiQRRcLPb7YXRvNtdCeTFx9Zie4cAahTE0ZF1RkeUZwV8jxhGCyLXQQVC re5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Dk9VOx6iTo256zJ57MB6HrT+TSLKzoRpe1BpkzN+gh0=; b=VlVh6RdFy8Gc3frHV3KlG099muEvmmrxPamB4wTVS94tzrKMmo2i1EzmLNIpieit2G ksisOIHEYLy5bxr+pHkpFIaml8XY+/4cK2IfmQiDmmH/VNki3IqeAa89gi2mImXjh6b+ D5uBQDRWdO6Bo/7QO6njPh0Y5HkNlGjl3Gs+mymgOBQB/Sn2yEbJvu51AlgFyww1PZvV R0Cki378ZZvzBeoHWau9RmreRU8j8GeLrGnzl9boKoUVQsRnJVdWrSD7KYu2Dn0QeB0I bq39tqSxeMXM/KGjUbRh4PKWD6+YIQXbjvcYFOT6o/4HZo2JIbxiaVHxDe+ZN6lW8Gk3 Wlpg== X-Gm-Message-State: ALoCoQlAg48t9+oeuDJEBA+EV3NEFk9D/I7Qq5cOooYxwep75jnJi7rLDexfpxYmBIeB/eb5V/J6 X-Received: by 10.28.126.197 with SMTP id z188mr1608411wmc.88.1447753963865; Tue, 17 Nov 2015 01:52:43 -0800 (PST) Received: from bgdev-debian.home ([90.63.244.31]) by smtp.gmail.com with ESMTPSA id bk7sm38993546wjb.25.2015.11.17.01.52.43 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 17 Nov 2015 01:52:43 -0800 (PST) From: Bartosz Golaszewski To: Wolfram Sang Cc: linux-i2c , LKML , Bartosz Golaszewski Subject: [RESEND PATCH v2 9/9] eeprom: at24: readability tweaks Date: Tue, 17 Nov 2015 10:52:30 +0100 Message-Id: <1447753950-17213-10-git-send-email-bgolaszewski@baylibre.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1447753950-17213-1-git-send-email-bgolaszewski@baylibre.com> References: <1447753950-17213-1-git-send-email-bgolaszewski@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Move the macro definitions above the struct definitions and add some tabs for better readability. Signed-off-by: Bartosz Golaszewski --- drivers/misc/eeprom/at24.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c index 1288193..3238bf6 100644 --- a/drivers/misc/eeprom/at24.c +++ b/drivers/misc/eeprom/at24.c @@ -53,6 +53,14 @@ * which won't work on pure SMBus systems. */ +#define AT24_SIZE_BYTELEN 5 +#define AT24_SIZE_FLAGS 8 + +#define AT24_BITMASK(x) (BIT(x) - 1) + +#define AT24CS_SERIAL_SIZE 16 +#define AT24CS_SERIAL_ADDR(addr) (addr + 0x08) + struct at24_data { struct at24_platform_data chip; struct memory_accessor macc; @@ -99,14 +107,6 @@ static unsigned write_timeout = 25; module_param(write_timeout, uint, 0); MODULE_PARM_DESC(write_timeout, "Time (in ms) to try writes (default 25)"); -#define AT24_SIZE_BYTELEN 5 -#define AT24_SIZE_FLAGS 8 - -#define AT24_BITMASK(x) (BIT(x) - 1) - -#define AT24CS_SERIAL_SIZE 16 -#define AT24CS_SERIAL_ADDR(addr) (addr + 0x08) - /* create non-zero magic value for given eeprom parameters */ #define AT24_DEVICE_MAGIC(_len, _flags) \ ((1 << AT24_SIZE_FLAGS | (_flags)) \