From patchwork Fri Nov 13 18:45:06 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 56548 Delivered-To: patch@linaro.org Received: by 10.112.155.196 with SMTP id vy4csp1215157lbb; Fri, 13 Nov 2015 10:50:29 -0800 (PST) X-Received: by 10.68.249.33 with SMTP id yr1mr34626950pbc.94.1447440626362; Fri, 13 Nov 2015 10:50:26 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bw7si21440940pab.182.2015.11.13.10.50.26; Fri, 13 Nov 2015 10:50:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dkim=neutral (body hash did not verify) header.i=@linaro_org.20150623.gappssmtp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932794AbbKMSuX (ORCPT + 28 others); Fri, 13 Nov 2015 13:50:23 -0500 Received: from mail-pa0-f47.google.com ([209.85.220.47]:36489 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754922AbbKMSqk (ORCPT ); Fri, 13 Nov 2015 13:46:40 -0500 Received: by pacdm15 with SMTP id dm15so107588099pac.3 for ; Fri, 13 Nov 2015 10:46:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro_org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=RRI4lCz7Zhx0me6ojn79wCYqUpo9J/RkwAVAgGyJ31w=; b=ebUzRemNCbcEVjoSbjyGgkhhQau/x1hrSIOR0Urep5AJ3dBaAaeYmn2HiXlLDJcU07 OlpBFFgCe4Zi++WEowXHVlDKRl7a17dv2o8VkQH8mfJcxyJzFDXNWFPLhDu0QpaKWdIp dZX7HjnBwqMeW8EjhAN1z9drnTMCE3iVBwV/zNJcoyeyQEV1cTp8XomJ+ACUV20LCvfm 7PSvMRKozVKectF4ex4oAQFno4aDRfVpjz6J5Wsce0FW4fMwXtA92bNCfmill4lSQau7 c6LDWS3M9oB1hq2U09mF+IPdSMWlmZPcqQtfHy3YYm80EzTs4+EP3B0DRL16ZfIl6naA u4UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=RRI4lCz7Zhx0me6ojn79wCYqUpo9J/RkwAVAgGyJ31w=; b=Lw0o7fixS/F2DTC7GQ30pInQsq5aAv1eWJL4UHBJSIGtThf1GjRn13uc9VNVfxzEbT dE/qJvmkRUd7Wydi49E0aJ9TsAjF5t/ftYnYap2kpWt/XCN92eqhJgAodUIECHmwnFqf XyTCwBe6oxG/7NHTEuY9H+5YIDVi1xBb+a3xINPSZdLyea9U8iO9KYY1YvnuFdzDEQNj lZoToOsOwEZr2tiDkWf/jsNaLf1s+LrG8HsJQQIjQ1xL4IF+9pvnhrYd38fYHIvL47Oj ByoNAlsazel5rDWJNrT94FBBIa5KXw6Dt21RqtW1lXpJPofDJPnEVe2dKUCbEf57vAOw 2z1Q== X-Gm-Message-State: ALoCoQldtH40ecwF6tq71ZYSTsNrGJfGma9rhX0eY/sPSUugznPY3a2nBDtsyn8Se3/315XBwZRV X-Received: by 10.68.170.98 with SMTP id al2mr33552971pbc.121.1447440399697; Fri, 13 Nov 2015 10:46:39 -0800 (PST) Received: from t430.cg.shawcable.net (S0106002369de4dac.cg.shawcable.net. [184.64.168.246]) by smtp.gmail.com with ESMTPSA id xi7sm21737967pbc.56.2015.11.13.10.46.38 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 13 Nov 2015 10:46:39 -0800 (PST) From: Mathieu Poirier To: gregkh@linuxfoundation.org, a.p.zijlstra@chello.nl, alexander.shishkin@linux.intel.com, acme@kernel.org, mingo@redhat.com, corbet@lwn.net, nicolas.pitre@linaro.org Cc: adrian.hunter@intel.com, zhang.chunyan@linaro.org, mike.leach@arm.com, tor@ti.com, al.grant@arm.com, pawel.moll@arm.com, fainelli@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, mathieu.poirier@linaro.org Subject: [PATCH V4 15/26] coresight: etm3x: implementing perf_enable/disable() API Date: Fri, 13 Nov 2015 11:45:06 -0700 Message-Id: <1447440317-1977-16-git-send-email-mathieu.poirier@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1447440317-1977-1-git-send-email-mathieu.poirier@linaro.org> References: <1447440317-1977-1-git-send-email-mathieu.poirier@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org That way traces can be enabled and disabled automatically from the Perf subystem using the PMU abstraction. Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-etm3x.c | 47 ++++++++++++++++++++++++--- 1 file changed, 43 insertions(+), 4 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ diff --git a/drivers/hwtracing/coresight/coresight-etm3x.c b/drivers/hwtracing/coresight/coresight-etm3x.c index dd319ef0f1ac..4ff3e1419fde 100644 --- a/drivers/hwtracing/coresight/coresight-etm3x.c +++ b/drivers/hwtracing/coresight/coresight-etm3x.c @@ -372,8 +372,10 @@ static void etm_enable_hw(void *info) etm_set_prog(drvdata); etmcr = etm_readl(drvdata, ETMCR); - etmcr &= (ETMCR_PWD_DWN | ETMCR_ETM_PRG); + /* Clear setting from a previous run if need be */ + etmcr &= ~ETM3X_SUPPORTED_OPTIONS; etmcr |= drvdata->port_size; + etmcr |= ETMCR_ETM_EN; etm_writel(drvdata, config->ctrl | etmcr, ETMCR); etm_writel(drvdata, config->trigger_event, ETMTRIGGER); etm_writel(drvdata, config->startstop_ctrl, ETMTSSCR); @@ -413,9 +415,6 @@ static void etm_enable_hw(void *info) /* No VMID comparator value selected */ etm_writel(drvdata, 0x0, ETMVMIDCVR); - /* Ensures trace output is enabled from this ETM */ - etm_writel(drvdata, config->ctrl | ETMCR_ETM_EN | etmcr, ETMCR); - etm_clr_prog(drvdata); CS_LOCK(drvdata->base); @@ -488,6 +487,18 @@ static void etm_set_config(struct coresight_device *csdev, void *config) drvdata->config = config; } +static int etm_enable_perf(struct coresight_device *csdev) +{ + struct etm_drvdata *drvdata = dev_get_drvdata(csdev->dev.parent); + + if (WARN_ON_ONCE(drvdata->cpu != smp_processor_id())) + return -EINVAL; + + etm_enable_hw(drvdata); + + return 0; +} + static int etm_enable_sysfs(struct coresight_device *csdev) { struct etm_drvdata *drvdata = dev_get_drvdata(csdev->dev.parent); @@ -534,6 +545,9 @@ static int etm_enable(struct coresight_device *csdev, u32 mode) case CS_MODE_SYSFS: ret = etm_enable_sysfs(csdev); break; + case CS_MODE_PERF: + ret = etm_enable_perf(csdev); + break; default: ret = -EINVAL; } @@ -573,6 +587,28 @@ static void etm_disable_hw(void *info) dev_dbg(drvdata->dev, "cpu: %d disable smp call done\n", drvdata->cpu); } +static void etm_disable_perf(struct coresight_device *csdev) +{ + struct etm_drvdata *drvdata = dev_get_drvdata(csdev->dev.parent); + + if (WARN_ON_ONCE(drvdata->cpu != smp_processor_id())) + return; + + CS_UNLOCK(drvdata->base); + + /* Setting the prog bit disables tracing immediately */ + etm_set_prog(drvdata); + /* Get ready for another session */ + drvdata->config = NULL; + /* + * There is no way to know when the tracer will be used again so + * power down the tracer. + */ + etm_set_pwrdwn(drvdata); + + CS_LOCK(drvdata->base); +} + static void etm_disable_sysfs(struct coresight_device *csdev) { struct etm_drvdata *drvdata = dev_get_drvdata(csdev->dev.parent); @@ -616,6 +652,9 @@ static void etm_disable(struct coresight_device *csdev) case CS_MODE_SYSFS: etm_disable_sysfs(csdev); break; + case CS_MODE_PERF: + etm_disable_perf(csdev); + break; default: WARN_ON_ONCE(mode); return;