From patchwork Tue Oct 27 11:43:49 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 55596 Delivered-To: patch@linaro.org Received: by 10.112.59.35 with SMTP id w3csp1740036lbq; Tue, 27 Oct 2015 04:45:48 -0700 (PDT) X-Received: by 10.66.153.139 with SMTP id vg11mr27697725pab.118.1445946348726; Tue, 27 Oct 2015 04:45:48 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ni10si61284139pbc.213.2015.10.27.04.45.48; Tue, 27 Oct 2015 04:45:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dkim=neutral (body hash did not verify) header.i=@baylibre_com.20150623.gappssmtp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754294AbbJ0Lpr (ORCPT + 28 others); Tue, 27 Oct 2015 07:45:47 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:33502 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754166AbbJ0LoR (ORCPT ); Tue, 27 Oct 2015 07:44:17 -0400 Received: by wijp11 with SMTP id p11so209416833wij.0 for ; Tue, 27 Oct 2015 04:44:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=lhCg6rdqXPGiND3oq65qK4XqsZS2d3ijEGqrXEdYPjQ=; b=XB01102HNvHZGdJkh3oz3EkOxiQ/n40+DXgOL0LKfIfYN/xLINnCnFQiCcVIyxoGJp k3aKZhH5bw8gu7GzmL6P8YwslhezCinc8GTtvsSJes3HhcsKeEUCYM2U1NdZkGGebmsQ IT2pm5krchmjejqPvDOn/a3S4bJE00iSZssrp2pYh7T2cAWfZoNgQuf2mLEnjN8xqcsQ qSSYZD/IESLBJLH5L5ZuJ346HdezW+3qEGVbns+Q/BD5GUy8m4HyaqkvEJTAhC25F8oL w4J9lqmbKN1K/9nDDMVYYFPI2SldTlqS5ysLzl7S57Wfg9JhtW5pG/KnfbVdgUTE6XiW p8ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=lhCg6rdqXPGiND3oq65qK4XqsZS2d3ijEGqrXEdYPjQ=; b=Jpl7rNw8ajgdpTAwHNtjNivahhyTx2IcPkYT8AyXGVrc8IFt66i8DJ+z8bpZepY0NJ 1LSMBLIcGI9p/vF6oyqIOb/xYuZLRNBjR99du3ngv3iw7oA6CZnLpsJbLefdAfNkUWZp Ku90JsCnuzReZLDf4ia5MRC24GCtXAGYAgPSUKdTi2sHrCHqrmiPLBIFYHHojU1mrJsN hUiuVEl7iwIBeZBDchQj0UlAbaQJ+FiX/qVCzSLbVQ9OJ/xO6jqR3mt7/foUUQHNZJFO 3/x2B7YlpvrEfHnRlTEUW8ORdmAKNNlJ8X5m7XJvCT58ZYWOe9JP26Z2C/UtimzJQ7xi O2rQ== X-Gm-Message-State: ALoCoQm7Fw+kDOgWcT1+y1JBVHwWEGQuSWb2sg/hgZycIDIAN6aSn9LYqwLpU3JjlC1Vf6jQzpQu X-Received: by 10.194.2.5 with SMTP id 5mr53870285wjq.153.1445946256315; Tue, 27 Oct 2015 04:44:16 -0700 (PDT) Received: from localhost.localdomain (cag06-6-78-235-100-105.fbx.proxad.net. [78.235.100.105]) by smtp.gmail.com with ESMTPSA id gd11sm17451281wic.20.2015.10.27.04.44.15 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 27 Oct 2015 04:44:15 -0700 (PDT) From: Bartosz Golaszewski To: Wolfram Sang Cc: linux-i2c , LKML , Bartosz Golaszewski Subject: [PATCH v2 5/9] eeprom: at24: export the serial number through sysfs Date: Tue, 27 Oct 2015 12:43:49 +0100 Message-Id: <1445946233-6071-6-git-send-email-bgolaszewski@baylibre.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1445946233-6071-1-git-send-email-bgolaszewski@baylibre.com> References: <1445946233-6071-1-git-send-email-bgolaszewski@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The at24 driver is now capable of reading the serial number from at24cs EEPROM chips. Export the serial number through sysfs. Signed-off-by: Bartosz Golaszewski --- drivers/misc/eeprom/at24.c | 44 ++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 40 insertions(+), 4 deletions(-) -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c index 442aac7..dfc7b55 100644 --- a/drivers/misc/eeprom/at24.c +++ b/drivers/misc/eeprom/at24.c @@ -64,6 +64,7 @@ struct at24_data { */ struct mutex lock; struct bin_attribute bin; + struct bin_attribute *bin_serial; u8 *writebuf; unsigned write_max; @@ -102,6 +103,7 @@ MODULE_PARM_DESC(write_timeout, "Time (in ms) to try writes (default 25)"); #define AT24_BITMASK(x) (BIT(x) - 1) +#define AT24CS_SERIAL_SIZE 16 #define AT24CS_SERIAL_ADDR(addr) (addr + 0x08) /* create non-zero magic value for given eeprom parameters */ @@ -156,10 +158,8 @@ static struct i2c_client *at24_translate_offset(struct at24_data *at24, return at24->client[i]; } -static int __attribute__((unused)) at24cs_eeprom_serial_read( - struct at24_data *at24, - char *buf, unsigned offset, - size_t count) +static int at24cs_eeprom_serial_read(struct at24_data *at24, char *buf, + unsigned offset, size_t count) { unsigned long timeout, read_time; struct i2c_client *client; @@ -227,6 +227,16 @@ static int __attribute__((unused)) at24cs_eeprom_serial_read( return -ETIMEDOUT; } +static ssize_t at24cs_bin_serial_read(struct file *filp, struct kobject *kobj, + struct bin_attribute *attr, + char *buf, loff_t off, size_t count) +{ + struct at24_data *at24; + + at24 = dev_get_drvdata(container_of(kobj, struct device, kobj)); + return at24cs_eeprom_serial_read(at24, buf, off, count); +} + static ssize_t at24_eeprom_read(struct at24_data *at24, char *buf, unsigned offset, size_t count) { @@ -643,6 +653,30 @@ static int at24_probe(struct i2c_client *client, const struct i2c_device_id *id) at24->bin.read = at24_bin_read; at24->bin.size = chip.byte_len; + if (at24->chip.flags & AT24_FLAG_SERIAL) { + /* + * For EEPROMs containing the serial number export an + * additional file allowing allowing convenvient access + * to it from user-space. + */ + at24->bin_serial = devm_kzalloc(&client->dev, + sizeof(struct bin_attribute), + GFP_KERNEL); + if (!at24->bin_serial) + return -ENOMEM; + + sysfs_bin_attr_init(at24->bin_serial); + at24->bin_serial->attr.name = "serial"; + at24->bin_serial->attr.mode = S_IRUSR; + at24->bin_serial->read = at24cs_bin_serial_read; + at24->bin_serial->size = AT24CS_SERIAL_SIZE; + + err = sysfs_create_bin_file(&client->dev.kobj, + at24->bin_serial); + if (err) + goto err_clients; + } + at24->macc.read = at24_macc_read; writable = !(chip.flags & AT24_FLAG_READONLY); @@ -742,6 +776,8 @@ static int at24_remove(struct i2c_client *client) at24 = i2c_get_clientdata(client); sysfs_remove_bin_file(&client->dev.kobj, &at24->bin); + if (at24->bin_serial) + sysfs_remove_bin_file(&client->dev.kobj, at24->bin_serial); for (i = 1; i < at24->num_addresses; i++) i2c_unregister_device(at24->client[i]);