From patchwork Tue Oct 27 11:43:53 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 55595 Delivered-To: patch@linaro.org Received: by 10.112.59.35 with SMTP id w3csp1739851lbq; Tue, 27 Oct 2015 04:45:29 -0700 (PDT) X-Received: by 10.107.12.93 with SMTP id w90mr47746543ioi.110.1445946328957; Tue, 27 Oct 2015 04:45:28 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id rt3si16444669igb.71.2015.10.27.04.45.28; Tue, 27 Oct 2015 04:45:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dkim=neutral (body hash did not verify) header.i=@baylibre_com.20150623.gappssmtp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754280AbbJ0Lo7 (ORCPT + 28 others); Tue, 27 Oct 2015 07:44:59 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:33614 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754224AbbJ0LoW (ORCPT ); Tue, 27 Oct 2015 07:44:22 -0400 Received: by wijp11 with SMTP id p11so209420617wij.0 for ; Tue, 27 Oct 2015 04:44:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=LfwegbMP9v9nOYkfrowLDDY8x0EchvnsaF3UwgDM3BA=; b=VrV015rW186i4YhUky1QgVxkAskglWaBAZqfJ6dg3U3lR4gaPmssd6y33uyfKKigmp liTtp8gNmGJmlGAdqk+mJPzYpdKJ3kVV/F3P8rxxUOXAGEIKJWJSITZ7stO4FpjS1DUu Mwa4ywCH6Wvyx/FEENhl3d+mBnVibDMDz8/C/DrKhYO2+q5B+UFM15j4xAGtD5bLUTlx GXOwfEpXg8RBqrURhNuCAIGYnH1q2cmBkCrGCnkw0wSfdsjrTxS+07abBxWgSv8UWi3t tS/NHyCgahPYcCixtsnANxWBg85LbYNBdffRqGF8E1vtEjPLlN+Tmu+xzh8QnSJ4To8I LFuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=LfwegbMP9v9nOYkfrowLDDY8x0EchvnsaF3UwgDM3BA=; b=HsF/oJZSC93kMDNJ36EFVKSvBrRZ0tpTTRTeaJp+OKM6kaZjeRqH1nni7Y/NTOsW6e HlOYkrjQ3Ir88Tk1kEFOkrwM34iEAwccnXBtYK2zcrvrR3o71Eh1M62wemgSsE5ZFoth F6yZvdJZgpZTZDq6jzOeUPGgI/Wp2KBZK2lxpZSwJKsskoWDkseWhM0TTdY73AvJoSjV wMM8wDv54khIB9bEnJRzCJNF20y3PR+3jF7fXZ9EA+K6JdynYD8S9Ptm2bXWUA027lTV 16MWycWmKqYyy55GoW5zmbPqZud6a7VdVj5CXpHHQILVwG405U9JyvKcRYa70pgY43BB CKuA== X-Gm-Message-State: ALoCoQlzCToIwhyR/6TC9KPyYFrY7gl/9R/ThZPLumW1uss8uxKBiZBw/pZXyyRXxOJ716MXuLrc X-Received: by 10.180.229.163 with SMTP id sr3mr2541216wic.95.1445946261841; Tue, 27 Oct 2015 04:44:21 -0700 (PDT) Received: from localhost.localdomain (cag06-6-78-235-100-105.fbx.proxad.net. [78.235.100.105]) by smtp.gmail.com with ESMTPSA id gd11sm17451281wic.20.2015.10.27.04.44.20 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 27 Oct 2015 04:44:21 -0700 (PDT) From: Bartosz Golaszewski To: Wolfram Sang Cc: linux-i2c , LKML , Bartosz Golaszewski Subject: [PATCH v2 9/9] eeprom: at24: readability tweaks Date: Tue, 27 Oct 2015 12:43:53 +0100 Message-Id: <1445946233-6071-10-git-send-email-bgolaszewski@baylibre.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1445946233-6071-1-git-send-email-bgolaszewski@baylibre.com> References: <1445946233-6071-1-git-send-email-bgolaszewski@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Move the macro definitions above the struct definitions and add some tabs for better readability. Signed-off-by: Bartosz Golaszewski --- drivers/misc/eeprom/at24.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c index 65f1479..d624311 100644 --- a/drivers/misc/eeprom/at24.c +++ b/drivers/misc/eeprom/at24.c @@ -52,6 +52,14 @@ * which won't work on pure SMBus systems. */ +#define AT24_SIZE_BYTELEN 5 +#define AT24_SIZE_FLAGS 8 + +#define AT24_BITMASK(x) (BIT(x) - 1) + +#define AT24CS_SERIAL_SIZE 16 +#define AT24CS_SERIAL_ADDR(addr) (addr + 0x08) + struct at24_data { struct at24_platform_data chip; struct memory_accessor macc; @@ -98,14 +106,6 @@ static unsigned write_timeout = 25; module_param(write_timeout, uint, 0); MODULE_PARM_DESC(write_timeout, "Time (in ms) to try writes (default 25)"); -#define AT24_SIZE_BYTELEN 5 -#define AT24_SIZE_FLAGS 8 - -#define AT24_BITMASK(x) (BIT(x) - 1) - -#define AT24CS_SERIAL_SIZE 16 -#define AT24CS_SERIAL_ADDR(addr) (addr + 0x08) - /* create non-zero magic value for given eeprom parameters */ #define AT24_DEVICE_MAGIC(_len, _flags) \ ((1 << AT24_SIZE_FLAGS | (_flags)) \