From patchwork Mon Mar 30 20:17:12 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 46546 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f72.google.com (mail-la0-f72.google.com [209.85.215.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 8FCAB218BE for ; Mon, 30 Mar 2015 20:18:28 +0000 (UTC) Received: by labpk9 with SMTP id pk9sf5921807lab.1 for ; Mon, 30 Mar 2015 13:18:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=svAFgfAh4OOHpZ7OPVDDxo94VyGdlraqDGQua3A6xxk=; b=AmzNupfUbZYcw3zKfjw8j1Bcbz0Pl1ST8L8lhS8xAnjYrBVGIPPW7KyZtIfo+BuUK5 02fffLzHwAbLIIg3Hagmf3nmfLBxTUba551y7rvrGc+H/Ds10BUzekAr7A2Y2WRO4xyZ Lmsv7PtBIcLISL4n1kdS1W37O/GAgzfggMNhRr1mEs5jV0D5nA8NiYrM0xcp5nxmAWSu ypmgiXX0runGXcQFOxht1j1CCG7IpJL5FGFFRh+fDZkm5yrRDGPR41iz5MWXc0mxcJ4q 4Mhf2+BMA1uo3eW0/pZvQA8XFn3PVTA3/A7mOKHajpG6eItGNiLepLb/8r5nSVzYvK+Y IvxA== X-Gm-Message-State: ALoCoQnqbciRJa0IJBgNL03z8WHtrLNJJWM+ZTnoJQcTnLGC1UvqbWg5hG9XngJ9ILerAKdzXp7M X-Received: by 10.152.163.99 with SMTP id yh3mr7573463lab.8.1427746707543; Mon, 30 Mar 2015 13:18:27 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.45.98 with SMTP id l2ls517885lam.28.gmail; Mon, 30 Mar 2015 13:18:27 -0700 (PDT) X-Received: by 10.152.19.199 with SMTP id h7mr28907220lae.32.1427746707370; Mon, 30 Mar 2015 13:18:27 -0700 (PDT) Received: from mail-la0-f47.google.com (mail-la0-f47.google.com. [209.85.215.47]) by mx.google.com with ESMTPS id bb1si7724230lab.113.2015.03.30.13.18.27 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Mar 2015 13:18:27 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.47 as permitted sender) client-ip=209.85.215.47; Received: by labe2 with SMTP id e2so112802838lab.3 for ; Mon, 30 Mar 2015 13:18:27 -0700 (PDT) X-Received: by 10.112.8.101 with SMTP id q5mr28230996lba.19.1427746707241; Mon, 30 Mar 2015 13:18:27 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.57.201 with SMTP id k9csp1368335lbq; Mon, 30 Mar 2015 13:18:26 -0700 (PDT) X-Received: by 10.66.217.198 with SMTP id pa6mr20319801pac.49.1427746704741; Mon, 30 Mar 2015 13:18:24 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id vz4si16190500pac.137.2015.03.30.13.18.23; Mon, 30 Mar 2015 13:18:24 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754599AbbC3UST (ORCPT + 27 others); Mon, 30 Mar 2015 16:18:19 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:34792 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754549AbbC3URh (ORCPT ); Mon, 30 Mar 2015 16:17:37 -0400 Received: by wgbdm7 with SMTP id dm7so81447139wgb.1 for ; Mon, 30 Mar 2015 13:17:36 -0700 (PDT) X-Received: by 10.194.234.40 with SMTP id ub8mr68327218wjc.100.1427746656361; Mon, 30 Mar 2015 13:17:36 -0700 (PDT) Received: from mai.lan (135-224-190-109.dsl.ovh.fr. [109.190.224.135]) by mx.google.com with ESMTPSA id ha10sm17205957wjc.37.2015.03.30.13.17.34 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 30 Mar 2015 13:17:35 -0700 (PDT) From: Daniel Lezcano To: tglx@linutronix.de, mingo@kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, maxime.ripard@free-electrons.com, viresh.kumar@linaro.org, ben.dooks@codethink.co.uk, digetx@gmail.com, hdegoede@redhat.com, laurent.pinchart+renesas@ideasonboard.com Subject: [PATCH 10/11] clocksource: dw_apb_timer_of: Make IO endian agnostic Date: Mon, 30 Mar 2015 22:17:12 +0200 Message-Id: <1427746633-9137-10-git-send-email-daniel.lezcano@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1427746633-9137-1-git-send-email-daniel.lezcano@linaro.org> References: <5519AEB2.8050306@linaro.org> <1427746633-9137-1-git-send-email-daniel.lezcano@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: daniel.lezcano@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.47 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Ben Dooks The dw_apb_timer_of timer is using __raw_readl to access the timer register, which is causing issues when the system is running in big endian mode. Fix this by using readl_relaxed() which should account for the endian settings. This fixes issues where the time jumps around in the dmesg output due to returnling __le32 values. For an example, these two console lines show time running backwards: [ 49.882572] CPU1: failed to come online [ 43.282457] Brought up 1 CPUs Signed-off-by: Ben Dooks Cc: Daniel Lezcano Cc: Thomas Gleixner Cc: Linux ARM Kernel Cc: Dinh Nguyen Signed-off-by: Daniel Lezcano Acked-by: Nicolas Ferre --- drivers/clocksource/dw_apb_timer_of.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clocksource/dw_apb_timer_of.c b/drivers/clocksource/dw_apb_timer_of.c index d305fb0..a19a3f6 100644 --- a/drivers/clocksource/dw_apb_timer_of.c +++ b/drivers/clocksource/dw_apb_timer_of.c @@ -108,7 +108,7 @@ static void __init add_clocksource(struct device_node *source_timer) static u64 notrace read_sched_clock(void) { - return ~__raw_readl(sched_io_base); + return ~readl_relaxed(sched_io_base); } static const struct of_device_id sptimer_ids[] __initconst = {