From patchwork Wed Jan 7 16:10:14 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Thompson X-Patchwork-Id: 42836 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ee0-f72.google.com (mail-ee0-f72.google.com [74.125.83.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 57E342055F for ; Wed, 7 Jan 2015 16:10:33 +0000 (UTC) Received: by mail-ee0-f72.google.com with SMTP id e53sf2819515eek.3 for ; Wed, 07 Jan 2015 08:10:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=zlKvjSHvRFdgMaEo/P5g3ykX161yefPQc7W7YnP5Uik=; b=NHAmK30r2vwcUQGJcQw2hgDmsMs7rtn5ujTNI7IHX/E+Noh2ffhwT5dCGNYE4vlIlB 1w7jnFANTjx/2ZdN8fyji9AbWeMhVicyxYPzywqX8Obb1RcFXt2X9Ma+VxfFC5esHI6a 73/bfCGfw6g8jw9kTZjtXrsX3l3EJOW+Jgujl6sj1hXI5Jp9+V2p1D1G8E6Plv7c2tmN JJDREKZXQJveVZexGT4hTr6vz6LJQnFT7/IDhJv5AFxmK1madDZz50kLQ4q9KFXBtDkN gXC6qkQ6iuObC3xiSEIimmrFDj+oU2zZmZVzjwI+g6wGgnqjOB2BUFp9ReyFAWwQhiuM aV8g== X-Gm-Message-State: ALoCoQn8RjYLggdpN0VAPl5WwnHPO6bFnNFrHxqziyBLngmH+Jp4z6JKJkXO8IAiaQY9KVrDluO0 X-Received: by 10.180.24.35 with SMTP id r3mr628258wif.0.1420647032571; Wed, 07 Jan 2015 08:10:32 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.205.66 with SMTP id le2ls186186lac.90.gmail; Wed, 07 Jan 2015 08:10:32 -0800 (PST) X-Received: by 10.152.20.98 with SMTP id m2mr5937623lae.49.1420647032409; Wed, 07 Jan 2015 08:10:32 -0800 (PST) Received: from mail-la0-f52.google.com (mail-la0-f52.google.com. [209.85.215.52]) by mx.google.com with ESMTPS id h5si3682587lbs.69.2015.01.07.08.10.32 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 07 Jan 2015 08:10:32 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.52 as permitted sender) client-ip=209.85.215.52; Received: by mail-la0-f52.google.com with SMTP id hs14so4316312lab.11 for ; Wed, 07 Jan 2015 08:10:32 -0800 (PST) X-Received: by 10.112.98.99 with SMTP id eh3mr5904213lbb.32.1420647032187; Wed, 07 Jan 2015 08:10:32 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.112.9.200 with SMTP id c8csp1529108lbb; Wed, 7 Jan 2015 08:10:30 -0800 (PST) X-Received: by 10.194.60.19 with SMTP id d19mr7728374wjr.48.1420647030129; Wed, 07 Jan 2015 08:10:30 -0800 (PST) Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com. [209.85.212.176]) by mx.google.com with ESMTPS id q7si4978722wja.145.2015.01.07.08.10.29 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 07 Jan 2015 08:10:30 -0800 (PST) Received-SPF: pass (google.com: domain of daniel.thompson@linaro.org designates 209.85.212.176 as permitted sender) client-ip=209.85.212.176; Received: by mail-wi0-f176.google.com with SMTP id ex7so7827173wid.15 for ; Wed, 07 Jan 2015 08:10:29 -0800 (PST) X-Received: by 10.180.76.201 with SMTP id m9mr49147043wiw.52.1420647027175; Wed, 07 Jan 2015 08:10:27 -0800 (PST) Received: from sundance.lan (cpc4-aztw19-0-0-cust157.18-1.cable.virginm.net. [82.33.25.158]) by mx.google.com with ESMTPSA id s4sm18370956wiy.13.2015.01.07.08.10.25 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Jan 2015 08:10:26 -0800 (PST) From: Daniel Thompson To: Jason Wessel Cc: Daniel Thompson , linux-kernel@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, Andrew Morton , Ingo Molnar , patches@linaro.org, linaro-kernel@lists.linaro.org, John Stultz , Sumit Semwal Subject: [RESEND PATCH 3.19-rc2 3/3] kdb: Const qualifier for kdb_getstr's prompt argument Date: Wed, 7 Jan 2015 16:10:14 +0000 Message-Id: <1420647014-4897-4-git-send-email-daniel.thompson@linaro.org> X-Mailer: git-send-email 1.9.3 In-Reply-To: <1420647014-4897-1-git-send-email-daniel.thompson@linaro.org> References: <1410438579-7839-1-git-send-email-daniel.thompson@linaro.org> <1420647014-4897-1-git-send-email-daniel.thompson@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: daniel.thompson@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.52 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , All current callers of kdb_getstr() can pass constant pointers via the prompt argument. This patch adds a const qualification to make explicit the fact that this is safe. Signed-off-by: Daniel Thompson --- kernel/debug/kdb/kdb_io.c | 2 +- kernel/debug/kdb/kdb_private.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c index 70e0f494d3f8..59a6071139bc 100644 --- a/kernel/debug/kdb/kdb_io.c +++ b/kernel/debug/kdb/kdb_io.c @@ -439,7 +439,7 @@ poll_again: * substituted for %d, %x or %o in the prompt. */ -char *kdb_getstr(char *buffer, size_t bufsize, char *prompt) +char *kdb_getstr(char *buffer, size_t bufsize, const char *prompt) { if (prompt && kdb_prompt_str != prompt) strncpy(kdb_prompt_str, prompt, CMD_BUFLEN); diff --git a/kernel/debug/kdb/kdb_private.h b/kernel/debug/kdb/kdb_private.h index 30ed4f3d8606..aa90a6a63e88 100644 --- a/kernel/debug/kdb/kdb_private.h +++ b/kernel/debug/kdb/kdb_private.h @@ -212,7 +212,7 @@ extern void kdb_ps1(const struct task_struct *p); extern void kdb_print_nameval(const char *name, unsigned long val); extern void kdb_send_sig_info(struct task_struct *p, struct siginfo *info); extern void kdb_meminfo_proc_show(void); -extern char *kdb_getstr(char *, size_t, char *); +extern char *kdb_getstr(char *, size_t, const char *); extern void kdb_gdb_state_pass(char *buf); /* Defines for kdb_symbol_print */