From patchwork Wed Jan 7 15:42:32 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Thompson X-Patchwork-Id: 42832 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f69.google.com (mail-la0-f69.google.com [209.85.215.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id AAE3A2055F for ; Wed, 7 Jan 2015 15:42:58 +0000 (UTC) Received: by mail-la0-f69.google.com with SMTP id gd6sf2404922lab.0 for ; Wed, 07 Jan 2015 07:42:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=/YxdPcUaB5cbdjohS8epOH9Fy6At8EIGGWHqhh2zB/M=; b=KEbkla9crNlbbR/G/SUTL6ZmMphpyv36AESfA7nKG3dd42P2fiqheGBbIg2v5A5/gG q+f/pnGiN35JZtQ8yTy919Cvg9e/3xmHKdnwZPsYkhu/17Xa+pG+4Yr1KxeHdHl+lj9X ADHJqd7msZEd7QDUTyAMo/VBTZ6fxp8+cczDWcVXSbZzY4CiJ6Pm4wmmdZlyWieV+IDa QRZIK5x6a/iiEAkigYyvMdViKMtqikaEMQxmtW+xM5HvJjnRxEwxa6DC4x8SBGwkNQZa cjpFn1OAZb5WWCc9+ZcR+ngAloJWqjKHA6RDoRo08y99LaPi+UlynGMwhVMvAoLjDgpb r31A== X-Gm-Message-State: ALoCoQlH2NWO1CFugxsCc4YwsKZ6IIkDsIqkCo2/ZI+faS9sHt33Vl8tqGg29gB/vI83APbS14wF X-Received: by 10.112.160.41 with SMTP id xh9mr352601lbb.12.1420645377553; Wed, 07 Jan 2015 07:42:57 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.234.132 with SMTP id ue4ls150194lac.58.gmail; Wed, 07 Jan 2015 07:42:57 -0800 (PST) X-Received: by 10.112.150.194 with SMTP id uk2mr5714394lbb.84.1420645377418; Wed, 07 Jan 2015 07:42:57 -0800 (PST) Received: from mail-la0-f45.google.com (mail-la0-f45.google.com. [209.85.215.45]) by mx.google.com with ESMTPS id mj9si3536590lbc.65.2015.01.07.07.42.57 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 07 Jan 2015 07:42:57 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.45 as permitted sender) client-ip=209.85.215.45; Received: by mail-la0-f45.google.com with SMTP id gq15so4188761lab.4 for ; Wed, 07 Jan 2015 07:42:57 -0800 (PST) X-Received: by 10.112.52.229 with SMTP id w5mr5707350lbo.52.1420645377145; Wed, 07 Jan 2015 07:42:57 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.112.9.200 with SMTP id c8csp1520307lbb; Wed, 7 Jan 2015 07:42:55 -0800 (PST) X-Received: by 10.180.76.144 with SMTP id k16mr8464690wiw.3.1420645375559; Wed, 07 Jan 2015 07:42:55 -0800 (PST) Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com. [74.125.82.44]) by mx.google.com with ESMTPS id m1si4785680wje.153.2015.01.07.07.42.55 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 07 Jan 2015 07:42:55 -0800 (PST) Received-SPF: pass (google.com: domain of daniel.thompson@linaro.org designates 74.125.82.44 as permitted sender) client-ip=74.125.82.44; Received: by mail-wg0-f44.google.com with SMTP id b13so1414474wgh.3 for ; Wed, 07 Jan 2015 07:42:55 -0800 (PST) X-Received: by 10.194.108.162 with SMTP id hl2mr7364396wjb.134.1420645375248; Wed, 07 Jan 2015 07:42:55 -0800 (PST) Received: from sundance.lan (cpc4-aztw19-0-0-cust157.18-1.cable.virginm.net. [82.33.25.158]) by mx.google.com with ESMTPSA id u13sm2561604wjr.26.2015.01.07.07.42.53 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Jan 2015 07:42:54 -0800 (PST) From: Daniel Thompson To: Jason Wessel Cc: Daniel Thompson , linux-kernel@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, Andrew Morton , Ingo Molnar , patches@linaro.org, linaro-kernel@lists.linaro.org, John Stultz , Sumit Semwal Subject: [RESEND PATCH v3.19-rc2] kdb: Remove stack dump when entering kgdb due to NMI Date: Wed, 7 Jan 2015 15:42:32 +0000 Message-Id: <1420645352-2790-1-git-send-email-daniel.thompson@linaro.org> X-Mailer: git-send-email 1.9.3 In-Reply-To: <1405518033-11671-1-git-send-email-daniel.thompson@linaro.org> References: <1405518033-11671-1-git-send-email-daniel.thompson@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: daniel.thompson@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.45 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Issuing a stack dump feels ergonomically wrong when entering due to NMI. Entering due to NMI is normally a reaction to a user request, either the NMI button on a server or a "magic knock" on a UART. Therefore the backtrace behaviour on entry due to NMI should be like SysRq-g (no stack dump) rather than like oops. Note also that the stack dump does not offer any information that cannot be trivial retrieved using the 'bt' command. Signed-off-by: Daniel Thompson Cc: Jason Wessel --- kernel/debug/kdb/kdb_main.c | 1 - 1 file changed, 1 deletion(-) -- 1.9.3 diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c index 379650b984f8..f9ba42363132 100644 --- a/kernel/debug/kdb/kdb_main.c +++ b/kernel/debug/kdb/kdb_main.c @@ -1207,7 +1207,6 @@ static int kdb_local(kdb_reason_t reason, int error, struct pt_regs *regs, kdb_printf("due to NonMaskable Interrupt @ " kdb_machreg_fmt "\n", instruction_pointer(regs)); - kdb_dumpregs(regs); break; case KDB_REASON_SSTEP: case KDB_REASON_BREAK: