From patchwork Fri Nov 14 18:29:58 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Scott Branden X-Patchwork-Id: 40851 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f71.google.com (mail-wg0-f71.google.com [74.125.82.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 07B0A240ED for ; Fri, 14 Nov 2014 18:31:05 +0000 (UTC) Received: by mail-wg0-f71.google.com with SMTP id b13sf9384235wgh.10 for ; Fri, 14 Nov 2014 10:31:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=CM3Zy+fXybit+xFRj8gnNPnitSLWzOtDzkMuvFc1wGg=; b=h46oj9y9rNxkXUN7G5eW7Ej1kZk72NR4YNH1ifHA1UpLcnu8FDFPHxrAhj+aEfYsf/ siUeBaoThZ2kGYtXG4m9j3moMmWwDupw7aLtFpn5MNhMTE/gHkfpDRyPX6tHaBpjIjoc MtQ2CtETuMjtH96J9//yIK3CoHJPziZ+nVgI80pIQ3fl7M+1LYnLbXbF+0LQxdE3Smqg zFn6rDknY6eSufGQY9f5I2MyDaLuhaCpcvEeL7lXryZdsDXGyqABiGuqZZ4oLHKOE/cA +TJfOrZR3+8M0fewcfQky7RHWyMXDzsYbfvRL1IslQYJnn5gqWCGP9f+8dO1HuzsJk9J gGHA== X-Gm-Message-State: ALoCoQmztv1OnoZyH59O6uPnNqsW1v7TljUC3n750XSzpdjzKU7DAJRRtGuAz9nYa49JuA3IKhqx X-Received: by 10.112.147.131 with SMTP id tk3mr4655100lbb.2.1415989864255; Fri, 14 Nov 2014 10:31:04 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.170.227 with SMTP id ap3ls951142lac.60.gmail; Fri, 14 Nov 2014 10:31:03 -0800 (PST) X-Received: by 10.112.159.129 with SMTP id xc1mr9830280lbb.24.1415989863939; Fri, 14 Nov 2014 10:31:03 -0800 (PST) Received: from mail-lb0-f176.google.com (mail-lb0-f176.google.com. [209.85.217.176]) by mx.google.com with ESMTPS id bn10si42431625lbc.108.2014.11.14.10.31.03 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 14 Nov 2014 10:31:03 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.176 as permitted sender) client-ip=209.85.217.176; Received: by mail-lb0-f176.google.com with SMTP id 10so13070520lbg.21 for ; Fri, 14 Nov 2014 10:31:03 -0800 (PST) X-Received: by 10.152.37.69 with SMTP id w5mr9514929laj.67.1415989863614; Fri, 14 Nov 2014 10:31:03 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.184.201 with SMTP id ew9csp812969lbc; Fri, 14 Nov 2014 10:31:02 -0800 (PST) X-Received: by 10.68.132.225 with SMTP id ox1mr11787463pbb.85.1415989861856; Fri, 14 Nov 2014 10:31:01 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ek5si1145184pbd.113.2014.11.14.10.31.01 for ; Fri, 14 Nov 2014 10:31:01 -0800 (PST) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965836AbaKNSan (ORCPT + 26 others); Fri, 14 Nov 2014 13:30:43 -0500 Received: from mail-gw3-out.broadcom.com ([216.31.210.64]:30361 "EHLO mail-gw3-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965800AbaKNSak (ORCPT ); Fri, 14 Nov 2014 13:30:40 -0500 X-IronPort-AV: E=Sophos;i="5.07,387,1413270000"; d="scan'208";a="50573360" Received: from irvexchcas08.broadcom.com (HELO IRVEXCHCAS08.corp.ad.broadcom.com) ([10.9.208.57]) by mail-gw3-out.broadcom.com with ESMTP; 14 Nov 2014 10:37:13 -0800 Received: from IRVEXCHSMTP1.corp.ad.broadcom.com (10.9.207.51) by IRVEXCHCAS08.corp.ad.broadcom.com (10.9.208.57) with Microsoft SMTP Server (TLS) id 14.3.174.1; Fri, 14 Nov 2014 10:31:04 -0800 Received: from mail-irva-13.broadcom.com (10.10.10.20) by IRVEXCHSMTP1.corp.ad.broadcom.com (10.9.207.51) with Microsoft SMTP Server id 14.3.174.1; Fri, 14 Nov 2014 10:30:38 -0800 Received: from mail.broadcom.com (lbrmn-lnxub113.ric.broadcom.com [10.136.13.65]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id 924FD411BF; Fri, 14 Nov 2014 10:29:53 -0800 (PST) From: Scott Branden To: Scott Branden , Thierry Reding CC: Ray Jui , Arun Ramamurthy , , , Subject: [PATCH 2/4] pwm: kona: Fix incorrect enable after channel polarity change Date: Fri, 14 Nov 2014 10:29:58 -0800 Message-ID: <1415989800-7515-3-git-send-email-sbranden@broadcom.com> X-Mailer: git-send-email 2.1.3 In-Reply-To: <1415989800-7515-1-git-send-email-sbranden@broadcom.com> References: <1415989800-7515-1-git-send-email-sbranden@broadcom.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: sbranden@broadcom.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.176 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Arun Ramamurthy The pwm core code requires a separate call for enabling the channel and hence the driver does not need to set pwm_trigger after a polarity change Signed-off-by: Arun Ramamurthy Reviewed-by: Ray Jui Signed-off-by: Scott Branden --- drivers/pwm/pwm-bcm-kona.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/pwm/pwm-bcm-kona.c b/drivers/pwm/pwm-bcm-kona.c index 29eef9e..fa0b5bf 100644 --- a/drivers/pwm/pwm-bcm-kona.c +++ b/drivers/pwm/pwm-bcm-kona.c @@ -173,11 +173,6 @@ static int kona_pwmc_set_polarity(struct pwm_chip *chip, struct pwm_device *pwm, writel(value, kp->base + PWM_CONTROL_OFFSET); - kona_pwmc_apply_settings(kp, chan); - - /* Wait for waveform to settle before gating off the clock */ - ndelay(400); - clk_disable_unprepare(kp->clk); return 0;