From patchwork Fri Nov 14 18:29:57 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Scott Branden X-Patchwork-Id: 40852 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f71.google.com (mail-wg0-f71.google.com [74.125.82.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id CE4A824528 for ; Fri, 14 Nov 2014 18:31:05 +0000 (UTC) Received: by mail-wg0-f71.google.com with SMTP id b13sf9502385wgh.6 for ; Fri, 14 Nov 2014 10:31:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=FAmx7qwIlR2/8bwj864nA+NbT3p85MvvPyxt+CV4y58=; b=SZhcOR+DqBbhbgZu2Aw8DnHXkucGcL8MvfUcAIKMM+9VswtJ69qEftfVYuKAiD3lQM Dxgb80HMeUjJksYg4DBXDkvrLraFf42Suz404izdlx6/nKl/pIwqVnIiGwCkWqgINHBp Upz/mughKmiik6S5ZoGhrHCgzeTgfrbi3RR8TLaxbu0twwM2XybpaYS94toFI1/iDTXY iy5HYGqoDySygtAsjswFJzM5z3ZnO0C8jjPA98nD+CfnJzRGRtR9LHnX/NRVpLU2KMbh MkXdvjWfHS4SG9nspjH0YvKOqrsh7nThmF2Mc5ofY+YlnF2mXkj7XwxOZYFJ1Y/5JHA6 vbOw== X-Gm-Message-State: ALoCoQmABJBGo6gj9RrJWp4ycmQ7/zjt+XFzcmXltzBdBMhglLzjThitAu8OthfP+HFiYjanhKqy X-Received: by 10.152.8.67 with SMTP id p3mr1228855laa.4.1415989865117; Fri, 14 Nov 2014 10:31:05 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.8.68 with SMTP id p4ls980573laa.52.gmail; Fri, 14 Nov 2014 10:31:04 -0800 (PST) X-Received: by 10.152.234.227 with SMTP id uh3mr9780073lac.69.1415989864941; Fri, 14 Nov 2014 10:31:04 -0800 (PST) Received: from mail-lb0-f172.google.com (mail-lb0-f172.google.com. [209.85.217.172]) by mx.google.com with ESMTPS id qi2si42565339lbb.47.2014.11.14.10.31.04 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 14 Nov 2014 10:31:04 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.172 as permitted sender) client-ip=209.85.217.172; Received: by mail-lb0-f172.google.com with SMTP id u10so5813854lbd.17 for ; Fri, 14 Nov 2014 10:31:04 -0800 (PST) X-Received: by 10.112.52.37 with SMTP id q5mr9617039lbo.32.1415989864853; Fri, 14 Nov 2014 10:31:04 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.184.201 with SMTP id ew9csp812975lbc; Fri, 14 Nov 2014 10:31:04 -0800 (PST) X-Received: by 10.68.246.164 with SMTP id xx4mr12105131pbc.64.1415989862587; Fri, 14 Nov 2014 10:31:02 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ek5si1145184pbd.113.2014.11.14.10.31.01 for ; Fri, 14 Nov 2014 10:31:02 -0800 (PST) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161511AbaKNSaq (ORCPT + 26 others); Fri, 14 Nov 2014 13:30:46 -0500 Received: from mail-gw3-out.broadcom.com ([216.31.210.64]:30361 "EHLO mail-gw3-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965734AbaKNSak (ORCPT ); Fri, 14 Nov 2014 13:30:40 -0500 X-IronPort-AV: E=Sophos;i="5.07,387,1413270000"; d="scan'208";a="50573350" Received: from irvexchcas07.broadcom.com (HELO IRVEXCHCAS07.corp.ad.broadcom.com) ([10.9.208.55]) by mail-gw3-out.broadcom.com with ESMTP; 14 Nov 2014 10:37:12 -0800 Received: from IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) by IRVEXCHCAS07.corp.ad.broadcom.com (10.9.208.55) with Microsoft SMTP Server (TLS) id 14.3.174.1; Fri, 14 Nov 2014 10:31:03 -0800 Received: from mail-irva-13.broadcom.com (10.10.10.20) by IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) with Microsoft SMTP Server id 14.3.174.1; Fri, 14 Nov 2014 10:30:39 -0800 Received: from mail.broadcom.com (lbrmn-lnxub113.ric.broadcom.com [10.136.13.65]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id D857341036; Fri, 14 Nov 2014 10:29:50 -0800 (PST) From: Scott Branden To: Scott Branden , Thierry Reding CC: Ray Jui , Arun Ramamurthy , , , Subject: [PATCH 1/4] pwm: kona: Remove setting default smooth type and polarity for all channels Date: Fri, 14 Nov 2014 10:29:57 -0800 Message-ID: <1415989800-7515-2-git-send-email-sbranden@broadcom.com> X-Mailer: git-send-email 2.1.3 In-Reply-To: <1415989800-7515-1-git-send-email-sbranden@broadcom.com> References: <1415989800-7515-1-git-send-email-sbranden@broadcom.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: sbranden@broadcom.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.172 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Arun Ramamurthy The probe routine unnecessarily sets the smooth type and polarity for all channels. This causes the channel for the speaker to click at the same time the backlight turns on. The smooth type and polarity should be set individually for each channel as required and no defaults need to be set. Signed-off-by: Arun Ramamurthy Reviewed-by: Ray Jui Signed-off-by: Scott Branden --- drivers/pwm/pwm-bcm-kona.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/pwm/pwm-bcm-kona.c b/drivers/pwm/pwm-bcm-kona.c index 02bc048..29eef9e 100644 --- a/drivers/pwm/pwm-bcm-kona.c +++ b/drivers/pwm/pwm-bcm-kona.c @@ -266,12 +266,9 @@ static int kona_pwmc_probe(struct platform_device *pdev) return ret; } - /* Set smooth mode, push/pull, and normal polarity for all channels */ - for (chan = 0; chan < kp->chip.npwm; chan++) { - value |= (1 << PWM_CONTROL_SMOOTH_SHIFT(chan)); + /* Set push/pull for all channels */ + for (chan = 0; chan < kp->chip.npwm; chan++) value |= (1 << PWM_CONTROL_TYPE_SHIFT(chan)); - value |= (1 << PWM_CONTROL_POLARITY_SHIFT(chan)); - } writel(value, kp->base + PWM_CONTROL_OFFSET);