From patchwork Wed Oct 15 11:27:26 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Szyprowski X-Patchwork-Id: 38776 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f70.google.com (mail-la0-f70.google.com [209.85.215.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 246FD20C4E for ; Wed, 15 Oct 2014 11:27:55 +0000 (UTC) Received: by mail-la0-f70.google.com with SMTP id ge10sf592262lab.1 for ; Wed, 15 Oct 2014 04:27:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=pL3QIENX3IPhEfBJfw/Wj/1vGGKimzFcaATS5rGUSnI=; b=D28scVcGsHDOx/VM5Cw0MEX1vHKQW9zILmEmnWedV0WKprXFOaXCXjjtUxYPsc/t7T AtxkDoVLlvvnW3ylQtRODjpDIa9e3U1FDwH2HM0uDTqXDWbkD4PBK0Bod1GYirmIqt4G B1Uft9/RqIIYb1NvY3TU5kNGjj69eI7eaxscmkkKbi4L339jawvmPkBy1q1Ty3Bdq97I Ixno/+8xGwn4PTLh1o7AP+ei8CIPuRhnbkYK1D4CyqQPO7AZAJEkL/qo0zFwRJmy/nzw frR21ZBN849ObeB0UjsJNe0NB6OmW1cxiyvL5uzPrYFwOwWC3wEstfluT7SxVkv0Av9D jJHQ== X-Gm-Message-State: ALoCoQkAUBMhPbeVka1ta5H/+f9F2FbnzCGGr0R2niJJNEdekl3aMcfP9U5LjwIEdOdQnENxIKOM X-Received: by 10.180.36.176 with SMTP id r16mr1329666wij.7.1413372473868; Wed, 15 Oct 2014 04:27:53 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.116.8 with SMTP id js8ls49793lab.69.gmail; Wed, 15 Oct 2014 04:27:53 -0700 (PDT) X-Received: by 10.112.167.130 with SMTP id zo2mr11747462lbb.4.1413372473675; Wed, 15 Oct 2014 04:27:53 -0700 (PDT) Received: from mail-la0-f41.google.com (mail-la0-f41.google.com [209.85.215.41]) by mx.google.com with ESMTPS id u2si30097847lal.70.2014.10.15.04.27.53 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 15 Oct 2014 04:27:53 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) client-ip=209.85.215.41; Received: by mail-la0-f41.google.com with SMTP id pn19so862146lab.0 for ; Wed, 15 Oct 2014 04:27:53 -0700 (PDT) X-Received: by 10.152.29.8 with SMTP id f8mr11664260lah.56.1413372473321; Wed, 15 Oct 2014 04:27:53 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.84.229 with SMTP id c5csp573691lbz; Wed, 15 Oct 2014 04:27:52 -0700 (PDT) X-Received: by 10.66.218.168 with SMTP id ph8mr11574127pac.51.1413372471853; Wed, 15 Oct 2014 04:27:51 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t1si15438242pda.50.2014.10.15.04.27.51 for ; Wed, 15 Oct 2014 04:27:51 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752423AbaJOL1s (ORCPT + 27 others); Wed, 15 Oct 2014 07:27:48 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:57898 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752393AbaJOL1r (ORCPT ); Wed, 15 Oct 2014 07:27:47 -0400 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NDH00BBFHB0PVB0@mailout3.w1.samsung.com> for linux-kernel@vger.kernel.org; Wed, 15 Oct 2014 12:30:36 +0100 (BST) X-AuditID: cbfec7f5-b7f776d000003e54-6f-543e5a305d55 Received: from eusync1.samsung.com ( [203.254.199.211]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id 45.EC.15956.03A5E345; Wed, 15 Oct 2014 12:27:44 +0100 (BST) Received: from amdc1339.digital.local ([106.116.147.30]) by eusync1.samsung.com (Oracle Communications Messaging Server 7u4-23.01 (7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0NDH0053CH64M430@eusync1.samsung.com>; Wed, 15 Oct 2014 12:27:44 +0100 (BST) From: Marek Szyprowski To: linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com Cc: Marek Szyprowski , Kyungmin Park , Alessandro Zummo , Chanwoo Choi , Kukjin Kim Subject: [PATCH] drivers: rtc: fix s3c-rtc initialization failure without rtc source clock Date: Wed, 15 Oct 2014 13:27:26 +0200 Message-id: <1413372446-28541-1-git-send-email-m.szyprowski@samsung.com> X-Mailer: git-send-email 1.9.2 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrJJMWRmVeSWpSXmKPExsVy+t/xy7oGUXYhBk8/SlksuXiV3eL6l+es Fr0LrrJZnG16w25xedccNou1R+6yW+zv7GB0YPfYM/Ekm0ffllWMHtPn/WTy+LxJLoAlissm JTUnsyy1SN8ugSujc/Zx9oKnXBV7p35gb2Ds5+xi5OSQEDCRWL/9HyuELSZx4d56NhBbSGAp o8TMDzZdjFxAdh+TxN6zn5hBEmwChhJdb7vAikQEbCQOHb7BDFLELHCZUWL+9TXsIAlhgRiJ aRP7wGwWAVWJk9NvgG3gFfCQ+HPsPwvENjmJ/y9XME1g5F7AyLCKUTS1NLmgOCk910ivODG3 uDQvXS85P3cTIyQ4vu5gXHrM6hCjAAejEg8vxwHbECHWxLLiytxDjBIczEoivDbhdiFCvCmJ lVWpRfnxRaU5qcWHGJk4OKUaGK2V9iseX/J7weLXzfELbJmn7KvfV7dFeJ//3tmHV6/0Ms/7 EyL4yiNbarf4J+t+WYVlx695lb5N1ppaNf+Hn0uAa5uY7vOX96af27p3Wueet1MZKrOy91nI 3oybevPgtYMvHi/8Er/qoPNR8xTWfu07Rppzu4OYpey2rZAtP221ae3/oNkfDq9VYinOSDTU Yi4qTgQAPGZ9suwBAAA= Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: m.szyprowski@samsung.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , This patch fixes unconditional initialization failure on non-exynos3250 SoCs. Commit df9e26d093d33a097c5558aab017dd2f540ccfe5 ("rtc: s3c: add support for RTC of Exynos3250 SoC") introduced rtc source clock support, but also added initialization failure on SoCs, which doesn't need such clock. Signed-off-by: Marek Szyprowski Reviewed-by: Chanwoo Choi --- drivers/rtc/rtc-s3c.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c index a6b1252c9941..806072238c00 100644 --- a/drivers/rtc/rtc-s3c.c +++ b/drivers/rtc/rtc-s3c.c @@ -535,13 +535,15 @@ static int s3c_rtc_probe(struct platform_device *pdev) } clk_prepare_enable(info->rtc_clk); - info->rtc_src_clk = devm_clk_get(&pdev->dev, "rtc_src"); - if (IS_ERR(info->rtc_src_clk)) { - dev_err(&pdev->dev, "failed to find rtc source clock\n"); - return PTR_ERR(info->rtc_src_clk); + if (info->data->needs_src_clk) { + info->rtc_src_clk = devm_clk_get(&pdev->dev, "rtc_src"); + if (IS_ERR(info->rtc_src_clk)) { + dev_err(&pdev->dev, + "failed to find rtc source clock\n"); + return PTR_ERR(info->rtc_src_clk); + } + clk_prepare_enable(info->rtc_src_clk); } - clk_prepare_enable(info->rtc_src_clk); - /* check to see if everything is setup correctly */ if (info->data->enable)