From patchwork Sat Oct 4 14:02:27 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 38348 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f69.google.com (mail-wg0-f69.google.com [74.125.82.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id EBD54203AD for ; Sat, 4 Oct 2014 14:02:44 +0000 (UTC) Received: by mail-wg0-f69.google.com with SMTP id b13sf1572211wgh.0 for ; Sat, 04 Oct 2014 07:02:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=5lmUWEFeulOuW0U9ajaokfvZvxmQBo0pYKyA6Zlpoh8=; b=TNakLFVQ0WwBk6ZkD4Nxmu8rp6DnvMIYeWY5v8yT9B+wcCeLH37sHfKvO1MuXmXiJs FAU25tOEjJVBX0DXv3ZLjkVrMJGpjAKtI17tAL9kAavTLVEdX+4dphnCiv+UufyPjxQ2 SyGVpjWCJ6g6molAk9KjqamWbJEZtKQRqv7RaJ97R6j/lP+4KqGyDaIuB/CgxfiQuDYj Er+DnNShJQ38FPbUs8b4Qd2GkTPAjKv/CDLL4R/q/mICzN6FapUwJ6oJdoUNmZVEeJdx zRRHpY/ifLGrL5RWD0PaDo7S7gVHJq0w56WPXbO0SXuO97EzlxNdE1lXkxob5ToTdlfs 1M2g== X-Gm-Message-State: ALoCoQlCZ6YDF9DXmr/xpN0jevZK60rYcrNgBCUrOC4uAyCA4VckUl1AycbvodEnrG+BlHxi3f5q X-Received: by 10.181.28.169 with SMTP id jp9mr796267wid.6.1412431363829; Sat, 04 Oct 2014 07:02:43 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.9.226 with SMTP id d2ls431654lab.66.gmail; Sat, 04 Oct 2014 07:02:43 -0700 (PDT) X-Received: by 10.152.45.7 with SMTP id i7mr10203142lam.74.1412431363414; Sat, 04 Oct 2014 07:02:43 -0700 (PDT) Received: from mail-la0-f45.google.com (mail-la0-f45.google.com [209.85.215.45]) by mx.google.com with ESMTPS id g8si2734638lae.48.2014.10.04.07.02.43 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 04 Oct 2014 07:02:43 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.45 as permitted sender) client-ip=209.85.215.45; Received: by mail-la0-f45.google.com with SMTP id q1so2398968lam.4 for ; Sat, 04 Oct 2014 07:02:43 -0700 (PDT) X-Received: by 10.152.22.137 with SMTP id d9mr12676421laf.29.1412431363295; Sat, 04 Oct 2014 07:02:43 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.130.169 with SMTP id of9csp37486lbb; Sat, 4 Oct 2014 07:02:42 -0700 (PDT) X-Received: by 10.66.177.135 with SMTP id cq7mr13570235pac.44.1412431361812; Sat, 04 Oct 2014 07:02:41 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id aj3si9464575pbd.126.2014.10.04.07.02.41 for ; Sat, 04 Oct 2014 07:02:41 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752176AbaJDOCj (ORCPT + 27 others); Sat, 4 Oct 2014 10:02:39 -0400 Received: from mail-lb0-f181.google.com ([209.85.217.181]:46609 "EHLO mail-lb0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750850AbaJDOCi (ORCPT ); Sat, 4 Oct 2014 10:02:38 -0400 Received: by mail-lb0-f181.google.com with SMTP id l4so2263747lbv.40 for ; Sat, 04 Oct 2014 07:02:36 -0700 (PDT) X-Received: by 10.112.202.1 with SMTP id ke1mr12119050lbc.33.1412431356360; Sat, 04 Oct 2014 07:02:36 -0700 (PDT) Received: from localhost.localdomain (c83-254-157-117.bredband.comhem.se. [83.254.157.117]) by mx.google.com with ESMTPSA id j3sm3762011lbs.0.2014.10.04.07.02.34 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 Oct 2014 07:02:35 -0700 (PDT) From: Linus Walleij To: Samuel Ortiz , Lee Jones , linux-kernel@vger.kernel.org Cc: Linus Walleij Subject: [PATCH] mfd: stmpe: fix STMPE24xx GPMR LSB Date: Sat, 4 Oct 2014 16:02:27 +0200 Message-Id: <1412431347-27230-1-git-send-email-linus.walleij@linaro.org> X-Mailer: git-send-email 1.9.3 Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: linus.walleij@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.45 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The least significat byte of the GPIO value read register on the STMPE24xx series is on addres 0xA4 not 0xA5. Correct against datasheet and tested on the STMPE2401 hardware. Signed-off-by: Linus Walleij --- Hi Lee, Sam: this should go in for fixes I think. --- drivers/mfd/stmpe.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/stmpe.h b/drivers/mfd/stmpe.h index 2d045f26f193..bee0abf82040 100644 --- a/drivers/mfd/stmpe.h +++ b/drivers/mfd/stmpe.h @@ -269,7 +269,7 @@ int stmpe_remove(struct stmpe *stmpe); #define STMPE24XX_REG_CHIP_ID 0x80 #define STMPE24XX_REG_IEGPIOR_LSB 0x18 #define STMPE24XX_REG_ISGPIOR_MSB 0x19 -#define STMPE24XX_REG_GPMR_LSB 0xA5 +#define STMPE24XX_REG_GPMR_LSB 0xA4 #define STMPE24XX_REG_GPSR_LSB 0x85 #define STMPE24XX_REG_GPCR_LSB 0x88 #define STMPE24XX_REG_GPDR_LSB 0x8B