From patchwork Wed Sep 24 13:47:05 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kishon Vijay Abraham I X-Patchwork-Id: 37830 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ee0-f70.google.com (mail-ee0-f70.google.com [74.125.83.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 443D6204FF for ; Wed, 24 Sep 2014 13:53:27 +0000 (UTC) Received: by mail-ee0-f70.google.com with SMTP id b57sf3967195eek.1 for ; Wed, 24 Sep 2014 06:53:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=mHVstiD/rtd/CvaAAMN3zf7Q1AAPuIh2xt76H+zX6AQ=; b=hEWnItwTKNSlQvvoDlanRiZqg2wLKqdjAgC1QAJrbdn5zPywLopCzA62c483XmIg7m pJW96QQeCLqWgrGxA8Za1otby+9bAswUUrCfpTL4XmKqwqwB9cDY37drxiMyaHfmtcS2 Sq/ptd70GE0DJppsxc0GottuTDe7MmBPbgy/b3HqW5WQr5amer5nkpPY03/e0tfApehe aTBicRWtpVS16ADwtNTIm6ItIc2afUyiVq7wAL2dmToCqLr0qfGz72fMp3Dl89BgIpKu lN8EQyur3kpWXldY8L7I5OP5H5dGu+wnZWtqYw1krIX5YQnJFPEugbhofiUhFb5boRs6 8qDQ== X-Gm-Message-State: ALoCoQn3iiIKeEkLHiZq6c0CoL+tUSY4tYrBVi6Ni00DFM7afrx8gS8N2DCj7jg0yUk5fxKQaJM0 X-Received: by 10.194.7.199 with SMTP id l7mr1027776wja.2.1411566806337; Wed, 24 Sep 2014 06:53:26 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.120.200 with SMTP id le8ls171940lab.101.gmail; Wed, 24 Sep 2014 06:53:26 -0700 (PDT) X-Received: by 10.152.206.35 with SMTP id ll3mr6610414lac.88.1411566806087; Wed, 24 Sep 2014 06:53:26 -0700 (PDT) Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com [209.85.217.181]) by mx.google.com with ESMTPS id pc8si22934840lbc.69.2014.09.24.06.53.25 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 24 Sep 2014 06:53:25 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.181 as permitted sender) client-ip=209.85.217.181; Received: by mail-lb0-f181.google.com with SMTP id b6so5379268lbj.26 for ; Wed, 24 Sep 2014 06:53:25 -0700 (PDT) X-Received: by 10.112.62.200 with SMTP id a8mr6318440lbs.34.1411566805555; Wed, 24 Sep 2014 06:53:25 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.130.169 with SMTP id of9csp585823lbb; Wed, 24 Sep 2014 06:53:24 -0700 (PDT) X-Received: by 10.69.20.33 with SMTP id gz1mr9705636pbd.84.1411566804032; Wed, 24 Sep 2014 06:53:24 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id rf9si26232378pbc.221.2014.09.24.06.53.20 for ; Wed, 24 Sep 2014 06:53:24 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754173AbaIXNxR (ORCPT + 27 others); Wed, 24 Sep 2014 09:53:17 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:51001 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753646AbaIXNrt (ORCPT ); Wed, 24 Sep 2014 09:47:49 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id s8ODlmwi031913; Wed, 24 Sep 2014 08:47:48 -0500 Received: from DFLE72.ent.ti.com (dfle72.ent.ti.com [128.247.5.109]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id s8ODlXEW009423; Wed, 24 Sep 2014 08:47:33 -0500 Received: from dlep32.itg.ti.com (157.170.170.100) by DFLE72.ent.ti.com (128.247.5.109) with Microsoft SMTP Server id 14.3.174.1; Wed, 24 Sep 2014 08:47:33 -0500 Received: from a0393678ub.india.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id s8ODlKDQ015622; Wed, 24 Sep 2014 08:47:32 -0500 From: Kishon Vijay Abraham I To: CC: , Subject: [PATCH 07/22] phy: phy-spear1340-miphy: Remove unncessary site specific OOM messages Date: Wed, 24 Sep 2014 19:17:05 +0530 Message-ID: <1411566440-19169-8-git-send-email-kishon@ti.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1411566440-19169-1-git-send-email-kishon@ti.com> References: <1411566440-19169-1-git-send-email-kishon@ti.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: kishon@ti.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.181 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Peter Griffin The site specific OOM messages are unncessary, because they duplicate messages from the memory subsystem which include dump_stack(). Removing these superflous messages makes the kernel smaller. A discussion here http://patchwork.ozlabs.org/patch/324158/ found that all error paths from kzalloc will print a error message, and that any error path which maybe found which doesn't would be considered a bug in kzalloc. Signed-off-by: Peter Griffin Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/phy-spear1340-miphy.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/phy/phy-spear1340-miphy.c b/drivers/phy/phy-spear1340-miphy.c index 7135ba2..ee4d66f 100644 --- a/drivers/phy/phy-spear1340-miphy.c +++ b/drivers/phy/phy-spear1340-miphy.c @@ -249,10 +249,8 @@ static int spear1340_miphy_probe(struct platform_device *pdev) struct phy_provider *phy_provider; priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); - if (!priv) { - dev_err(dev, "can't alloc spear1340_miphy private date memory\n"); + if (!priv) return -ENOMEM; - } priv->misc = syscon_regmap_lookup_by_phandle(dev->of_node, "misc");