From patchwork Wed Sep 24 13:47:04 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kishon Vijay Abraham I X-Patchwork-Id: 37833 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-we0-f199.google.com (mail-we0-f199.google.com [74.125.82.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 13E59204FF for ; Wed, 24 Sep 2014 13:55:06 +0000 (UTC) Received: by mail-we0-f199.google.com with SMTP id t60sf3613634wes.6 for ; Wed, 24 Sep 2014 06:55:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=+BfCXwoxJFrlgXplX/vIU64vGR1m1Dg8QVQfG/SptDY=; b=NcTI+a3EhZdh9v2znbtZqE77ipbWm3ZDizeJAJ5KDRKBnEHP4HKdVZ+W6rl1J/kv+S Fy6OrbgrJe1m+vs4sEcumFG8RDXOeoygz6k/tNu9kmc/JJseQtEo8jc4zdlTnA3LtKMM Ji3/2+euqrlJIXJp2fF8yKmxDYhim/TyCewTv1rQ0Awp/KfB+P0lQIfOAFc0eg4mWKeO DCpHjXnVYx26qfz2pBVxJpohbr7TL5PZKOuTDs0mEt6rzW+l/8ltrI8/3ApQM1V4zJbk doqW3ML/dgMmy0pyiE1Zhyq5e+DXmX86A7P7vjEyZAMQuYksXaAXBT1Pspx2c8zhOyp9 SW2A== X-Gm-Message-State: ALoCoQlMcu5GUD/4OrGXFx7iCcBT99eO3+P1xZAI9PMQ4K1os9aW0bUcTV1wot/OlkxhUo6v71em X-Received: by 10.181.28.169 with SMTP id jp9mr1516224wid.6.1411566906205; Wed, 24 Sep 2014 06:55:06 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.87.132 with SMTP id ay4ls158696lab.46.gmail; Wed, 24 Sep 2014 06:55:06 -0700 (PDT) X-Received: by 10.152.18.130 with SMTP id w2mr6466430lad.89.1411566906025; Wed, 24 Sep 2014 06:55:06 -0700 (PDT) Received: from mail-la0-f46.google.com (mail-la0-f46.google.com [209.85.215.46]) by mx.google.com with ESMTPS id jn7si23008546lbc.7.2014.09.24.06.55.05 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 24 Sep 2014 06:55:05 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.46 as permitted sender) client-ip=209.85.215.46; Received: by mail-la0-f46.google.com with SMTP id gi9so384294lab.5 for ; Wed, 24 Sep 2014 06:55:05 -0700 (PDT) X-Received: by 10.152.204.231 with SMTP id lb7mr6536427lac.44.1411566905449; Wed, 24 Sep 2014 06:55:05 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.130.169 with SMTP id of9csp586032lbb; Wed, 24 Sep 2014 06:55:04 -0700 (PDT) X-Received: by 10.66.236.38 with SMTP id ur6mr9494469pac.49.1411566903966; Wed, 24 Sep 2014 06:55:03 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y1si26538807pdo.45.2014.09.24.06.55.03 for ; Wed, 24 Sep 2014 06:55:03 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754236AbaIXNy5 (ORCPT + 27 others); Wed, 24 Sep 2014 09:54:57 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:50987 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753476AbaIXNrd (ORCPT ); Wed, 24 Sep 2014 09:47:33 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id s8ODlWL4031888; Wed, 24 Sep 2014 08:47:32 -0500 Received: from DLEE70.ent.ti.com (dlee70.ent.ti.com [157.170.170.113]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id s8ODlWe7009414; Wed, 24 Sep 2014 08:47:32 -0500 Received: from dlep32.itg.ti.com (157.170.170.100) by DLEE70.ent.ti.com (157.170.170.113) with Microsoft SMTP Server id 14.3.174.1; Wed, 24 Sep 2014 08:47:31 -0500 Received: from a0393678ub.india.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id s8ODlKDP015622; Wed, 24 Sep 2014 08:47:30 -0500 From: Kishon Vijay Abraham I To: CC: , Subject: [PATCH 06/22] phy: phy-spear1310-miphy: Remove unncessary site specific OOM messages Date: Wed, 24 Sep 2014 19:17:04 +0530 Message-ID: <1411566440-19169-7-git-send-email-kishon@ti.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1411566440-19169-1-git-send-email-kishon@ti.com> References: <1411566440-19169-1-git-send-email-kishon@ti.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: kishon@ti.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.46 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Peter Griffin The site specific OOM messages are unncessary, because they duplicate messages from the memory subsystem which include dump_stack(). Removing these superflous messages makes the kernel smaller. A discussion here http://patchwork.ozlabs.org/patch/324158/ found that all error paths from kzalloc will print a error message, and that any error path which maybe found which doesn't would be considered a bug in kzalloc. Signed-off-by: Peter Griffin Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/phy-spear1310-miphy.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/phy/phy-spear1310-miphy.c b/drivers/phy/phy-spear1310-miphy.c index 6dcbfcd..911d25b 100644 --- a/drivers/phy/phy-spear1310-miphy.c +++ b/drivers/phy/phy-spear1310-miphy.c @@ -212,10 +212,8 @@ static int spear1310_miphy_probe(struct platform_device *pdev) struct phy_provider *phy_provider; priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); - if (!priv) { - dev_err(dev, "can't alloc spear1310_miphy private date memory\n"); + if (!priv) return -ENOMEM; - } priv->misc = syscon_regmap_lookup_by_phandle(dev->of_node, "misc");