From patchwork Wed Sep 24 13:47:03 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kishon Vijay Abraham I X-Patchwork-Id: 37814 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f198.google.com (mail-lb0-f198.google.com [209.85.217.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id B640D204FF for ; Wed, 24 Sep 2014 13:48:35 +0000 (UTC) Received: by mail-lb0-f198.google.com with SMTP id 10sf5127684lbg.9 for ; Wed, 24 Sep 2014 06:48:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=HWHz1Kh7IOQ/41ZSBUPIeyiIVlgtJye3WZezZ+rRu8A=; b=SFaNbtMykPQDhkslVqiQKzHd0J+vdg+TOyymQUX04A1l7Jg+WwcnDQo3JK2hJDFiXK 4cz8OVSDGxDLkqNqUchfrfJjdUGae0n/+7+iY5u1v570kP3baMNSRXb+10UTSX+ZOQ1Z +Lewbq7whzprKH2hADidPXr58UxRyjPK78IfjaklkPcg2bGVyE5bLXvPN++RuKugiXj/ l7uYKYQ6eZqbXdRNSkXc7zvotBNU0jRbpM959aWOa4/09/LtRRB4UfB5QlpBqmosrE+u bFK7w1WBuGAulsn2dnst0ZEEN+d+K0jJHtOH1jafM0aSpbF9ToFUfnSGMfeifQlv+qqi Qd0A== X-Gm-Message-State: ALoCoQnOFafc0l03UkO+kmHJptFocEtGIAG5+wQZ8bvMyc5Rc5YoIq3UZmgs+/KQye7hAfV5pSN+ X-Received: by 10.112.132.37 with SMTP id or5mr1046971lbb.2.1411566514585; Wed, 24 Sep 2014 06:48:34 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.42.230 with SMTP id r6ls166497lal.92.gmail; Wed, 24 Sep 2014 06:48:34 -0700 (PDT) X-Received: by 10.152.4.194 with SMTP id m2mr6593288lam.63.1411566514319; Wed, 24 Sep 2014 06:48:34 -0700 (PDT) Received: from mail-lb0-f175.google.com (mail-lb0-f175.google.com [209.85.217.175]) by mx.google.com with ESMTPS id ar2si10121028lbc.73.2014.09.24.06.48.34 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 24 Sep 2014 06:48:34 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.175 as permitted sender) client-ip=209.85.217.175; Received: by mail-lb0-f175.google.com with SMTP id w7so5120484lbi.34 for ; Wed, 24 Sep 2014 06:48:34 -0700 (PDT) X-Received: by 10.112.75.233 with SMTP id f9mr3092489lbw.102.1411566513957; Wed, 24 Sep 2014 06:48:33 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.130.169 with SMTP id of9csp585135lbb; Wed, 24 Sep 2014 06:48:33 -0700 (PDT) X-Received: by 10.68.94.226 with SMTP id df2mr9438560pbb.122.1411566511991; Wed, 24 Sep 2014 06:48:31 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id id8si26374912pad.155.2014.09.24.06.48.31 for ; Wed, 24 Sep 2014 06:48:31 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753510AbaIXNrd (ORCPT + 27 others); Wed, 24 Sep 2014 09:47:33 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:50982 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753465AbaIXNrb (ORCPT ); Wed, 24 Sep 2014 09:47:31 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id s8ODlUx8031882; Wed, 24 Sep 2014 08:47:30 -0500 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id s8ODlUFP009406; Wed, 24 Sep 2014 08:47:30 -0500 Received: from dlep32.itg.ti.com (157.170.170.100) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.3.174.1; Wed, 24 Sep 2014 08:47:30 -0500 Received: from a0393678ub.india.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id s8ODlKDO015622; Wed, 24 Sep 2014 08:47:29 -0500 From: Kishon Vijay Abraham I To: CC: , Subject: [PATCH 05/22] phy: phy-ti-pipe3: Remove unncessary site specific OOM messages Date: Wed, 24 Sep 2014 19:17:03 +0530 Message-ID: <1411566440-19169-6-git-send-email-kishon@ti.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1411566440-19169-1-git-send-email-kishon@ti.com> References: <1411566440-19169-1-git-send-email-kishon@ti.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: kishon@ti.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.175 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Peter Griffin The site specific OOM messages are unncessary, because they duplicate messages from the memory subsystem which include dump_stack(). Removing these superflous messages makes the kernel smaller. A discussion here http://patchwork.ozlabs.org/patch/324158/ found that all error paths from kzalloc will print a error message, and that any error path which maybe found which doesn't would be considered a bug in kzalloc. Signed-off-by: Peter Griffin Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/phy-ti-pipe3.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/phy/phy-ti-pipe3.c b/drivers/phy/phy-ti-pipe3.c index b964aa9..9280ef8 100644 --- a/drivers/phy/phy-ti-pipe3.c +++ b/drivers/phy/phy-ti-pipe3.c @@ -299,10 +299,9 @@ static int ti_pipe3_probe(struct platform_device *pdev) struct clk *clk; phy = devm_kzalloc(&pdev->dev, sizeof(*phy), GFP_KERNEL); - if (!phy) { - dev_err(&pdev->dev, "unable to alloc mem for TI PIPE3 PHY\n"); + if (!phy) return -ENOMEM; - } + phy->dev = &pdev->dev; if (!of_device_is_compatible(node, "ti,phy-pipe3-pcie")) {