From patchwork Wed Sep 24 13:47:00 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kishon Vijay Abraham I X-Patchwork-Id: 37817 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f197.google.com (mail-wi0-f197.google.com [209.85.212.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id B32EE204FF for ; Wed, 24 Sep 2014 13:48:38 +0000 (UTC) Received: by mail-wi0-f197.google.com with SMTP id ho1sf3610539wib.0 for ; Wed, 24 Sep 2014 06:48:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=9LPYf24WcuU84YKMibrivpQTl51nm+8KRQZ3YDXz9Os=; b=PNw21D9oNcsnv9D2jl9JcsRQ4up8n69qdHMIM/0rLyiOtkHVkJwL4LT1H8NRGJ+IGm /t4spIKMm9fTngmnqZPG64l+/3NsBqkOhdUQ0RiCD1WMcJG8qSLiYhqlM+Dh0aJe9vs5 BCJyzL9XLzHEMC7OSoWO668hYoPvyo8rIC33X499YtaUGFGSby2OkF3b65KLYo38HBLI UDI7SLtDLTNbeQybq/iUr9GIifnXg7HkUV0GDeyZI/8f5NGdMOyvjlGbDgsismkwjFZC 8q5hKMfpX1D6dTWLxkbOAIoUxvWupUJX8ff/3cJeG0uKgYGjYJakh4W1oN8GQ6i2KH5k kLuw== X-Gm-Message-State: ALoCoQn9EkA0MWLZzVbbKHlU1dLhk5AD330fQGMGEc8CXvdcZGDJ1Tv1MiZ6Sb3TzKZ+CLdYy13l X-Received: by 10.112.118.8 with SMTP id ki8mr1053195lbb.4.1411566517898; Wed, 24 Sep 2014 06:48:37 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.43.1 with SMTP id s1ls161658lal.30.gmail; Wed, 24 Sep 2014 06:48:37 -0700 (PDT) X-Received: by 10.152.22.137 with SMTP id d9mr6575298laf.29.1411566517544; Wed, 24 Sep 2014 06:48:37 -0700 (PDT) Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com [209.85.217.181]) by mx.google.com with ESMTPS id o1si22861910lbp.117.2014.09.24.06.48.37 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 24 Sep 2014 06:48:37 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.181 as permitted sender) client-ip=209.85.217.181; Received: by mail-lb0-f181.google.com with SMTP id b6so5369304lbj.26 for ; Wed, 24 Sep 2014 06:48:37 -0700 (PDT) X-Received: by 10.152.5.168 with SMTP id t8mr6392506lat.67.1411566517346; Wed, 24 Sep 2014 06:48:37 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.130.169 with SMTP id of9csp585146lbb; Wed, 24 Sep 2014 06:48:36 -0700 (PDT) X-Received: by 10.68.95.129 with SMTP id dk1mr9339621pbb.25.1411566514464; Wed, 24 Sep 2014 06:48:34 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id id8si26374912pad.155.2014.09.24.06.48.33 for ; Wed, 24 Sep 2014 06:48:34 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753594AbaIXNrn (ORCPT + 27 others); Wed, 24 Sep 2014 09:47:43 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:38810 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753554AbaIXNrl (ORCPT ); Wed, 24 Sep 2014 09:47:41 -0400 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id s8ODlfjD016225; Wed, 24 Sep 2014 08:47:41 -0500 Received: from DLEE71.ent.ti.com (dlee71.ent.ti.com [157.170.170.114]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id s8ODlPfV004831; Wed, 24 Sep 2014 08:47:25 -0500 Received: from dlep32.itg.ti.com (157.170.170.100) by DLEE71.ent.ti.com (157.170.170.114) with Microsoft SMTP Server id 14.3.174.1; Wed, 24 Sep 2014 08:47:26 -0500 Received: from a0393678ub.india.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id s8ODlKDL015622; Wed, 24 Sep 2014 08:47:24 -0500 From: Kishon Vijay Abraham I To: CC: , Subject: [PATCH 02/22] phy: phy-omap-control: Remove unncessary site specific OOM messages Date: Wed, 24 Sep 2014 19:17:00 +0530 Message-ID: <1411566440-19169-3-git-send-email-kishon@ti.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1411566440-19169-1-git-send-email-kishon@ti.com> References: <1411566440-19169-1-git-send-email-kishon@ti.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: kishon@ti.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.181 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Peter Griffin The site specific OOM messages are unncessary, because they duplicate messages from the memory subsystem which include dump_stack(). Removing these superflous messages makes the kernel smaller. A discussion here http://patchwork.ozlabs.org/patch/324158/ found that all error paths from kzalloc will print a error message, and that any error path which maybe found which doesn't would be considered a bug in kzalloc. Signed-off-by: Peter Griffin Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/phy-omap-control.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/phy/phy-omap-control.c b/drivers/phy/phy-omap-control.c index 9487bf1..cb2f4d1 100644 --- a/drivers/phy/phy-omap-control.c +++ b/drivers/phy/phy-omap-control.c @@ -295,10 +295,8 @@ static int omap_control_phy_probe(struct platform_device *pdev) control_phy = devm_kzalloc(&pdev->dev, sizeof(*control_phy), GFP_KERNEL); - if (!control_phy) { - dev_err(&pdev->dev, "unable to alloc memory for control phy\n"); + if (!control_phy) return -ENOMEM; - } control_phy->dev = &pdev->dev; control_phy->type = *(enum omap_control_phy_type *)of_id->data;