From patchwork Tue Sep 2 13:00:42 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Thompson X-Patchwork-Id: 36473 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-oa0-f72.google.com (mail-oa0-f72.google.com [209.85.219.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 6B9BF203BE for ; Tue, 2 Sep 2014 13:03:33 +0000 (UTC) Received: by mail-oa0-f72.google.com with SMTP id m1sf38424754oag.3 for ; Tue, 02 Sep 2014 06:03:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=yllVP/fm8neHnTqFhg2ZC0QN3fUws7u5Q/vWOIYIwiU=; b=fVj4v4bo9kS1bortgSPkytv0IXZx7VzwxNKW9R7uBVxXV0i3z1NOZjytEtpLVRapaS lUpQ2vkuJTWA/g8rvrYTNsXE0iGKiyuHBae/+I7sXT6cHfLAO9WY2dMRlvX4YciRuMk/ LhaPerVm2tEmCsbHpkXh5DwwrXEiD8ufFDbAkUoG3jSGM4ZPlB3cPN2iHfbcX+0NZnhY cisgYdGCEp2haVuDOTIgvjBrSUtiydjF1Sz+886ovzYNKITpOTOFJ87wT+e2UPu6AzQ/ 2jn6f0bhocXBPkfCYvldzdY6jUCkd+TfD4E9BrnmpuxcRpdtYJKbpG+6JzMs7C6Q6d6X FuwA== X-Gm-Message-State: ALoCoQknTFw9c0HkMHqoRbDA1oD7ONsJLpk9ke/3YLRILOrrvaS33ucU/FNjAcWczKicpMJp7IHD X-Received: by 10.182.123.232 with SMTP id md8mr18262910obb.41.1409663013042; Tue, 02 Sep 2014 06:03:33 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.42.133 with SMTP id c5ls2404806qga.38.gmail; Tue, 02 Sep 2014 06:03:32 -0700 (PDT) X-Received: by 10.220.116.196 with SMTP id n4mr29566426vcq.6.1409663012943; Tue, 02 Sep 2014 06:03:32 -0700 (PDT) Received: from mail-vc0-f171.google.com (mail-vc0-f171.google.com [209.85.220.171]) by mx.google.com with ESMTPS id cv1si2223290vdc.22.2014.09.02.06.03.32 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 02 Sep 2014 06:03:32 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.171 as permitted sender) client-ip=209.85.220.171; Received: by mail-vc0-f171.google.com with SMTP id id10so6921164vcb.16 for ; Tue, 02 Sep 2014 06:03:32 -0700 (PDT) X-Received: by 10.52.165.116 with SMTP id yx20mr25364699vdb.13.1409663012882; Tue, 02 Sep 2014 06:03:32 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.221.45.67 with SMTP id uj3csp524102vcb; Tue, 2 Sep 2014 06:03:32 -0700 (PDT) X-Received: by 10.194.161.231 with SMTP id xv7mr16601044wjb.78.1409663011670; Tue, 02 Sep 2014 06:03:31 -0700 (PDT) Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by mx.google.com with ESMTPS id r1si14990071wix.97.2014.09.02.06.03.30 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 02 Sep 2014 06:03:30 -0700 (PDT) Received-SPF: pass (google.com: domain of daniel.thompson@linaro.org designates 209.85.212.170 as permitted sender) client-ip=209.85.212.170; Received: by mail-wi0-f170.google.com with SMTP id cc10so4120075wib.3 for ; Tue, 02 Sep 2014 06:03:30 -0700 (PDT) X-Received: by 10.180.218.4 with SMTP id pc4mr28498838wic.15.1409663010572; Tue, 02 Sep 2014 06:03:30 -0700 (PDT) Received: from sundance.lan (cpc4-aztw19-0-0-cust157.18-1.cable.virginm.net. [82.33.25.158]) by mx.google.com with ESMTPSA id ec2sm34928892wib.19.2014.09.02.06.03.28 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Sep 2014 06:03:29 -0700 (PDT) From: Daniel Thompson To: Russell King Cc: Daniel Thompson , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kgdb-bugreport@lists.sourceforge.net, patches@linaro.org, linaro-kernel@lists.linaro.org, John Stultz , Anton Vorontsov , Colin Cross , kernel-team@android.com, Rob Herring , Linus Walleij , Ben Dooks , Catalin Marinas , Dave Martin , Fabio Estevam , Frederic Weisbecker , Nicolas Pitre , Thomas Gleixner , Jason Cooper , Peter De Schrijver Subject: [PATCH v11 08/19] irqchip: gic: Remove spin locks from eoi_irq Date: Tue, 2 Sep 2014 14:00:42 +0100 Message-Id: <1409662853-29313-9-git-send-email-daniel.thompson@linaro.org> X-Mailer: git-send-email 1.9.3 In-Reply-To: <1409662853-29313-1-git-send-email-daniel.thompson@linaro.org> References: <1408466769-20004-1-git-send-email-daniel.thompson@linaro.org> <1409662853-29313-1-git-send-email-daniel.thompson@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: daniel.thompson@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.171 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , This patch is motivated by the comment it removes from gic_init_fiq, namely that the spin locks in eoi_irq preclude certain platforms from supporting FIQ. Currently there is only one upstream platform (tegra) that actually hooks gic_arch_extn.irq_eoi and it does not require these spin locks. Signed-off-by: Daniel Thompson Cc: Thomas Gleixner Cc: Jason Cooper Cc: Peter De Schrijver --- drivers/irqchip/irq-gic.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c index 6fa0542..d928912 100644 --- a/drivers/irqchip/irq-gic.c +++ b/drivers/irqchip/irq-gic.c @@ -191,11 +191,8 @@ static void gic_unmask_irq(struct irq_data *d) static void gic_eoi_irq(struct irq_data *d) { - if (gic_arch_extn.irq_eoi) { - raw_spin_lock(&irq_controller_lock); + if (gic_arch_extn.irq_eoi) gic_arch_extn.irq_eoi(d); - raw_spin_unlock(&irq_controller_lock); - } writel_relaxed(gic_irq(d), gic_cpu_base(d) + GIC_CPU_EOI); } @@ -413,13 +410,6 @@ static void __init gic_init_fiq(struct gic_chip_data *gic, unsigned int i; /* - * FIQ can only be supported on platforms without an extended irq_eoi - * method (otherwise we take a lock during eoi handling). - */ - if (gic_arch_extn.irq_eoi) - return; - - /* * If grouping is not available (not implemented or prohibited by * security mode) these registers a read-as-zero/write-ignored. * However as a precaution we restore the reset default regardless of