From patchwork Mon Aug 18 15:09:01 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Thompson X-Patchwork-Id: 35517 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qc0-f200.google.com (mail-qc0-f200.google.com [209.85.216.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 4DFFE20676 for ; Mon, 18 Aug 2014 15:09:19 +0000 (UTC) Received: by mail-qc0-f200.google.com with SMTP id w7sf16816808qcr.11 for ; Mon, 18 Aug 2014 08:09:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=y+JJ3gK+mhgJ/GM0ZgoH0mBsdoGtdwUmhfE+Lj+HsHA=; b=CrUl+0Xhi9OaZfvw5RU0/NR56fp9tKRN1QA0TIc1aKJZCdPWwISmpPnDIMt57Y7eqN jT4hjPMr6JKHNZ59XRZupCjTMwp3Git1q7Jl+HTHxlOMmRHayiDhMJc+BWUi4V+e8wse m84JUmSy61BhSgX4fLBkl7NMLhnJaldbfSqTjWbkZHlXJtzkiATngb+N6QM400suNl3V wsGrJwM2lSdRygc28JGdO+QbUWitTHpwRoml5XWsa92w8uXawtwUwuZxIkU5odlMRP5p I/jzhVq2ZY5d5i0knqZuwTJiTmda2WtrODM8yLsj2ekwy+MuGV11XS270hO7CEZUgrZ+ O6NA== X-Gm-Message-State: ALoCoQnQOo2JD5WrdBPPlfA85wKzk0o6OLzU8p3Di9njy5ssLndFwjbnR4Q3F8DIK5Q2N+3UzmgU X-Received: by 10.236.16.165 with SMTP id h25mr6604655yhh.30.1408374559147; Mon, 18 Aug 2014 08:09:19 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.101.210 with SMTP id u76ls2312692qge.62.gmail; Mon, 18 Aug 2014 08:09:18 -0700 (PDT) X-Received: by 10.52.120.51 with SMTP id kz19mr31215vdb.95.1408374558863; Mon, 18 Aug 2014 08:09:18 -0700 (PDT) Received: from mail-vc0-f178.google.com (mail-vc0-f178.google.com [209.85.220.178]) by mx.google.com with ESMTPS id ef9si5576270vec.42.2014.08.18.08.09.18 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 18 Aug 2014 08:09:18 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.178 as permitted sender) client-ip=209.85.220.178; Received: by mail-vc0-f178.google.com with SMTP id la4so5990353vcb.9 for ; Mon, 18 Aug 2014 08:09:18 -0700 (PDT) X-Received: by 10.52.129.200 with SMTP id ny8mr11888749vdb.27.1408374558750; Mon, 18 Aug 2014 08:09:18 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp160240vcb; Mon, 18 Aug 2014 08:09:18 -0700 (PDT) X-Received: by 10.180.86.1 with SMTP id l1mr41391959wiz.62.1408374557533; Mon, 18 Aug 2014 08:09:17 -0700 (PDT) Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41]) by mx.google.com with ESMTPS id ef9si25838336wjd.82.2014.08.18.08.09.17 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 18 Aug 2014 08:09:17 -0700 (PDT) Received-SPF: pass (google.com: domain of daniel.thompson@linaro.org designates 74.125.82.41 as permitted sender) client-ip=74.125.82.41; Received: by mail-wg0-f41.google.com with SMTP id z12so5106710wgg.12 for ; Mon, 18 Aug 2014 08:09:17 -0700 (PDT) X-Received: by 10.180.184.99 with SMTP id et3mr71578907wic.31.1408374556954; Mon, 18 Aug 2014 08:09:16 -0700 (PDT) Received: from sundance.lan (cpc4-aztw19-0-0-cust157.18-1.cable.virginm.net. [82.33.25.158]) by mx.google.com with ESMTPSA id p3sm42933099wjb.21.2014.08.18.08.09.14 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Aug 2014 08:09:15 -0700 (PDT) From: Daniel Thompson To: Jason Wessel Cc: Daniel Thompson , linux-kernel@vger.kernel.org, patches@linaro.org, linaro-kernel@lists.linaro.org, Mike Travis , Ingo Molnar , kgdb-bugreport@lists.sourceforge.net Subject: [RESEND PATCH 3.17rc1] kdb: Remove stack dump when entering kgdb due to NMI Date: Mon, 18 Aug 2014 16:09:01 +0100 Message-Id: <1408374541-13066-1-git-send-email-daniel.thompson@linaro.org> X-Mailer: git-send-email 1.9.3 In-Reply-To: <1405518033-11671-1-git-send-email-daniel.thompson@linaro.org> References: <1405518033-11671-1-git-send-email-daniel.thompson@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: daniel.thompson@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.178 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Issuing a stack dump feels ergonomically wrong when entering due to NMI. Entering due to NMI is a normally reaction to a user request, either the NMI button on a server or a "magic knock" on a UART. Therefore the backtrace behaviour on entry due to NMI should be like SysRq-g (no stack dump) rather than like oops. Note also that the stack dump does not offer any information that cannot be trivial retrieved using the 'bt' command. Signed-off-by: Daniel Thompson Cc: Jason Wessel Cc: Mike Travis Cc: Ingo Molnar Cc: kgdb-bugreport@lists.sourceforge.net --- kernel/debug/kdb/kdb_main.c | 1 - 1 file changed, 1 deletion(-) -- 1.9.3 diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c index 379650b..f9ba423 100644 --- a/kernel/debug/kdb/kdb_main.c +++ b/kernel/debug/kdb/kdb_main.c @@ -1207,7 +1207,6 @@ static int kdb_local(kdb_reason_t reason, int error, struct pt_regs *regs, kdb_printf("due to NonMaskable Interrupt @ " kdb_machreg_fmt "\n", instruction_pointer(regs)); - kdb_dumpregs(regs); break; case KDB_REASON_SSTEP: case KDB_REASON_BREAK: