From patchwork Mon Jul 28 11:33:40 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 34350 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ig0-f199.google.com (mail-ig0-f199.google.com [209.85.213.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 17874213FD for ; Mon, 28 Jul 2014 11:33:53 +0000 (UTC) Received: by mail-ig0-f199.google.com with SMTP id l13sf14640034iga.10 for ; Mon, 28 Jul 2014 04:33:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:date :message-id:subject:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=RJ0mZCRL6A+OHaxI7Gzm7akjXelzEv+Qx9t/I7E36DI=; b=enuPij4fcvvUkQSIPCrEODY4KJ+HMcCaSmMv/n47O3JvAnjZHOAbwtA+JDXFudCNS2 7TSfE174kqAxepG4LJ2y3F92yclOspuET42bxkmdHnFhomQspA+z8xnI/tKSkoPAierS B/BWq+eDjWWZCKn1BOMEKqFpLT+3tniAMsQ13s6Nckj3YHsmv6P44veBUX0C2o2MDB1J +q+HZwr0Krt3KfwtWtt2Y7hyEwBLdSBAO3ictwUdByc74Jevz6wDu0euIR0G1HZR0K8I 8PlgV+PQ07zjk47k/0/s9kkLG+RqqUxSJXPW+PYdXVtsQxy+h3EFZg2wIYcYT7oDcFwt f4XQ== X-Gm-Message-State: ALoCoQkGgIANiA22rJ9Yie4gkAXA4DuUlgN0Q4a9LlqfENe+kEcVWbKEUkBv34HcX/qZY8tSPBGF X-Received: by 10.182.118.228 with SMTP id kp4mr16997077obb.42.1406547232497; Mon, 28 Jul 2014 04:33:52 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.39.39 with SMTP id u36ls1283871qgu.63.gmail; Mon, 28 Jul 2014 04:33:52 -0700 (PDT) X-Received: by 10.52.120.83 with SMTP id la19mr1471346vdb.68.1406547232390; Mon, 28 Jul 2014 04:33:52 -0700 (PDT) Received: from mail-vc0-f172.google.com (mail-vc0-f172.google.com [209.85.220.172]) by mx.google.com with ESMTPS id a12si3228926veu.64.2014.07.28.04.33.52 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 28 Jul 2014 04:33:52 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.172 as permitted sender) client-ip=209.85.220.172; Received: by mail-vc0-f172.google.com with SMTP id im17so10934170vcb.17 for ; Mon, 28 Jul 2014 04:33:52 -0700 (PDT) X-Received: by 10.52.239.6 with SMTP id vo6mr4249431vdc.59.1406547232286; Mon, 28 Jul 2014 04:33:52 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp159032vcb; Mon, 28 Jul 2014 04:33:51 -0700 (PDT) X-Received: by 10.66.66.229 with SMTP id i5mr38092689pat.47.1406547231756; Mon, 28 Jul 2014 04:33:51 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id pu3si8805730pdb.40.2014.07.28.04.33.50 for ; Mon, 28 Jul 2014 04:33:51 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752672AbaG1Ldt (ORCPT + 23 others); Mon, 28 Jul 2014 07:33:49 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:59186 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751985AbaG1Ldr (ORCPT ); Mon, 28 Jul 2014 07:33:47 -0400 Received: from cpc11-sgyl31-2-0-cust672.sgyl.cable.virginm.net ([94.175.94.161] helo=debutante) by mezzanine.sirena.org.uk with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XBjBX-0006tX-Te; Mon, 28 Jul 2014 11:33:44 +0000 Received: from broonie by debutante with local (Exim 4.83) (envelope-from ) id 1XBjBV-0000iz-3S; Mon, 28 Jul 2014 12:33:41 +0100 From: Mark Brown To: Liam Girdwood Cc: linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org, Mark Brown Date: Mon, 28 Jul 2014 12:33:40 +0100 Message-Id: <1406547220-2750-1-git-send-email-broonie@kernel.org> X-Mailer: git-send-email 2.0.1 X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on mezzanine.sirena.org.uk X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.3.2 Subject: [PATCH] regulator: lp872x: Don't set constraints within the regulator driver X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: broonie@kernel.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.172 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Mark Brown Regulator drivers should not be specifying constraints since the valid configurations depend on how the device is used in a given system, there is no way to know if a configuration is safe for a given board. Signed-off-by: Mark Brown --- drivers/regulator/lp872x.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/regulator/lp872x.c b/drivers/regulator/lp872x.c index 2e022aabd951..954616f16c81 100644 --- a/drivers/regulator/lp872x.c +++ b/drivers/regulator/lp872x.c @@ -892,14 +892,6 @@ static struct lp872x_platform_data pdata->regulator_data[i].id = (enum lp872x_regulator_id)match[i].driver_data; pdata->regulator_data[i].init_data = match[i].init_data; - - /* Operation mode configuration for buck/buck1/buck2 */ - if (strncmp(match[i].name, "buck", 4)) - continue; - - d = pdata->regulator_data[i].init_data; - d->constraints.valid_modes_mask |= LP872X_VALID_OPMODE; - d->constraints.valid_ops_mask |= REGULATOR_CHANGE_MODE; } out: return pdata;