From patchwork Thu Jul 24 10:13:31 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Jones X-Patchwork-Id: 34191 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qg0-f71.google.com (mail-qg0-f71.google.com [209.85.192.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 2827020C7F for ; Thu, 24 Jul 2014 10:14:30 +0000 (UTC) Received: by mail-qg0-f71.google.com with SMTP id f51sf5383559qge.2 for ; Thu, 24 Jul 2014 03:14:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=xmht92d9uHaENqSzr7oDOcBAKfDgGEuUT1ssoR7kDqk=; b=Qm656Hdmy78RYqJZ+AI6ppVUMKixj/adL4JHejfoEqUNMqzdL+B6DFSk+nlRfqgSEk cPhPbZ9UtrhFroSMz4BCsQH/aOT6GUZzfCTlOYhBfOBlz+8cLXzmh87zF61nLcwjO5wu bPVMpn0shdd2C71X3aBNozurRTC6/d4JzVP9PEgy6446eIILg8M23e/Lg7485vFtLEE0 UUNnZDrT3GIOZ3TPjHIqKHKVyZtm+F6lP4q6zajjbh3UF1aBTMwS61wG9eJEuKGlNKDJ jJcruxDZQS/YsErUEwh1MbK58Izza62wgFQ/zD7blK6+Fp2BRjQ7EtYP8ztHOZoewzYI p6+A== X-Gm-Message-State: ALoCoQlpF7ayiUM2O5xM/QHtpHGNI49jikXebSVgzbjfPUxQcoWhBuoW6nUhOxlG8l+dCTsfJCRJ X-Received: by 10.52.184.104 with SMTP id et8mr3309533vdc.4.1406196869925; Thu, 24 Jul 2014 03:14:29 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.17.53 with SMTP id 50ls46014qgc.21.gmail; Thu, 24 Jul 2014 03:14:29 -0700 (PDT) X-Received: by 10.220.131.207 with SMTP id y15mr10279734vcs.71.1406196869783; Thu, 24 Jul 2014 03:14:29 -0700 (PDT) Received: from mail-vc0-f169.google.com (mail-vc0-f169.google.com [209.85.220.169]) by mx.google.com with ESMTPS id oh5si4636790vcb.6.2014.07.24.03.14.29 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 24 Jul 2014 03:14:29 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.169 as permitted sender) client-ip=209.85.220.169; Received: by mail-vc0-f169.google.com with SMTP id hu12so4482213vcb.0 for ; Thu, 24 Jul 2014 03:14:29 -0700 (PDT) X-Received: by 10.52.244.81 with SMTP id xe17mr8978674vdc.24.1406196869679; Thu, 24 Jul 2014 03:14:29 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp352068vcb; Thu, 24 Jul 2014 03:14:29 -0700 (PDT) X-Received: by 10.66.219.42 with SMTP id pl10mr9182131pac.22.1406196868805; Thu, 24 Jul 2014 03:14:28 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bm3si5446293pad.232.2014.07.24.03.14.28 for ; Thu, 24 Jul 2014 03:14:28 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935037AbaGXKOB (ORCPT + 14 others); Thu, 24 Jul 2014 06:14:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13926 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934964AbaGXKNu (ORCPT ); Thu, 24 Jul 2014 06:13:50 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6OADnLX016993 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 Jul 2014 06:13:49 -0400 Received: from hawk.usersys.redhat.com (dhcp-1-116.brq.redhat.com [10.34.1.116]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6OADfse014369; Thu, 24 Jul 2014 06:13:47 -0400 From: Andrew Jones To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: uobergfe@redhat.com, dzickus@redhat.com, pbonzini@redhat.com, akpm@linux-foundation.org, mingo@redhat.com Subject: [PATCH 3/3] kvm: ensure hard lockup detection is disabled by default Date: Thu, 24 Jul 2014 12:13:31 +0200 Message-Id: <1406196811-5384-4-git-send-email-drjones@redhat.com> In-Reply-To: <1406196811-5384-1-git-send-email-drjones@redhat.com> References: <1406196811-5384-1-git-send-email-drjones@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: drjones@redhat.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.169 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Ulrich Obergfell Use watchdog_enable_hardlockup_detector() to set hard lockup detection's default value to false. It's risky to run this detection in a guest, as false positives are easy to trigger, especially if the host is overcommitted. Signed-off-by: Ulrich Obergfell Signed-off-by: Andrew Jones --- arch/x86/kernel/kvm.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c index 3dd8e2c4d74a9..95c3cb16af3e5 100644 --- a/arch/x86/kernel/kvm.c +++ b/arch/x86/kernel/kvm.c @@ -35,6 +35,7 @@ #include #include #include +#include #include #include #include @@ -499,6 +500,13 @@ void __init kvm_guest_init(void) #else kvm_guest_cpu_init(); #endif + + /* + * Hard lockup detection is enabled by default. Disable it, as guests + * can get false positives too easily, for example if the host is + * overcommitted. + */ + watchdog_enable_hardlockup_detector(false); } static noinline uint32_t __kvm_cpuid_base(void)