From patchwork Wed Jul 16 13:40:33 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Thompson X-Patchwork-Id: 33731 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pa0-f71.google.com (mail-pa0-f71.google.com [209.85.220.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id B6A6620CA0 for ; Wed, 16 Jul 2014 13:41:36 +0000 (UTC) Received: by mail-pa0-f71.google.com with SMTP id et14sf6705955pad.10 for ; Wed, 16 Jul 2014 06:41:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=FZNYvzHAlPERz+VhupnvC+5arfymZU/ukHHFuPWdtfI=; b=WZTSE99AbKU+TphPZcpS6Ao29fj97DLlmQQiyoXVvMaZreLhmGtcKObvn9wdDUGrqE Uvw5JTRVD+lPsyr41TTlMJaxnxpor5Eh/nH0Hj/wC47UjSg1GcduXvpyUbTrzA3KCz+2 Yln5lCQxbC6b3KpfhilHFf7JKcCncei2pq5NAY87uJzRt2axh56UaADLFGTbazqxZrFk o1Bgv50G6joU/oQOFSDyX1AeC1wEDchXM8ygQWRMnrqc5zlpJg4X5lG6308a2C5kuZag 8lJy6kHlzpEqlOKGPI0x1ycRfBaHMzV9SfcLiVBECryFbsOlGvgABTY18Yu+uATRPVUJ t/yQ== X-Gm-Message-State: ALoCoQn7nMI+Q5a/YZF/RdYIzCBUctdEl1/ZDbzLuEF3GSgu9wwsOiQWvBPyr+9g5PFi61Zz/552 X-Received: by 10.70.53.202 with SMTP id d10mr14616334pdp.2.1405518096072; Wed, 16 Jul 2014 06:41:36 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.107.198 with SMTP id h64ls414630qgf.66.gmail; Wed, 16 Jul 2014 06:41:36 -0700 (PDT) X-Received: by 10.52.92.12 with SMTP id ci12mr1766202vdb.90.1405518095525; Wed, 16 Jul 2014 06:41:35 -0700 (PDT) Received: from mail-vc0-f181.google.com (mail-vc0-f181.google.com [209.85.220.181]) by mx.google.com with ESMTPS id po10si3624062vec.81.2014.07.16.06.41.35 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 16 Jul 2014 06:41:35 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.181 as permitted sender) client-ip=209.85.220.181; Received: by mail-vc0-f181.google.com with SMTP id lf12so1627849vcb.40 for ; Wed, 16 Jul 2014 06:41:35 -0700 (PDT) X-Received: by 10.221.47.9 with SMTP id uq9mr7965371vcb.48.1405518095314; Wed, 16 Jul 2014 06:41:35 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp299848vcb; Wed, 16 Jul 2014 06:41:34 -0700 (PDT) X-Received: by 10.180.149.161 with SMTP id ub1mr12259029wib.32.1405518094240; Wed, 16 Jul 2014 06:41:34 -0700 (PDT) Received: from mail-we0-f181.google.com (mail-we0-f181.google.com [74.125.82.181]) by mx.google.com with ESMTPS id lk16si20584869wic.65.2014.07.16.06.41.33 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 16 Jul 2014 06:41:34 -0700 (PDT) Received-SPF: pass (google.com: domain of daniel.thompson@linaro.org designates 74.125.82.181 as permitted sender) client-ip=74.125.82.181; Received: by mail-we0-f181.google.com with SMTP id q59so927522wes.26 for ; Wed, 16 Jul 2014 06:41:33 -0700 (PDT) X-Received: by 10.180.74.42 with SMTP id q10mr13649121wiv.39.1405518093092; Wed, 16 Jul 2014 06:41:33 -0700 (PDT) Received: from sundance.lan (cpc4-aztw19-0-0-cust157.18-1.cable.virginm.net. [82.33.25.158]) by mx.google.com with ESMTPSA id eo4sm56691017wid.4.2014.07.16.06.41.29 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Jul 2014 06:41:32 -0700 (PDT) From: Daniel Thompson To: Jason Wessel Cc: Daniel Thompson , linux-kernel@vger.kernel.org, patches@linaro.org, linaro-kernel@lists.linaro.org, Mike Travis , Ingo Molnar , kgdb-bugreport@lists.sourceforge.net Subject: [PATCH] kdb: Remove stack dump when entering kgdb due to NMI Date: Wed, 16 Jul 2014 14:40:33 +0100 Message-Id: <1405518033-11671-1-git-send-email-daniel.thompson@linaro.org> X-Mailer: git-send-email 1.9.3 X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: daniel.thompson@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.181 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Issuing a stack dump feels ergonomically wrong when entering due to NMI. Entering due to NMI is a normally reaction to a user request, either the NMI button on a server or a "magic knock" on a UART. Therefore the backtrace behaviour on entry due to NMI should be like SysRq-g (no stack dump) rather than like oops. Note also that the stack dump does not offer any information that cannot be trivial retrieved using the 'bt' command. Signed-off-by: Daniel Thompson Cc: Jason Wessel Cc: Mike Travis Cc: Ingo Molnar Cc: kgdb-bugreport@lists.sourceforge.net --- kernel/debug/kdb/kdb_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c index 49f2425..6d19905 100644 --- a/kernel/debug/kdb/kdb_main.c +++ b/kernel/debug/kdb/kdb_main.c @@ -1207,7 +1207,6 @@ static int kdb_local(kdb_reason_t reason, int error, struct pt_regs *regs, kdb_printf("due to NonMaskable Interrupt @ " kdb_machreg_fmt "\n", instruction_pointer(regs)); - kdb_dumpregs(regs); break; case KDB_REASON_SSTEP: case KDB_REASON_BREAK: