From patchwork Thu Jun 19 18:48:59 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 32247 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ie0-f198.google.com (mail-ie0-f198.google.com [209.85.223.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 823D1206A0 for ; Thu, 19 Jun 2014 18:50:06 +0000 (UTC) Received: by mail-ie0-f198.google.com with SMTP id y20sf19330552ier.9 for ; Thu, 19 Jun 2014 11:50:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=9EhpNnRjZz18fIShejnxDuhc/RHKN/ogup7hKw7gkE8=; b=Mye/ezBv8KTQbZ0OPhnVYQi4Xvyvi2cDM3XA5K1J5C65kJXUKtenT79DFeyYWuTS63 BWs+XNU1yPyNKOkzx5T3Vfo1h6GjoQFk7+AE1zDap7OlJ0esph87v9rYpYsD+SJVRURE XUc6lWpePhwn3qHbS7OFxi1BD+SNajAo8t0slIkzjveEGsQ8TfePwb4U0fDQFXWj7tnF B5qZaskE5303YqBCjuWUdLV+JPa1iasNB0PvrGfnujrJltn93T04oFQn6wzch8PqwLio gszaAvk5TCwct0cEBGPNtUY14sOfYik/0/c/71Bx7xFo7gq4WfqhfCNE4hineOmZZtfx 6gAA== X-Gm-Message-State: ALoCoQkZKHCot9MY1vfPVUAdmE9tjmLvVKm+GXheBNPUA2OLeePxrXelNlIZRs8RNqovXMWnn+49 X-Received: by 10.42.164.70 with SMTP id f6mr2886286icy.4.1403203805957; Thu, 19 Jun 2014 11:50:05 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.106.203 with SMTP id e69ls743873qgf.29.gmail; Thu, 19 Jun 2014 11:50:05 -0700 (PDT) X-Received: by 10.52.53.36 with SMTP id y4mr1537389vdo.56.1403203805785; Thu, 19 Jun 2014 11:50:05 -0700 (PDT) Received: from mail-vc0-f169.google.com (mail-vc0-f169.google.com [209.85.220.169]) by mx.google.com with ESMTPS id od9si2819477vcb.32.2014.06.19.11.50.05 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 19 Jun 2014 11:50:05 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.169 as permitted sender) client-ip=209.85.220.169; Received: by mail-vc0-f169.google.com with SMTP id la4so2620863vcb.14 for ; Thu, 19 Jun 2014 11:50:05 -0700 (PDT) X-Received: by 10.58.216.163 with SMTP id or3mr38857vec.80.1403203805707; Thu, 19 Jun 2014 11:50:05 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.54.6 with SMTP id vs6csp383182vcb; Thu, 19 Jun 2014 11:50:05 -0700 (PDT) X-Received: by 10.66.163.98 with SMTP id yh2mr8085884pab.104.1403203804949; Thu, 19 Jun 2014 11:50:04 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ek4si6768159pbc.5.2014.06.19.11.50.04; Thu, 19 Jun 2014 11:50:04 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934341AbaFSSuB (ORCPT + 5 others); Thu, 19 Jun 2014 14:50:01 -0400 Received: from sauhun.de ([89.238.76.85]:37034 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933059AbaFSSt2 (ORCPT ); Thu, 19 Jun 2014 14:49:28 -0400 Received: from p4fe25d7c.dip0.t-ipconnect.de ([79.226.93.124]:40282 helo=localhost) by pokefinder.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1WxhOn-0003cC-PN; Thu, 19 Jun 2014 20:49:25 +0200 From: Wolfram Sang To: linux-kernel@vger.kernel.org Cc: Tushar Behera , Wolfram Sang , Russell King , David Airlie , dri-devel@lists.freedesktop.org Subject: [PATCH 1/3] DRM: Armada: Use devm_ioremap_resource Date: Thu, 19 Jun 2014 20:48:59 +0200 Message-Id: <1403203741-5113-2-git-send-email-wsa@the-dreams.de> X-Mailer: git-send-email 2.0.0 In-Reply-To: <1403203741-5113-1-git-send-email-wsa@the-dreams.de> References: <1403203741-5113-1-git-send-email-wsa@the-dreams.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: wsa@the-dreams.de X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.169 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Tushar Behera While at it, propagate the error code. Signed-off-by: Tushar Behera Signed-off-by: Wolfram Sang --- drivers/gpu/drm/armada/armada_crtc.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/armada/armada_crtc.c b/drivers/gpu/drm/armada/armada_crtc.c index 81c34f949dfc..3aedf9e993e6 100644 --- a/drivers/gpu/drm/armada/armada_crtc.c +++ b/drivers/gpu/drm/armada/armada_crtc.c @@ -1039,11 +1039,9 @@ int armada_drm_crtc_create(struct drm_device *dev, unsigned num, if (ret) return ret; - base = devm_request_and_ioremap(dev->dev, res); - if (!base) { - DRM_ERROR("failed to ioremap register\n"); - return -ENOMEM; - } + base = devm_ioremap_resource(dev->dev, res); + if (IS_ERR(base)) + return PTR_ERR(base); dcrtc = kzalloc(sizeof(*dcrtc), GFP_KERNEL); if (!dcrtc) {