From patchwork Mon Jun 2 10:31:06 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Catalin Marinas X-Patchwork-Id: 31278 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-oa0-f70.google.com (mail-oa0-f70.google.com [209.85.219.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 20D1920AE6 for ; Mon, 2 Jun 2014 10:31:28 +0000 (UTC) Received: by mail-oa0-f70.google.com with SMTP id g18sf26263513oah.1 for ; Mon, 02 Jun 2014 03:31:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :mime-version:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe:content-type :content-transfer-encoding; bh=DZccmT8iOUJ1G5oZ676RTz8iwErLa7h9dzDBWt0x+GA=; b=L6RvE8iaOi64fjMhk2dV7BU/jlaLC/Ux/Bobzi1GUuK6FbCkz/khESLUX0pP7pfSaA Pw6YJgUguduIbqvyyRwkvvE5giAuASezooswOEOlKnwkyoCwo5svvtM+s6lefGOfiMcW CggpZvdaOKgB26aXxfyMTHsSDoXUJY/EtggqWo15Q6LTwUen2KxVEQZ9sfmJjcRBeH4A 0UtK15kX9JRa9U++RffGbWjHjtgONWs5jVblyNYOJ7lZwnrQcw1QI95RoG4inX/O24ho 9Ay7GVAa2GPgJF5T1buR0Sc5MVLVtcqhuKacU2Q/PtJ/hNH3xtAW/9S2Q8DtT9NDVHba ZS4Q== X-Gm-Message-State: ALoCoQnuKn7RIzwsZ6l7ONnU57uVZZDJ2OIJxlYsdVB1c+SZYc4JPJVwlqRCw0TtlBsJ6Ztwk/FJ X-Received: by 10.182.97.165 with SMTP id eb5mr14067911obb.43.1401705088081; Mon, 02 Jun 2014 03:31:28 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.84.72 with SMTP id k66ls1955876qgd.96.gmail; Mon, 02 Jun 2014 03:31:27 -0700 (PDT) X-Received: by 10.52.96.8 with SMTP id do8mr24692402vdb.4.1401705087922; Mon, 02 Jun 2014 03:31:27 -0700 (PDT) Received: from mail-ve0-f181.google.com (mail-ve0-f181.google.com [209.85.128.181]) by mx.google.com with ESMTPS id yh1si7643850vec.100.2014.06.02.03.31.27 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 02 Jun 2014 03:31:27 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.181 as permitted sender) client-ip=209.85.128.181; Received: by mail-ve0-f181.google.com with SMTP id pa12so4939874veb.12 for ; Mon, 02 Jun 2014 03:31:27 -0700 (PDT) X-Received: by 10.58.135.136 with SMTP id ps8mr29382348veb.18.1401705087759; Mon, 02 Jun 2014 03:31:27 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp87038vcb; Mon, 2 Jun 2014 03:31:27 -0700 (PDT) X-Received: by 10.68.201.10 with SMTP id jw10mr38953194pbc.25.1401705086991; Mon, 02 Jun 2014 03:31:26 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id fo3si15260513pbb.76.2014.06.02.03.31.26; Mon, 02 Jun 2014 03:31:26 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754000AbaFBKbR (ORCPT + 28 others); Mon, 2 Jun 2014 06:31:17 -0400 Received: from fw-tnat.cambridge.arm.com ([217.140.96.21]:54990 "EHLO cam-smtp0.cambridge.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752805AbaFBKbQ (ORCPT ); Mon, 2 Jun 2014 06:31:16 -0400 Received: from e102109-lin.cambridge.arm.com (e102109-lin.cambridge.arm.com [10.1.203.182]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id s52AVBW0002929; Mon, 2 Jun 2014 11:31:12 +0100 From: Catalin Marinas To: Matt Fleming Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] efi: Fix compiler warnings (unused, const, type) Date: Mon, 2 Jun 2014 11:31:06 +0100 Message-Id: <1401705066-2808-1-git-send-email-catalin.marinas@arm.com> X-Mailer: git-send-email 1.9.3 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: catalin.marinas@arm.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.181 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , This patch fixes a few compiler warning in the efi code for unused variable, discarding const qualifier and wrong pointer type: drivers/firmware/efi/fdt.c|66 col 22| warning: unused variable ‘name’ [-Wunused-variable] drivers/firmware/efi/efi.c|368 col 3| warning: passing argument 3 of ‘of_get_flat_dt_prop’ from incompatible pointer type [enabled by default] drivers/firmware/efi/efi.c|368 col 8| warning: assignment discards ‘const’ qualifier from pointer target type [enabled by default] Signed-off-by: Catalin Marinas --- Matt, Unless you have fixed these already, please consider applying (warnings in latest next/master branch). Thanks, Catalin drivers/firmware/efi/efi.c | 6 +++--- drivers/firmware/efi/fdt.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c index cd36deb619fa..eff1a2f22f09 100644 --- a/drivers/firmware/efi/efi.c +++ b/drivers/firmware/efi/efi.c @@ -353,10 +353,10 @@ static int __init fdt_find_uefi_params(unsigned long node, const char *uname, int depth, void *data) { struct param_info *info = data; - void *prop, *dest; - unsigned long len; + const void *prop; + void *dest; u64 val; - int i; + int i, len; if (depth != 1 || (strcmp(uname, "chosen") != 0 && strcmp(uname, "chosen@0") != 0)) diff --git a/drivers/firmware/efi/fdt.c b/drivers/firmware/efi/fdt.c index 5c6a8e8a9580..82d774161cc9 100644 --- a/drivers/firmware/efi/fdt.c +++ b/drivers/firmware/efi/fdt.c @@ -63,7 +63,7 @@ static efi_status_t update_fdt(efi_system_table_t *sys_table, void *orig_fdt, */ prev = 0; for (;;) { - const char *type, *name; + const char *type; int len; node = fdt_next_node(fdt, prev, NULL);