From patchwork Fri May 23 18:16:42 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Morten Rasmussen X-Patchwork-Id: 30843 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ob0-f197.google.com (mail-ob0-f197.google.com [209.85.214.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 7A7BB20369 for ; Fri, 23 May 2014 18:17:28 +0000 (UTC) Received: by mail-ob0-f197.google.com with SMTP id vb8sf23802367obc.4 for ; Fri, 23 May 2014 11:17:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type :content-transfer-encoding; bh=6PzX4U/S11Q4rLYbyvynEZLBectRPRP6GHZDNV3D2G0=; b=aJsmFBuHHFFULk571v9NiAjSrUIiyFJl/yX3WFVu5WMFTeSa0I8Vz0QYF/KVFE1FfJ xH5ZPABUijG+yIWJ0q1Mqw3ecmScXUnPbMwM+hxQ8VczyQSfXz4/TOo9pYVOPu/df93Y 5kHlU5WGSr1dqroYKyeFc3HWn5YhKPND89gatDx2IOJ9fcbK6I20J8DK/pAeCPLDjtzx nBKjLoWm+btvMmtgpSFkiHE/pBcd6q6ZIRbRo27gnHkOpcC/znNAxvQJ2siDHEB+qu0x iQDhKCHkPHeNQKRpV3d2RuS+YT86OFBvCFIZZFTt6ISS/6Ft8Xu4X1BFJS1T9PzVZK0D s8iQ== X-Gm-Message-State: ALoCoQnO6RLDSmPgsIGb1wVWFqz7FIv5JxgPB4iK8MJjjiYdOLwmBHfRin5KqAKjrqp0yMm/slR3 X-Received: by 10.182.103.199 with SMTP id fy7mr2969240obb.18.1400869048114; Fri, 23 May 2014 11:17:28 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.34.46 with SMTP id k43ls1875595qgk.58.gmail; Fri, 23 May 2014 11:17:28 -0700 (PDT) X-Received: by 10.52.139.101 with SMTP id qx5mr4707262vdb.17.1400869047952; Fri, 23 May 2014 11:17:27 -0700 (PDT) Received: from mail-vc0-f179.google.com (mail-vc0-f179.google.com [209.85.220.179]) by mx.google.com with ESMTPS id 7si2120161vcu.41.2014.05.23.11.17.27 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 23 May 2014 11:17:27 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.179 as permitted sender) client-ip=209.85.220.179; Received: by mail-vc0-f179.google.com with SMTP id im17so6600817vcb.24 for ; Fri, 23 May 2014 11:17:27 -0700 (PDT) X-Received: by 10.58.34.72 with SMTP id x8mr70654vei.61.1400869047846; Fri, 23 May 2014 11:17:27 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp52297vcb; Fri, 23 May 2014 11:17:27 -0700 (PDT) X-Received: by 10.68.201.10 with SMTP id jw10mr8154754pbc.25.1400869047037; Fri, 23 May 2014 11:17:27 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id uv11si5065632pab.15.2014.05.23.11.17.26 for ; Fri, 23 May 2014 11:17:26 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751768AbaEWSRA (ORCPT + 27 others); Fri, 23 May 2014 14:17:00 -0400 Received: from service87.mimecast.com ([91.220.42.44]:36460 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751699AbaEWSQ6 (ORCPT ); Fri, 23 May 2014 14:16:58 -0400 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Fri, 23 May 2014 19:16:56 +0100 Received: from e103034-lin.cambridge.arm.com ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 23 May 2014 19:16:56 +0100 From: Morten Rasmussen To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, peterz@infradead.org, mingo@kernel.org Cc: rjw@rjwysocki.net, vincent.guittot@linaro.org, daniel.lezcano@linaro.org, preeti@linux.vnet.ibm.com, dietmar.eggemann@arm.com Subject: [RFC PATCH 15/16] sched: Use energy to guide wakeup task placement Date: Fri, 23 May 2014 19:16:42 +0100 Message-Id: <1400869003-27769-16-git-send-email-morten.rasmussen@arm.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1400869003-27769-1-git-send-email-morten.rasmussen@arm.com> References: <1400869003-27769-1-git-send-email-morten.rasmussen@arm.com> X-OriginalArrivalTime: 23 May 2014 18:16:56.0432 (UTC) FILETIME=[2E41C700:01CF76B3] X-MC-Unique: 114052319165605701 Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: morten.rasmussen@arm.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.179 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Attempt to pick most energy efficient wakeup in find_idlest_{group, cpu}(). Finding the optimum target requires an exhaustive search through all cpus in the groups. Instead, the target group is determined based on load and probing the energy cost on a single cpu in each group. The target cpu is the cpu with the lowest energy cost. Signed-off-by: Morten Rasmussen --- kernel/sched/fair.c | 64 +++++++++++++++++++++++++++++++++++++++++---------- 1 file changed, 52 insertions(+), 12 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 542c2b2..0d3334b 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -4556,25 +4556,27 @@ static int wake_affine(struct sched_domain *sd, struct task_struct *p, int sync) } /* - * find_idlest_group finds and returns the least busy CPU group within the - * domain. + * find_target_group finds and returns the least busy/most energy-efficient + * CPU group within the domain. */ static struct sched_group * -find_idlest_group(struct sched_domain *sd, struct task_struct *p, +find_target_group(struct sched_domain *sd, struct task_struct *p, int this_cpu, int sd_flag) { - struct sched_group *idlest = NULL, *group = sd->groups; + struct sched_group *idlest = NULL, *group = sd->groups, *energy = NULL; unsigned long min_load = ULONG_MAX, this_load = 0; int load_idx = sd->forkexec_idx; int imbalance = 100 + (sd->imbalance_pct-100)/2; + int local_energy = 0, min_energy = INT_MAX; if (sd_flag & SD_BALANCE_WAKE) load_idx = sd->wake_idx; do { - unsigned long load, avg_load; + unsigned long load, avg_load, probe_load = UINT_MAX; int local_group; int i; + int probe_cpu, energy_diff; /* Skip over this group if it has no CPUs allowed */ if (!cpumask_intersects(sched_group_cpus(group), @@ -4586,6 +4588,7 @@ find_idlest_group(struct sched_domain *sd, struct task_struct *p, /* Tally up the load of all CPUs in the group */ avg_load = 0; + probe_cpu = cpumask_first(sched_group_cpus(group)); for_each_cpu(i, sched_group_cpus(group)) { /* Bias balancing toward cpus of our domain */ @@ -4595,44 +4598,81 @@ find_idlest_group(struct sched_domain *sd, struct task_struct *p, load = target_load(i, load_idx); avg_load += load; + + if (load < probe_load) { + probe_load = load; + probe_cpu = i; + } } /* Adjust by relative CPU power of the group */ avg_load = (avg_load * SCHED_POWER_SCALE) / group->sgp->power; + /* + * Sample energy diff on probe_cpu. + * Finding the optimum cpu requires testing all cpus which is + * expensive. + */ + + energy_diff = energy_diff_task(probe_cpu, p); + if (local_group) { this_load = avg_load; - } else if (avg_load < min_load) { - min_load = avg_load; - idlest = group; + local_energy = energy_diff; + } else { + if (avg_load < min_load) { + min_load = avg_load; + idlest = group; + } + + if (energy_diff < min_energy) { + min_energy = energy_diff; + energy = group; + } } } while (group = group->next, group != sd->groups); +#ifdef CONFIG_SCHED_ENERGY + if (energy && min_energy < local_energy) + return energy; + return NULL; +#else if (!idlest || 100*this_load < imbalance*min_load) return NULL; return idlest; +#endif } /* - * find_idlest_cpu - find the idlest cpu among the cpus in group. + * find_target_cpu - find the target cpu among the cpus in group. */ static int -find_idlest_cpu(struct sched_group *group, struct task_struct *p, int this_cpu) +find_target_cpu(struct sched_group *group, struct task_struct *p, int this_cpu) { unsigned long load, min_load = ULONG_MAX; + int min_energy = INT_MAX, energy, least_energy = -1; int idlest = -1; int i; /* Traverse only the allowed CPUs */ for_each_cpu_and(i, sched_group_cpus(group), tsk_cpus_allowed(p)) { load = weighted_cpuload(i); + energy = energy_diff_task(i, p); if (load < min_load || (load == min_load && i == this_cpu)) { min_load = load; idlest = i; } + + if (energy < min_energy) { + min_energy = energy; + least_energy = i; + } } + if (least_energy >= 0) + return least_energy; + return idlest; } @@ -4755,13 +4795,13 @@ select_task_rq_fair(struct task_struct *p, int prev_cpu, int sd_flag, int wake_f continue; } - group = find_idlest_group(sd, p, cpu, sd_flag); + group = find_target_group(sd, p, cpu, sd_flag); if (!group) { sd = sd->child; continue; } - new_cpu = find_idlest_cpu(group, p, cpu); + new_cpu = find_target_cpu(group, p, cpu); if (new_cpu == -1 || new_cpu == cpu) { /* Now try balancing at a lower domain level of cpu */ sd = sd->child;