From patchwork Fri May 9 11:07:40 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tushar Behera X-Patchwork-Id: 29885 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ie0-f199.google.com (mail-ie0-f199.google.com [209.85.223.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 9EBB6202FE for ; Fri, 9 May 2014 11:09:36 +0000 (UTC) Received: by mail-ie0-f199.google.com with SMTP id rl12sf18958666iec.2 for ; Fri, 09 May 2014 04:09:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :mime-version:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe:content-type :content-transfer-encoding; bh=1WAgCPyq8ZvDyn9/pCVA6cxdj12wXGKbR9MOik0kvfs=; b=Qyc/HfYTSUZFiI60PbAkbvZcya7VSMpR7qi6oSRbs+4EV72dhQTrRBP53R6HZjF3Cp lz7YwXWRdE08Mb5Byay3Uuhi8VO6XtusTCcMyafvOsmBBpbxbSYJk+m6Lsi8f1cE2Lxz jWjuDxOi1Al9z3bAcmNnWqf7wW+GHMGXlaxlbcnwXthkKC2+lHgMUNYw1rNHxFdUqelZ W0OD7qQPXSijTObgUo8C32W55yCF5tfgn3rtMCedxhXsw1dKGtWvIhY05LaaAosVqAsu avjiexG/3A5Iwz7M7q6EwEstsn9g4d0MIWxP4a512qgRGSgvV6IYpjEzOmLmfPwXhvJD nUEA== X-Gm-Message-State: ALoCoQmVqXPs5Bkxsx3SbTx6FmIvdLImyJxowmdEepGnd2kZnbKpDAd3XLaNpUYUhc8+EWf/M+G8 X-Received: by 10.182.213.37 with SMTP id np5mr4832015obc.36.1399633775919; Fri, 09 May 2014 04:09:35 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.88.105 with SMTP id s96ls294486qgd.25.gmail; Fri, 09 May 2014 04:09:35 -0700 (PDT) X-Received: by 10.220.159.4 with SMTP id h4mr7989380vcx.1.1399633775717; Fri, 09 May 2014 04:09:35 -0700 (PDT) Received: from mail-ve0-f182.google.com (mail-ve0-f182.google.com [209.85.128.182]) by mx.google.com with ESMTPS id tx7si667886vcb.116.2014.05.09.04.09.35 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 09 May 2014 04:09:35 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.182 as permitted sender) client-ip=209.85.128.182; Received: by mail-ve0-f182.google.com with SMTP id sa20so5099305veb.27 for ; Fri, 09 May 2014 04:09:35 -0700 (PDT) X-Received: by 10.58.216.163 with SMTP id or3mr3044vec.80.1399633775606; Fri, 09 May 2014 04:09:35 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp69786vcb; Fri, 9 May 2014 04:09:35 -0700 (PDT) X-Received: by 10.224.60.137 with SMTP id p9mr723861qah.92.1399633774957; Fri, 09 May 2014 04:09:34 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ud10si2067821pbc.503.2014.05.09.04.09.34; Fri, 09 May 2014 04:09:34 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753864AbaEILJZ (ORCPT + 27 others); Fri, 9 May 2014 07:09:25 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:48857 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751918AbaEILJY (ORCPT ); Fri, 9 May 2014 07:09:24 -0400 Received: by mail-pa0-f51.google.com with SMTP id kq14so4298692pab.10 for ; Fri, 09 May 2014 04:09:23 -0700 (PDT) X-Received: by 10.66.124.137 with SMTP id mi9mr19072885pab.111.1399633763778; Fri, 09 May 2014 04:09:23 -0700 (PDT) Received: from linaro.sisodomain.com ([14.140.216.146]) by mx.google.com with ESMTPSA id bu1sm6997520pbb.54.2014.05.09.04.09.21 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 09 May 2014 04:09:23 -0700 (PDT) From: Tushar Behera To: linux-kernel@vger.kernel.org Cc: lee.jones@linaro.org, sameo@linux.intel.com, peter.chen@freescale.com Subject: [PATCH] mfd: syscon: Include linux/err.h to fix build error Date: Fri, 9 May 2014 16:37:40 +0530 Message-Id: <1399633660-17897-1-git-send-email-tushar.behera@linaro.org> X-Mailer: git-send-email 1.7.9.5 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: tushar.behera@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.182 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , commit df73de9b0d412 ("mfd: syscon: Return -ENOSYS if CONFIG_MFD_SYSCON is not enabled") introduced fallbacks for APIs, but missed out on adding the header file. This would work only if linux/err.h is also included in the source code from where this file is included. It would be better to include linux/err.h in file to remove possible build errors. Without this patch, we get following and similar build errors if this header file is included in some source file and CONFIG_MFD_SYSCON is not enabled. include/linux/mfd/syscon.h: In function ‘syscon_node_to_regmap’: include/linux/mfd/syscon.h:30:2: error: implicit declaration of function ‘ERR_PTR’ [-Werror=implicit-function-declaration] return ERR_PTR(-ENOSYS); ^ include/linux/mfd/syscon.h:30:18: error: ‘ENOSYS’ undeclared (first use in this function) return ERR_PTR(-ENOSYS); ^ Signed-off-by: Tushar Behera --- include/linux/mfd/syscon.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/mfd/syscon.h b/include/linux/mfd/syscon.h index 8789fa3..75e543b 100644 --- a/include/linux/mfd/syscon.h +++ b/include/linux/mfd/syscon.h @@ -15,6 +15,8 @@ #ifndef __LINUX_MFD_SYSCON_H__ #define __LINUX_MFD_SYSCON_H__ +#include + struct device_node; #ifdef CONFIG_MFD_SYSCON