From patchwork Thu Feb 20 08:53:04 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 24998 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qa0-f72.google.com (mail-qa0-f72.google.com [209.85.216.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 95A422066E for ; Thu, 20 Feb 2014 09:09:24 +0000 (UTC) Received: by mail-qa0-f72.google.com with SMTP id f11sf2979673qae.3 for ; Thu, 20 Feb 2014 01:09:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=cz4ZmKruD+c6MxetWv+ISWbrdfnyr4uN/ghD31932ZE=; b=BLyiur5z5P2eEddogpPBSjwaay6Dg6/nlx5vJt/42AjEyTKstK/4XOmyEDepJbaXTV XwH4IQMAaJ24+hD8E1ATZl0jDxg2zLfbmJZvQSPMwIRsKtH3C4dqjif0Vf7J3r0MKyzP EEzo+4O9daiogZSaMP4V5+zSyfDsDI7r0svbHPUwTfRaKBAPg0Ly6LYfAOm7un69EgrY 9vRz7aN3jdpOdjxjLxYa3TMoZRweRHn0yP+lnoeYc2tc9/bpNIhZ4oyO5zU5JhM/cWkJ brbH+lATZYly0jp3N+qKtEyqIl/vMlj2DLD5HAz87mdQN95wVMvMqvzOLIgKsEhNDEwY JMRg== X-Gm-Message-State: ALoCoQls8OdpSpWERygzFkZtL8/AANib7DIW/TqzwXoJnDTZC9mRZ1u1/MHpBYC6L63HlhEc+QLG X-Received: by 10.236.83.112 with SMTP id p76mr198503yhe.51.1392887364368; Thu, 20 Feb 2014 01:09:24 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.92.65 with SMTP id a59ls419119qge.72.gmail; Thu, 20 Feb 2014 01:09:24 -0800 (PST) X-Received: by 10.221.22.71 with SMTP id qv7mr398926vcb.34.1392887364237; Thu, 20 Feb 2014 01:09:24 -0800 (PST) Received: from mail-ve0-f169.google.com (mail-ve0-f169.google.com [209.85.128.169]) by mx.google.com with ESMTPS id y3si1213307vdo.32.2014.02.20.01.09.24 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 20 Feb 2014 01:09:24 -0800 (PST) Received-SPF: neutral (google.com: 209.85.128.169 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.169; Received: by mail-ve0-f169.google.com with SMTP id oy12so1599875veb.0 for ; Thu, 20 Feb 2014 01:09:24 -0800 (PST) X-Received: by 10.220.191.134 with SMTP id dm6mr411338vcb.16.1392887364168; Thu, 20 Feb 2014 01:09:24 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.174.196 with SMTP id u4csp41389vcz; Thu, 20 Feb 2014 01:09:23 -0800 (PST) X-Received: by 10.67.5.7 with SMTP id ci7mr666972pad.99.1392887363366; Thu, 20 Feb 2014 01:09:23 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ey10si2830556pab.169.2014.02.20.01.09.22; Thu, 20 Feb 2014 01:09:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755086AbaBTJJL (ORCPT + 26 others); Thu, 20 Feb 2014 04:09:11 -0500 Received: from mail-pb0-f41.google.com ([209.85.160.41]:39041 "EHLO mail-pb0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754238AbaBTI7E (ORCPT ); Thu, 20 Feb 2014 03:59:04 -0500 Received: by mail-pb0-f41.google.com with SMTP id up15so1636194pbc.0 for ; Thu, 20 Feb 2014 00:59:03 -0800 (PST) X-Received: by 10.68.129.234 with SMTP id nz10mr820108pbb.16.1392886743718; Thu, 20 Feb 2014 00:59:03 -0800 (PST) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id eo11sm21100112pac.0.2014.02.20.00.59.00 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 20 Feb 2014 00:59:02 -0800 (PST) From: Sachin Kamat To: linux-kernel@vger.kernel.org Cc: broonie@kernel.org, lgirdwood@gmail.com, sachin.kamat@linaro.org, Yunfan Zhang Subject: [PATCH 04/23] regulator: fan53555: Remove redundant error message Date: Thu, 20 Feb 2014 14:23:04 +0530 Message-Id: <1392886403-10640-4-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1392886403-10640-1-git-send-email-sachin.kamat@linaro.org> References: <1392886403-10640-1-git-send-email-sachin.kamat@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: sachin.kamat@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.169 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , kzalloc prints its own OOM message upon failure. Signed-off-by: Sachin Kamat Cc: Yunfan Zhang --- drivers/regulator/fan53555.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/fan53555.c b/drivers/regulator/fan53555.c index a10df7d150cc..714fd9a89aa1 100644 --- a/drivers/regulator/fan53555.c +++ b/drivers/regulator/fan53555.c @@ -244,10 +244,9 @@ static int fan53555_regulator_probe(struct i2c_client *client, di = devm_kzalloc(&client->dev, sizeof(struct fan53555_device_info), GFP_KERNEL); - if (!di) { - dev_err(&client->dev, "Failed to allocate device info data!\n"); + if (!di) return -ENOMEM; - } + di->regmap = devm_regmap_init_i2c(client, &fan53555_regmap_config); if (IS_ERR(di->regmap)) { dev_err(&client->dev, "Failed to allocate regmap!\n");