From patchwork Tue Feb 18 14:14:24 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Morten Rasmussen X-Patchwork-Id: 24853 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ig0-f200.google.com (mail-ig0-f200.google.com [209.85.213.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id DB3D3202B2 for ; Tue, 18 Feb 2014 14:14:54 +0000 (UTC) Received: by mail-ig0-f200.google.com with SMTP id k19sf19076284igc.3 for ; Tue, 18 Feb 2014 06:14:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe:content-type :content-transfer-encoding; bh=RV/gCs2kWQKNFqL/1aFNiJdibOxc6ztMIX8yFsm8gvo=; b=VFMsyLX2ZR5fq5Xb2Z7eB6RDJT5m9eeBwfraQ7XQmR6VXsNqZdy548jSTRnv7eRnfY y93HaUs5fo10BI10RAuCyciOH5ACZRmmuQ47adltQj6In1xmc7aC4rATqozkWrZZPGCp +7B3dMptO0c4FJoru2j0yBCsG2MDtuuLYucdX5FQcyFhoIy8STyU97uVtUtFd/0PQReK lPAO1A47dkXPqepTAQgogCnDXEschlmAA9VXjeYbXX7cE0mPZhMOzPfIS3YFl7oQUIe+ KFNE91lQArCZiEoRd4w0x2GGoYsfkG9txvejmw6IDbPXwTcwJ+HSLgI/z30ESZYjRuKs b50w== X-Gm-Message-State: ALoCoQnE8AxSP5Bea6MHuxjgzYndVMCANz6eTpEGVpHd88/UyWjiW3eacyD4/LCHBf0h4RiE4PK6 X-Received: by 10.182.66.193 with SMTP id h1mr12734672obt.47.1392732893910; Tue, 18 Feb 2014 06:14:53 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.48.161 with SMTP id o30ls1246922qga.94.gmail; Tue, 18 Feb 2014 06:14:53 -0800 (PST) X-Received: by 10.220.84.193 with SMTP id k1mr42575vcl.64.1392732893813; Tue, 18 Feb 2014 06:14:53 -0800 (PST) Received: from mail-vc0-f179.google.com (mail-vc0-f179.google.com [209.85.220.179]) by mx.google.com with ESMTPS id at8si5536889vec.37.2014.02.18.06.14.53 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 18 Feb 2014 06:14:53 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.179 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.179; Received: by mail-vc0-f179.google.com with SMTP id lh14so12886043vcb.24 for ; Tue, 18 Feb 2014 06:14:53 -0800 (PST) X-Received: by 10.220.191.134 with SMTP id dm6mr21615526vcb.16.1392732893706; Tue, 18 Feb 2014 06:14:53 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.174.196 with SMTP id u4csp219579vcz; Tue, 18 Feb 2014 06:14:53 -0800 (PST) X-Received: by 10.68.185.1 with SMTP id ey1mr33670200pbc.33.1392732892760; Tue, 18 Feb 2014 06:14:52 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id vw10si18447936pbc.317.2014.02.18.06.14.46; Tue, 18 Feb 2014 06:14:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755565AbaBROOj (ORCPT + 27 others); Tue, 18 Feb 2014 09:14:39 -0500 Received: from service87.mimecast.com ([91.220.42.44]:51745 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755276AbaBROOi (ORCPT ); Tue, 18 Feb 2014 09:14:38 -0500 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Tue, 18 Feb 2014 14:14:36 +0000 Received: from e103034-lin.cambridge.arm.com ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Tue, 18 Feb 2014 14:14:38 +0000 From: Morten Rasmussen To: linux-kernel@vger.kernel.org Cc: Morten Rasmussen , Ingo Molnar , Peter Zijlstra Subject: [PATCH] sched: Fix select_task_rq_fair() description comments Date: Tue, 18 Feb 2014 14:14:24 +0000 Message-Id: <1392732864-10927-1-git-send-email-morten.rasmussen@arm.com> X-Mailer: git-send-email 1.7.9.5 X-OriginalArrivalTime: 18 Feb 2014 14:14:38.0567 (UTC) FILETIME=[C22F1F70:01CF2CB3] X-MC-Unique: 114021814143600801 Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: morten.rasmussen@arm.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.179 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Brings select_task_rq_fair() description comments up-to-date. Cc: Ingo Molnar Cc: Peter Zijlstra Signed-off-by: Morten Rasmussen --- kernel/sched/fair.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 966cc2b..fde412b 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -4211,13 +4211,14 @@ done: } /* - * sched_balance_self: balance the current task (running on cpu) in domains - * that have the 'flag' flag set. In practice, this is SD_BALANCE_FORK and - * SD_BALANCE_EXEC. + * select_task_rq_fair: Select target runqueue for the waking task in domains + * that have the 'sd_flag' flag set. In practice, this is SD_BALANCE_WAKE, + * SD_BALANCE_FORK, or SD_BALANCE_EXEC. * - * Balance, ie. select the least loaded group. + * Balances load by selecting the idlest cpu in the idlest group, or under + * certain conditions an idle sibling cpu if the domain has SD_WAKE_AFFINE set. * - * Returns the target CPU number, or the same CPU if no balancing is needed. + * Returns the target cpu number. * * preempt must be disabled. */