From patchwork Tue Feb 4 12:57:14 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 24100 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ve0-f198.google.com (mail-ve0-f198.google.com [209.85.128.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id DCC8020445 for ; Tue, 4 Feb 2014 12:57:27 +0000 (UTC) Received: by mail-ve0-f198.google.com with SMTP id pa12sf23914992veb.5 for ; Tue, 04 Feb 2014 04:57:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=9xw8Rs3J+eBX87L7eCxeA4oEf4W+1zNogUOCMzIKv2o=; b=Ya86bb7JB0q0ipGXohm97JxCLYe9ecn+0m/f5Prz+RfvOWoOp6NMOQbqT4sw1pVoqy h0NrICzP3+vFgmH+UQjPF+DjM8ynBeVpxwm1LbgTaVmB4dS9xzwCOmwiM/wQBN56VMCv rHYzjhRXbhYBHjIO5UfcMJRFGoFfu/pjEXCAERGKbvR6AxaA4qpvTwEzaf0BEO3tPpBn af1WQW/rtFesicHu6qJC+Zb0aBkzd40O1uD6CepENFLCNhJXXtdJwVTtkJm60YyfsKec S5O3EuwUDEAp+z1gK8We0MyXvtt//SZeonrypXihrjph7kSqUJ1AnEFti2Q10wtkpC9j ztBg== X-Gm-Message-State: ALoCoQlCv4lYzP9vApWTs6tQbKJGaME2EjtfBf5GHv5XdiTa0IOqzm0d7i/YZU9QW9Fy4ZqJJyuO X-Received: by 10.236.184.165 with SMTP id s25mr5948yhm.0.1391518646823; Tue, 04 Feb 2014 04:57:26 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.20.100 with SMTP id 91ls2298306qgi.18.gmail; Tue, 04 Feb 2014 04:57:26 -0800 (PST) X-Received: by 10.52.246.42 with SMTP id xt10mr5934562vdc.9.1391518646765; Tue, 04 Feb 2014 04:57:26 -0800 (PST) Received: from mail-vb0-f41.google.com (mail-vb0-f41.google.com [209.85.212.41]) by mx.google.com with ESMTPS id xe7si8083516vec.78.2014.02.04.04.57.26 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 04 Feb 2014 04:57:26 -0800 (PST) Received-SPF: neutral (google.com: 209.85.212.41 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.212.41; Received: by mail-vb0-f41.google.com with SMTP id g10so5656493vbg.14 for ; Tue, 04 Feb 2014 04:57:26 -0800 (PST) X-Received: by 10.220.99.7 with SMTP id s7mr9758015vcn.19.1391518646689; Tue, 04 Feb 2014 04:57:26 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp232128vcz; Tue, 4 Feb 2014 04:57:26 -0800 (PST) X-Received: by 10.180.103.227 with SMTP id fz3mr12375225wib.29.1391518645868; Tue, 04 Feb 2014 04:57:25 -0800 (PST) Received: from mail-we0-f169.google.com (mail-we0-f169.google.com [74.125.82.169]) by mx.google.com with ESMTPS id dl9si11822823wjb.51.2014.02.04.04.57.25 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 04 Feb 2014 04:57:25 -0800 (PST) Received-SPF: neutral (google.com: 74.125.82.169 is neither permitted nor denied by best guess record for domain of linus.walleij@linaro.org) client-ip=74.125.82.169; Received: by mail-we0-f169.google.com with SMTP id t61so4133853wes.28 for ; Tue, 04 Feb 2014 04:57:25 -0800 (PST) X-Received: by 10.194.240.7 with SMTP id vw7mr190588wjc.75.1391518645454; Tue, 04 Feb 2014 04:57:25 -0800 (PST) Received: from localhost.localdomain ([85.235.11.236]) by mx.google.com with ESMTPSA id e5sm52441007wja.15.2014.02.04.04.57.23 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Feb 2014 04:57:24 -0800 (PST) From: Linus Walleij To: Jingoo Han , linux-kernel@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, Thierry Reding , linux-pwm@vger.kernel.org, Linus Walleij Subject: [PATCH] backlight: add PWM dependencies Date: Tue, 4 Feb 2014 13:57:14 +0100 Message-Id: <1391518634-6472-1-git-send-email-linus.walleij@linaro.org> X-Mailer: git-send-email 1.8.5.3 X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: linus.walleij@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.212.41 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , In some compilations the LM3630A and LP855X backlight drivers fail like this: drivers/built-in.o: In function `lm3630a_pwm_ctrl': drivers/video/backlight/lm3630a_bl.c:168: undefined reference to `pwm_config' drivers/video/backlight/lm3630a_bl.c:172: undefined reference to `pwm_disable' drivers/video/backlight/lm3630a_bl.c:170: undefined reference to `pwm_enable' drivers/built-in.o: In function `lp855x_pwm_ctrl': drivers/video/backlight/lp855x_bl.c:249: undefined reference to `pwm_config' drivers/video/backlight/lp855x_bl.c:253: undefined reference to `pwm_disable' drivers/video/backlight/lp855x_bl.c:251: undefined reference to `pwm_enable' This is because both drivers depend on the PWM framework, so add this dependency to their Kconfig entries. Signed-off-by: Linus Walleij Acked-by: Linus Walleij --- drivers/video/backlight/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig index 5a3eb2ecb525..0604c3348761 100644 --- a/drivers/video/backlight/Kconfig +++ b/drivers/video/backlight/Kconfig @@ -371,6 +371,7 @@ config BACKLIGHT_AAT2870 config BACKLIGHT_LM3630A tristate "Backlight Driver for LM3630A" depends on BACKLIGHT_CLASS_DEVICE && I2C + depends on PWM select REGMAP_I2C help This supports TI LM3630A Backlight Driver @@ -387,6 +388,7 @@ config BACKLIGHT_LM3639 config BACKLIGHT_LP855X tristate "Backlight driver for TI LP855X" depends on BACKLIGHT_CLASS_DEVICE && I2C + depends on PWM help This supports TI LP8550, LP8551, LP8552, LP8553, LP8555, LP8556 and LP8557 backlight driver.