From patchwork Fri Dec 13 22:23:54 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 22385 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qe0-f72.google.com (mail-qe0-f72.google.com [209.85.128.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 07D6D23FBA for ; Fri, 13 Dec 2013 22:26:38 +0000 (UTC) Received: by mail-qe0-f72.google.com with SMTP id 5sf4590403qeb.11 for ; Fri, 13 Dec 2013 14:26:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=C3dSqTflt8SOk8tYTK7MJzt1CKviIOLaUeydfarBU50=; b=jboIYI4oYWld4GtNRF2khyArN37E8hz0k8aC5deNx3gKyeAfrz7lKijjXG/ELx9jtJ M+JzFHMQPX80eS3/O1QPvf6+JfBjSDMD7Mlzk1zNmCGc3Mq37Kpq3EzgZDEXQrm1d+Cv 5f1GrpZPdUu/B0xWeVRb8sNZI7dBcj7FH5cNrWjTqa4WasZAi4ox6Xn/W/FI5wubD0A/ 9VS5Z0z61ZAMAs/fb4i4vfb7HeS2AWiYl4Lzlt1KmQsWo7DgF/cgUXa7Vzttw9fSf+xA dL2yNbU5QFrnuGIgqFti2aSQWI4gDi9iAH3SiQQGEVAJr67lydssyBWMzXrbvVyz7e8M U/lQ== X-Gm-Message-State: ALoCoQmPIf68825UoeS9AH81V8i9ywKSTlL5doL3JydMmeThgXsUn5OTpHNbAejZVhIuCV3UDbX+ X-Received: by 10.224.160.208 with SMTP id o16mr1764033qax.8.1386973597849; Fri, 13 Dec 2013 14:26:37 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.73.69 with SMTP id j5ls1224147qev.48.gmail; Fri, 13 Dec 2013 14:26:37 -0800 (PST) X-Received: by 10.52.92.83 with SMTP id ck19mr28909vdb.90.1386973597542; Fri, 13 Dec 2013 14:26:37 -0800 (PST) Received: from mail-ve0-f174.google.com (mail-ve0-f174.google.com [209.85.128.174]) by mx.google.com with ESMTPS id sm7si1187206vdc.123.2013.12.13.14.26.37 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 13 Dec 2013 14:26:37 -0800 (PST) Received-SPF: neutral (google.com: 209.85.128.174 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.174; Received: by mail-ve0-f174.google.com with SMTP id pa12so1814204veb.19 for ; Fri, 13 Dec 2013 14:26:37 -0800 (PST) X-Received: by 10.220.183.199 with SMTP id ch7mr2206702vcb.27.1386973597474; Fri, 13 Dec 2013 14:26:37 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp73477vcz; Fri, 13 Dec 2013 14:26:37 -0800 (PST) X-Received: by 10.68.197.73 with SMTP id is9mr5966953pbc.75.1386973596774; Fri, 13 Dec 2013 14:26:36 -0800 (PST) Received: from mail-pb0-f49.google.com (mail-pb0-f49.google.com [209.85.160.49]) by mx.google.com with ESMTPS id n8si2496371pax.189.2013.12.13.14.26.36 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 13 Dec 2013 14:26:36 -0800 (PST) Received-SPF: neutral (google.com: 209.85.160.49 is neither permitted nor denied by best guess record for domain of john.stultz@linaro.org) client-ip=209.85.160.49; Received: by mail-pb0-f49.google.com with SMTP id jt11so3132191pbb.22 for ; Fri, 13 Dec 2013 14:26:36 -0800 (PST) X-Received: by 10.66.159.234 with SMTP id xf10mr5940775pab.139.1386973596392; Fri, 13 Dec 2013 14:26:36 -0800 (PST) Received: from localhost.localdomain (c-67-170-153-23.hsd1.or.comcast.net. [67.170.153.23]) by mx.google.com with ESMTPSA id qz9sm7457908pbc.3.2013.12.13.14.26.35 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 13 Dec 2013 14:26:35 -0800 (PST) From: John Stultz To: LKML Cc: Greg KH , Android Kernel Team , Sumit Semwal , Jesse Barker , Colin Cross , Olav Haugan , John Stultz Subject: [PATCH 020/115] gpu: ion: Add missing argument to WARN call Date: Fri, 13 Dec 2013 14:23:54 -0800 Message-Id: <1386973529-4884-21-git-send-email-john.stultz@linaro.org> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1386973529-4884-1-git-send-email-john.stultz@linaro.org> References: <1386973529-4884-1-git-send-email-john.stultz@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: john.stultz@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.174 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Olav Haugan The condition argument to the WARN call in ion_free and ion_share_dma_buf are missing. Add the argument to allow correct printing of warning message. Signed-off-by: Olav Haugan [jstultz: modified patch to apply to staging directory] Signed-off-by: John Stultz --- drivers/staging/android/ion/ion.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index d4e4c68..5872dd3 100644 --- a/drivers/staging/android/ion/ion.c +++ b/drivers/staging/android/ion/ion.c @@ -408,7 +408,7 @@ void ion_free(struct ion_client *client, struct ion_handle *handle) mutex_unlock(&client->lock); if (!valid_handle) { - WARN("%s: invalid handle passed to free.\n", __func__); + WARN(1, "%s: invalid handle passed to free.\n", __func__); return; } ion_handle_put(handle); @@ -906,7 +906,7 @@ int ion_share_dma_buf(struct ion_client *client, struct ion_handle *handle) valid_handle = ion_handle_validate(client, handle); mutex_unlock(&client->lock); if (!valid_handle) { - WARN("%s: invalid handle passed to share.\n", __func__); + WARN(1, "%s: invalid handle passed to share.\n", __func__); return -EINVAL; }