From patchwork Tue Dec 10 09:06:10 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 22203 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pb0-f69.google.com (mail-pb0-f69.google.com [209.85.160.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 9D7A5202E6 for ; Tue, 10 Dec 2013 09:06:24 +0000 (UTC) Received: by mail-pb0-f69.google.com with SMTP id md12sf22906317pbc.4 for ; Tue, 10 Dec 2013 01:06:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=hlIC12rR7b8zzAegYWIt/Jtg8yzvVmcvCaZtqqVJOkI=; b=RQiJZ6hRI3NpEO6bVU4m7jqgXib5FOhmBODp9EikltzD2xU8SUC7iRby5EYbmEemwQ Jy0jzgZKtLuLydm0zjsRckgVktgGOmgSaj//6DYoRRysrBs02IT368f8C8gKEyUcLINF RjFlN9sVxbDVlwA3KhpgYjfObBcuF73DCmFHAPVJ7L23qy3cKX9le5eudOMdSSUhMG2w fkVj+iYsvyReYgDkY99rkoVabcwR/PYv6vF7WpS0DAovXCcxSylX5UgzLfatG6+DpVr/ /Sn+xDl0VwlK5Dgqjh59IbIP3qbsFksi68wMPA96icBeg4ckBg2Fq0lF8JKuAbIv1cll blaA== X-Gm-Message-State: ALoCoQmDMUaXnCzSndNPEbPrqI4lo87RtS2dq5nkfzBHCgAnusHDuDs8GbQdN4z7ua45hxbP/+LV X-Received: by 10.66.144.133 with SMTP id sm5mr12414841pab.5.1386666383244; Tue, 10 Dec 2013 01:06:23 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.131.4 with SMTP id oi4ls2380070qeb.76.gmail; Tue, 10 Dec 2013 01:06:23 -0800 (PST) X-Received: by 10.220.177.132 with SMTP id bi4mr264781vcb.49.1386666383062; Tue, 10 Dec 2013 01:06:23 -0800 (PST) Received: from mail-ve0-f177.google.com (mail-ve0-f177.google.com [209.85.128.177]) by mx.google.com with ESMTPS id tl2si4921014vdc.90.2013.12.10.01.06.23 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 10 Dec 2013 01:06:23 -0800 (PST) Received-SPF: neutral (google.com: 209.85.128.177 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.177; Received: by mail-ve0-f177.google.com with SMTP id db12so4562132veb.36 for ; Tue, 10 Dec 2013 01:06:23 -0800 (PST) X-Received: by 10.58.75.34 with SMTP id z2mr267015vev.57.1386666382989; Tue, 10 Dec 2013 01:06:22 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp172173vcz; Tue, 10 Dec 2013 01:06:22 -0800 (PST) X-Received: by 10.152.120.7 with SMTP id ky7mr34676lab.83.1386666381642; Tue, 10 Dec 2013 01:06:21 -0800 (PST) Received: from mail-la0-f48.google.com (mail-la0-f48.google.com [209.85.215.48]) by mx.google.com with ESMTPS id p10si5126273lag.1.2013.12.10.01.06.21 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 10 Dec 2013 01:06:21 -0800 (PST) Received-SPF: neutral (google.com: 209.85.215.48 is neither permitted nor denied by best guess record for domain of linus.walleij@linaro.org) client-ip=209.85.215.48; Received: by mail-la0-f48.google.com with SMTP id n7so2436999lam.35 for ; Tue, 10 Dec 2013 01:06:21 -0800 (PST) X-Received: by 10.152.9.193 with SMTP id c1mr4604299lab.53.1386666380054; Tue, 10 Dec 2013 01:06:20 -0800 (PST) Received: from localhost.localdomain ([85.235.11.236]) by mx.google.com with ESMTPSA id c8sm20370364lag.3.2013.12.10.01.06.16 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Dec 2013 01:06:18 -0800 (PST) From: Linus Walleij To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Stephen Warren , Linus Walleij , Bjorn Andersson Subject: [PATCH] pinctrl: make the MSM SoC driver depend on OF Date: Tue, 10 Dec 2013 10:06:10 +0100 Message-Id: <1386666370-6394-1-git-send-email-linus.walleij@linaro.org> X-Mailer: git-send-email 1.8.3.1 X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: linus.walleij@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.177 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , We had a compilation failure on x86_64 due to missing OF support as this was an implicit dependency. Add an explicit dependency on OF and OF_IRQ on the SoC driver. Cc: Bjorn Andersson Signed-off-by: Linus Walleij --- ChangeLog v2->v3: - Total failure with older approaches: what we need to do is have the *SoC subdriver* depend on OF and OF_IRQ. This is because the placeholder bool PINCTRL_MSM cannot cascade its dependencies when a subdriver selects it, Kconfig is smart but not that smart. ChangeLog v1->v2: - OK so "depends on OF" did not work here let's try to simply select OF and OF_IRQ for this then? It's one of those "warning: (PINCTRL_MSM8X74) selects PINCTRL_MSM which has unmet direct dependencies (PINCTRL && OF)" that I simply cannot find my way out of :-/ --- drivers/pinctrl/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index 06e057bb3376..30fcb897eb99 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -211,6 +211,7 @@ config PINCTRL_MSM config PINCTRL_MSM8X74 bool "Qualcomm 8x74 pin controller driver" + depends on OF && OF_IRQ select PINCTRL_MSM config PINCTRL_NOMADIK