From patchwork Thu Aug 15 19:31:15 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 19171 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ve0-f198.google.com (mail-ve0-f198.google.com [209.85.128.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 3093525A1B for ; Thu, 15 Aug 2013 19:31:28 +0000 (UTC) Received: by mail-ve0-f198.google.com with SMTP id 15sf1406681vea.9 for ; Thu, 15 Aug 2013 12:31:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-gm-message-state:delivered-to:from:to:cc:subject :date:message-id:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=o4EN01aQcr9SNPL0Rf46LHwnOlpvcPQyc3zGFZWXp4A=; b=K6H4Ny8X/zRiqF05CkzDQCvoYwAaZ2rUh31CPjwhJDYC80LfvH97AwJ0TeYjRcubKP SA5/RCgBDDdwTvHna7wGTPDNKy7X6ISXbsGoGiKF7kJUfJyD+qii9i56TG3xmmiax1oI tmWpnxtQ0U9yRTB8sTvmjuIjO1RsoKohFWWh2DQmaxMIaU6wGg1/m7l6WLOwIgIetrbm XXhXswfbuOJxstOGD1/3eBZf++9vuXzbOKi4Uan3a+PUyjQT9uoiNUpyqH5pLU2Lp5JU BIvybTRdm0vknOgkEpC+sAzG9rV+OK+dtvci4o90Oxvav6KdNWN1x5/VO3gogcGJ5jGa Wmrg== X-Received: by 10.58.106.198 with SMTP id gw6mr5909488veb.6.1376595087432; Thu, 15 Aug 2013 12:31:27 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.29.167 with SMTP id l7ls456768qeh.47.gmail; Thu, 15 Aug 2013 12:31:27 -0700 (PDT) X-Received: by 10.220.88.13 with SMTP id y13mr16111653vcl.20.1376595087268; Thu, 15 Aug 2013 12:31:27 -0700 (PDT) Received: from mail-vb0-f51.google.com (mail-vb0-f51.google.com [209.85.212.51]) by mx.google.com with ESMTPS id bq2si233805vcb.115.2013.08.15.12.31.27 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 15 Aug 2013 12:31:27 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.212.51 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.212.51; Received: by mail-vb0-f51.google.com with SMTP id x16so930881vbf.24 for ; Thu, 15 Aug 2013 12:31:26 -0700 (PDT) X-Gm-Message-State: ALoCoQkShMABDZUDDNrWxpjayQNYyYBybhyRJk6NP6AiWuSW130wh9eELrC0xZceOBMK2lH1P+3U X-Received: by 10.52.115.102 with SMTP id jn6mr13780811vdb.18.1376595086922; Thu, 15 Aug 2013 12:31:26 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp29432vcz; Thu, 15 Aug 2013 12:31:26 -0700 (PDT) X-Received: by 10.112.87.68 with SMTP id v4mr13974413lbz.2.1376595085421; Thu, 15 Aug 2013 12:31:25 -0700 (PDT) Received: from mail-la0-f52.google.com (mail-la0-f52.google.com [209.85.215.52]) by mx.google.com with ESMTPS id nw5si350286lbb.116.2013.08.15.12.31.24 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 15 Aug 2013 12:31:24 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.215.52 is neither permitted nor denied by best guess record for domain of linus.walleij@linaro.org) client-ip=209.85.215.52; Received: by mail-la0-f52.google.com with SMTP id ev20so864177lab.11 for ; Thu, 15 Aug 2013 12:31:24 -0700 (PDT) X-Received: by 10.112.52.225 with SMTP id w1mr7748136lbo.31.1376595084276; Thu, 15 Aug 2013 12:31:24 -0700 (PDT) Received: from localhost.localdomain (c83-249-208-76.bredband.comhem.se. [83.249.208.76]) by mx.google.com with ESMTPSA id k6sm178088lae.9.2013.08.15.12.31.22 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 15 Aug 2013 12:31:23 -0700 (PDT) From: Linus Walleij To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Stephen Warren , Linus Walleij Subject: [PATCH] pinctrl: nomadik: shut up a warning for flags Date: Thu, 15 Aug 2013 21:31:15 +0200 Message-Id: <1376595075-791-1-git-send-email-linus.walleij@linaro.org> X-Mailer: git-send-email 1.8.1.4 X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: linus.walleij@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.212.51 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The irq flags variable gets a warning like this after commit bf4dae5ce1b95a5932e43036edcf3f1b324758c6 "pinctrl: nomadik: delete ancient pin control API": In file included from include/linux/seqlock.h:29:0, from include/linux/time.h:5, from include/linux/stat.h:18, from include/linux/module.h:10, from drivers/pinctrl/pinctrl-nomadik.c:14: drivers/pinctrl/pinctrl-nomadik.c: In function 'nmk_pmx_enable': include/linux/spinlock.h:348:122: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized] raw_spin_unlock_irqrestore(&lock->rlock, flags); ^ drivers/pinctrl/pinctrl-nomadik.c:1515:16: note: 'flags' was declared here unsigned long flags; The function is question was never changed but it appears the semantic checker could previously determine that the code path that would use the flags was going to either use it or not, but now it can't for some reason. Just fix it up. Reported-by: Olof Johansson Signed-off-by: Linus Walleij --- drivers/pinctrl/pinctrl-nomadik.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-nomadik.c b/drivers/pinctrl/pinctrl-nomadik.c index 89280bc..a8b8a53 100644 --- a/drivers/pinctrl/pinctrl-nomadik.c +++ b/drivers/pinctrl/pinctrl-nomadik.c @@ -1512,7 +1512,7 @@ static int nmk_pmx_enable(struct pinctrl_dev *pctldev, unsigned function, struct nmk_pinctrl *npct = pinctrl_dev_get_drvdata(pctldev); const struct nmk_pingroup *g; static unsigned int slpm[NUM_BANKS]; - unsigned long flags; + unsigned long flags = 0; bool glitch; int ret = -EINVAL; int i;