From patchwork Mon Jun 17 09:38:12 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 17947 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-vc0-f200.google.com (mail-vc0-f200.google.com [209.85.220.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 8512B23971 for ; Mon, 17 Jun 2013 09:52:59 +0000 (UTC) Received: by mail-vc0-f200.google.com with SMTP id kw10sf3488315vcb.3 for ; Mon, 17 Jun 2013 02:52:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-beenthere:x-forwarded-to:x-forwarded-for:delivered-to:from:to:cc :subject:date:message-id:x-mailer:mime-version:x-gm-message-state :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:x-google-group-id:list-post:list-help :list-archive:list-unsubscribe:content-type :content-transfer-encoding; bh=dFKi8fpB9wBV7hXLgXX/59rXlr0YiCj2hlN8bLYA1KQ=; b=pdKLqpos8gNXTygj6stuZYw81bBZD8Q8O07Cdtb/avrDvC8UdHiZbXqGv6cNW6O3K7 PP8qZZcckQOl5h/nwSgE7XAiDWpJaL2Fs6e2LrHBo+iZKddpm8u5SGD+YkSTmllZoHa/ CIQcYVxKBpbpqF44FutL04GzzOOmn7xbOSg2eCuvDSv3Cp+7vRvcLDSUmQkG/ucbrPP4 1NGWr+CcM3u++jqgqKbwffuH3KbIc36tMtnwUaxXaqo+Q491DS1IPUql2GpZZnV0EJgD h8+xSoqfZLhEqNRJ9zbU13vSTKQalhXm4watDe4q/KjhHzRy8G3It5764ItgR9ime4GU qbsQ== X-Received: by 10.224.57.65 with SMTP id b1mr4046620qah.2.1371462779148; Mon, 17 Jun 2013 02:52:59 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.83.134 with SMTP id q6ls878352qey.89.gmail; Mon, 17 Jun 2013 02:52:59 -0700 (PDT) X-Received: by 10.220.83.138 with SMTP id f10mr4298672vcl.7.1371462778975; Mon, 17 Jun 2013 02:52:58 -0700 (PDT) Received: from mail-vc0-f177.google.com (mail-vc0-f177.google.com [209.85.220.177]) by mx.google.com with ESMTPS id 6si150141vca.87.2013.06.17.02.52.58 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 17 Jun 2013 02:52:58 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.177 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.177; Received: by mail-vc0-f177.google.com with SMTP id hv10so1821952vcb.36 for ; Mon, 17 Jun 2013 02:52:58 -0700 (PDT) X-Received: by 10.52.120.77 with SMTP id la13mr17086vdb.23.1371462778771; Mon, 17 Jun 2013 02:52:58 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.58.165.8 with SMTP id yu8csp27675veb; Mon, 17 Jun 2013 02:52:58 -0700 (PDT) X-Received: by 10.68.69.108 with SMTP id d12mr12262061pbu.187.1371462777859; Mon, 17 Jun 2013 02:52:57 -0700 (PDT) Received: from mail-pb0-x22e.google.com (mail-pb0-x22e.google.com [2607:f8b0:400e:c01::22e]) by mx.google.com with ESMTPS id az2si5693112pab.201.2013.06.17.02.52.57 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 17 Jun 2013 02:52:57 -0700 (PDT) Received-SPF: neutral (google.com: 2607:f8b0:400e:c01::22e is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=2607:f8b0:400e:c01::22e; Received: by mail-pb0-f46.google.com with SMTP id rq2so2607523pbb.19 for ; Mon, 17 Jun 2013 02:52:57 -0700 (PDT) X-Received: by 10.68.132.199 with SMTP id ow7mr12045395pbb.161.1371462777372; Mon, 17 Jun 2013 02:52:57 -0700 (PDT) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id fl2sm14228634pab.23.2013.06.17.02.52.53 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 17 Jun 2013 02:52:56 -0700 (PDT) From: Sachin Kamat To: linux-kernel@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org, linus.walleij@linaro.org, sachin.kamat@linaro.org, patches@linaro.org, Doug Anderson Subject: [PATCH Resend] pinctrl: exynos: Fix build breakage Date: Mon, 17 Jun 2013 15:08:12 +0530 Message-Id: <1371461892-5298-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 MIME-Version: 1.0 X-Gm-Message-State: ALoCoQkAbYP43OaWyKGlYUgLCMppXOaXmoALmiZ3n72j5HO5R7GE1FguwXAwghz875c1WIERfuUx X-Original-Sender: sachin.kamat@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.177 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , 'exynos_wkup_irq_ack' should be defined ahead of its call. Fixes the following error: drivers/pinctrl/pinctrl-exynos.c: In function ‘exynos_wkup_irq_mask’: drivers/pinctrl/pinctrl-exynos.c:299:3: error: implicit declaration of function ‘exynos_wkup_irq_ack’ [-Werror=implicit-function-declaration] exynos_wkup_irq_ack(irqd); Signed-off-by: Sachin Kamat Cc: Doug Anderson --- Fixed the commit message. --- drivers/pinctrl/pinctrl-exynos.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/pinctrl/pinctrl-exynos.c b/drivers/pinctrl/pinctrl-exynos.c index 8cd5bf5..f9277bc 100644 --- a/drivers/pinctrl/pinctrl-exynos.c +++ b/drivers/pinctrl/pinctrl-exynos.c @@ -279,6 +279,15 @@ err_domains: return ret; } +static void exynos_wkup_irq_ack(struct irq_data *irqd) +{ + struct samsung_pin_bank *b = irq_data_get_irq_chip_data(irqd); + struct samsung_pinctrl_drv_data *d = b->drvdata; + unsigned long pend = d->ctrl->weint_pend + b->eint_offset; + + writel(1 << irqd->hwirq, d->virt_base + pend); +} + static void exynos_wkup_irq_mask(struct irq_data *irqd) { struct samsung_pin_bank *b = irq_data_get_irq_chip_data(irqd); @@ -307,15 +316,6 @@ static void exynos_wkup_irq_mask(struct irq_data *irqd) spin_unlock_irqrestore(&b->slock, flags); } -static void exynos_wkup_irq_ack(struct irq_data *irqd) -{ - struct samsung_pin_bank *b = irq_data_get_irq_chip_data(irqd); - struct samsung_pinctrl_drv_data *d = b->drvdata; - unsigned long pend = d->ctrl->weint_pend + b->eint_offset; - - writel(1 << irqd->hwirq, d->virt_base + pend); -} - static void exynos_wkup_irq_unmask(struct irq_data *irqd) { struct samsung_pin_bank *b = irq_data_get_irq_chip_data(irqd);