From patchwork Mon Feb 4 11:53:45 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 14479 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 91B2D23F96 for ; Mon, 4 Feb 2013 11:56:44 +0000 (UTC) Received: from mail-ve0-f182.google.com (mail-ve0-f182.google.com [209.85.128.182]) by fiordland.canonical.com (Postfix) with ESMTP id 39FF7A18477 for ; Mon, 4 Feb 2013 11:56:44 +0000 (UTC) Received: by mail-ve0-f182.google.com with SMTP id ox1so3769387veb.13 for ; Mon, 04 Feb 2013 03:56:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-received:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references:x-gm-message-state; bh=yGi2KpxVi81sCKjatbGaDD7Fg7X94BlTUe3Ja0Of0vg=; b=QDbMt2+aOorILKmdTZ0sasE5X2ypD6H49nxgzlfZHfwXikfwBTOWrFwIYR8z5wLrUT ZFVvvDLvpqKF31jDgTu68RvcCRvsGqnrqt9g4yyzW2ezNgh+jFsb+yaVlH+KyxdTYker aIzkf85Z6HRMPPwaalkYo6F/qIY44088GhWe0RDb0wSSen7NtdbuNDOq/pAhSkzNXLzs aRDbvI5ejrKyzgpfxj/gjxxJpkdovS2wGfYLIWXQbHlbE3dopILfMYxtefUeyN47/AQD fpgmBczw8PxFg/FIOK95sEDXTB8lcbJJVSHpRZTd9uWX77MhoUZ73USDkjCOvqvEITHL iJHw== X-Received: by 10.52.21.146 with SMTP id v18mr18930341vde.79.1359979003748; Mon, 04 Feb 2013 03:56:43 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.58.252.8 with SMTP id zo8csp83067vec; Mon, 4 Feb 2013 03:56:43 -0800 (PST) X-Received: by 10.180.85.103 with SMTP id g7mr9999998wiz.29.1359979002760; Mon, 04 Feb 2013 03:56:42 -0800 (PST) Received: from mail-we0-x22d.google.com ([2a00:1450:400c:c03::22d]) by mx.google.com with ESMTPS id d5si5711516wje.202.2013.02.04.03.56.42 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 04 Feb 2013 03:56:42 -0800 (PST) Received-SPF: neutral (google.com: 2a00:1450:400c:c03::22d is neither permitted nor denied by best guess record for domain of lee.jones@linaro.org) client-ip=2a00:1450:400c:c03::22d; Authentication-Results: mx.google.com; spf=neutral (google.com: 2a00:1450:400c:c03::22d is neither permitted nor denied by best guess record for domain of lee.jones@linaro.org) smtp.mail=lee.jones@linaro.org Received: by mail-we0-f173.google.com with SMTP id r5so4706817wey.32 for ; Mon, 04 Feb 2013 03:56:42 -0800 (PST) X-Received: by 10.180.106.231 with SMTP id gx7mr9942581wib.4.1359979002312; Mon, 04 Feb 2013 03:56:42 -0800 (PST) Received: from localhost.localdomain (cpc34-aztw25-2-0-cust250.18-1.cable.virginmedia.com. [86.16.136.251]) by mx.google.com with ESMTPS id j9sm12937128wia.5.2013.02.04.03.56.40 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 04 Feb 2013 03:56:41 -0800 (PST) From: Lee Jones To: linux-kernel@vger.kernel.org, broonie@opensource.wolfsonmicro.com Cc: Bengt Jonsson , Lee Jones Subject: [PATCH 30/73] regulator: ab8500: Remove Vsafe voltage settings Date: Mon, 4 Feb 2013 11:53:45 +0000 Message-Id: <1359978868-28736-31-git-send-email-lee.jones@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1359978868-28736-1-git-send-email-lee.jones@linaro.org> References: <1359978868-28736-1-git-send-email-lee.jones@linaro.org> X-Gm-Message-State: ALoCoQmtYglXW6F3sh4ALrqL2m8DM/aR9dkRYv5KJxaa8nhdTcWFphIUIrxlEqDHb2P7TFRWvEC0 From: Bengt Jonsson The Vsafe regulator should not be handled by the kernel, it should be setup before the kernel starts. This patch removes the voltage settings. Current consumption will increase slightly (rough estimate 25 uA) when the platform is in the low power state because SoC sets a voltage of 0.95 V where the kernel set a voltage of 0.925 V. Signed-off-by: Bengt Jonsson Signed-off-by: Lee Jones --- arch/arm/mach-ux500/board-mop500-regulators.c | 10 ---------- drivers/regulator/ab8500.c | 10 ---------- include/linux/regulator/ab8500.h | 2 -- 3 files changed, 22 deletions(-) diff --git a/arch/arm/mach-ux500/board-mop500-regulators.c b/arch/arm/mach-ux500/board-mop500-regulators.c index 8473ee1..f9f3fc3 100644 --- a/arch/arm/mach-ux500/board-mop500-regulators.c +++ b/arch/arm/mach-ux500/board-mop500-regulators.c @@ -265,22 +265,12 @@ static struct ab8500_regulator_reg_init ab8500_reg_init[] = { */ INIT_REGULATOR_REGISTER(AB8500_VSMPS2REGU, 0x0f, 0x06), /* - * Vsmps3Sel2 = 1.2125 V - * NOTE! PRCMU register - */ - INIT_REGULATOR_REGISTER(AB8500_VSMPS3SEL2, 0x7f, 0x29), - /* * Vsmps3Regu = HW control * Vsmps3SelCtrl = Vsmps3 voltage defined by Vsmps3Sel2 * NOTE! PRCMU register */ INIT_REGULATOR_REGISTER(AB8500_VSMPS3REGU, 0x0f, 0x06), /* - * Vsmps3Sel1 = 0.9 V - * NOTE! PRCMU register - */ - INIT_REGULATOR_REGISTER(AB8500_VSMPS3SEL1, 0x7f, 0x10), - /* * VPll = Hw controlled * VanaRegu = force off */ diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c index 406c561..3f5db96 100644 --- a/drivers/regulator/ab8500.c +++ b/drivers/regulator/ab8500.c @@ -802,16 +802,6 @@ static struct ab8500_reg_init ab8500_reg_init[] = { */ REG_INIT(AB8500_VSMPS2SEL3, 0x04, 0x19, 0x3f), /* - * 0x7f, Vsmps3Sel1 - * NOTE! PRCMU register - */ - REG_INIT(AB8500_VSMPS3SEL1, 0x04, 0x1b, 0x7f), - /* - * 0x7f, Vsmps3Sel2 - * NOTE! PRCMU register - */ - REG_INIT(AB8500_VSMPS3SEL2, 0x04, 0x1c, 0x7f), - /* * 0x0f, Vaux1Sel */ REG_INIT(AB8500_VAUX1SEL, 0x04, 0x1f, 0x0f), diff --git a/include/linux/regulator/ab8500.h b/include/linux/regulator/ab8500.h index 094d24c..74955db 100644 --- a/include/linux/regulator/ab8500.h +++ b/include/linux/regulator/ab8500.h @@ -93,8 +93,6 @@ enum ab8500_regulator_reg { AB8500_VSMPS2SEL1, AB8500_VSMPS2SEL2, AB8500_VSMPS2SEL3, - AB8500_VSMPS3SEL1, /* NOTE! PRCMU register */ - AB8500_VSMPS3SEL2, /* NOTE! PRCMU register */ AB8500_VAUX1SEL, AB8500_VAUX2SEL, AB8500_VRF1VAUX3SEL,