From patchwork Fri Dec 14 16:19:25 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 13593 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 6874A23FB4 for ; Fri, 14 Dec 2012 16:20:00 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id 19EE0A19D55 for ; Fri, 14 Dec 2012 16:20:00 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id c10so6157715ieb.11 for ; Fri, 14 Dec 2012 08:19:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references:x-gm-message-state; bh=PCpzUdSIrlxOlANaIW5JxXS2NyMBo/ZWzf57FiXv5eI=; b=pAQ92ZDpd2AuH6iEg5yy+us60OlMrEZJ8qYRlDm8bTxRPO/27yHrf41+4oocq2TuGg ClW53jef7jndyXzDA1xiOsHyM62US0s88AjrzB1gi9UmuPK+QiDUA25z5PwoFCZAjSLO +yXNOC+xLxvCP0xY5S36NBii68NdfF3Hhf1O5/KUHGJXI+ekixRO8vpEWruMWugyvzzV pd9G8xLP2oDe59zI5jkzuFYv6FpmgGFQG0ejbbaSWYPwB7s/+WlwL1blW2P9KTh6LO1u ryK/I9BrneP6w1WZ9uqQ/N5RNbUwlWf4OftX7qKLDdnmjtbVFnOWtYvADsJp0nGwbdKR fdwQ== X-Received: by 10.50.91.195 with SMTP id cg3mr2030086igb.57.1355501999526; Fri, 14 Dec 2012 08:19:59 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.67.148 with SMTP id n20csp81588igt; Fri, 14 Dec 2012 08:19:59 -0800 (PST) X-Received: by 10.180.75.135 with SMTP id c7mr3597184wiw.10.1355501998704; Fri, 14 Dec 2012 08:19:58 -0800 (PST) Received: from mail-we0-f176.google.com (mail-we0-f176.google.com [74.125.82.176]) by mx.google.com with ESMTPS id ht5si7996417wib.2.2012.12.14.08.19.58 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 14 Dec 2012 08:19:58 -0800 (PST) Received-SPF: neutral (google.com: 74.125.82.176 is neither permitted nor denied by best guess record for domain of lee.jones@linaro.org) client-ip=74.125.82.176; Authentication-Results: mx.google.com; spf=neutral (google.com: 74.125.82.176 is neither permitted nor denied by best guess record for domain of lee.jones@linaro.org) smtp.mail=lee.jones@linaro.org Received: by mail-we0-f176.google.com with SMTP id r5so1627916wey.7 for ; Fri, 14 Dec 2012 08:19:58 -0800 (PST) Received: by 10.194.174.196 with SMTP id bu4mr4454540wjc.35.1355501998240; Fri, 14 Dec 2012 08:19:58 -0800 (PST) Received: from localhost.localdomain (cpc1-aztw13-0-0-cust473.18-1.cable.virginmedia.com. [77.102.241.218]) by mx.google.com with ESMTPS id u6sm8325248wif.2.2012.12.14.08.19.56 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 14 Dec 2012 08:19:57 -0800 (PST) From: Lee Jones To: linux-kernel@vger.kernel.org Cc: linus.walleij@linaro.org, Marcel Tunnissen , Lee Jones Subject: [PATCH 07/21] gpio: ab8500: Write argument value instead of hardwired 1 Date: Fri, 14 Dec 2012 16:19:25 +0000 Message-Id: <1355501979-1157-8-git-send-email-lee.jones@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1355501979-1157-1-git-send-email-lee.jones@linaro.org> References: <1355501979-1157-1-git-send-email-lee.jones@linaro.org> X-Gm-Message-State: ALoCoQmWZSY0q6QdYJV1LX35VFOXe/KlxK+w14SdQVo+8t7CIY2RvcN7DtFxpvCKB3qdWsZKS902 From: Marcel Tunnissen This fixes a bug in gpio_set_value(xxx, 0) for ab8500 GPIOs. Signed-off-by: Lee Jones Signed-off-by: Marcel Tunnissen Reviewed-by: Jonas ABERG Tested-by: Jonas ABERG --- drivers/gpio/gpio-ab8500.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-ab8500.c b/drivers/gpio/gpio-ab8500.c index b71bb72..d3bbcce 100644 --- a/drivers/gpio/gpio-ab8500.c +++ b/drivers/gpio/gpio-ab8500.c @@ -132,7 +132,7 @@ static void ab8500_gpio_set(struct gpio_chip *chip, unsigned offset, int val) struct ab8500_gpio *ab8500_gpio = to_ab8500_gpio(chip); int ret; /* Write the data */ - ret = ab8500_gpio_set_bits(chip, AB8500_GPIO_OUT1_REG, offset, 1); + ret = ab8500_gpio_set_bits(chip, AB8500_GPIO_OUT1_REG, offset, val); if (ret < 0) dev_err(ab8500_gpio->dev, "%s write failed\n", __func__); }