From patchwork Fri Dec 14 16:19:36 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 13604 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 2A2D523FB4 for ; Fri, 14 Dec 2012 16:20:17 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id CD398A195F6 for ; Fri, 14 Dec 2012 16:20:16 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id c10so6158186ieb.11 for ; Fri, 14 Dec 2012 08:20:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=sLLoAjh3U4IhZjr+Y3AkXQtJDFkaNxy+NBzlR0wAqhM=; b=mmI0mTpzhqNXfxz903dAVl0waERMfaZNlSC41/HrChlRfkxKcj+JVAL5g7NgBaDa5y hbjeIw1LLjD95z8yg6Ylx6vrpsgMtTs99atP1rJmdpxndWO0KOHXigK1SDNxmjYUPW9R wYuqEOyoJMZWv1A1VDjmXTldstacK1iEKlsQnJVCL7Qf2D+2BlGjk11DZL1TCgT7/Kij UKdd1RqpTgSdLVNHb0tf+UKV/LtSaQeGCWNLiuvYuEcM8Bjgxt/xAYk5T54qNiG1vRkG Bjk3YBHTYjmXgS0Ruyrw20yP6HluonudbGGG11pjXJ16RLhxo4AcIgERcAIuvsfyppId xYWQ== Received: by 10.50.36.164 with SMTP id r4mr2034692igj.57.1355502016263; Fri, 14 Dec 2012 08:20:16 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.67.148 with SMTP id n20csp81613igt; Fri, 14 Dec 2012 08:20:15 -0800 (PST) Received: by 10.180.103.106 with SMTP id fv10mr3581869wib.19.1355502014881; Fri, 14 Dec 2012 08:20:14 -0800 (PST) Received: from mail-we0-f175.google.com (mail-we0-f175.google.com [74.125.82.175]) by mx.google.com with ESMTPS id d4si7975477wix.30.2012.12.14.08.20.14 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 14 Dec 2012 08:20:14 -0800 (PST) Received-SPF: neutral (google.com: 74.125.82.175 is neither permitted nor denied by best guess record for domain of lee.jones@linaro.org) client-ip=74.125.82.175; Authentication-Results: mx.google.com; spf=neutral (google.com: 74.125.82.175 is neither permitted nor denied by best guess record for domain of lee.jones@linaro.org) smtp.mail=lee.jones@linaro.org Received: by mail-we0-f175.google.com with SMTP id z53so1519113wey.6 for ; Fri, 14 Dec 2012 08:20:14 -0800 (PST) Received: by 10.180.101.99 with SMTP id ff3mr3578017wib.21.1355502014420; Fri, 14 Dec 2012 08:20:14 -0800 (PST) Received: from localhost.localdomain (cpc1-aztw13-0-0-cust473.18-1.cable.virginmedia.com. [77.102.241.218]) by mx.google.com with ESMTPS id u6sm8325248wif.2.2012.12.14.08.20.13 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 14 Dec 2012 08:20:13 -0800 (PST) From: Lee Jones To: linux-kernel@vger.kernel.org Cc: linus.walleij@linaro.org, Yang QU , Lee Jones Subject: [PATCH 18/21] gpio: ab8500: Fix parameter uninitialized warning for ab8540 Date: Fri, 14 Dec 2012 16:19:36 +0000 Message-Id: <1355501979-1157-19-git-send-email-lee.jones@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1355501979-1157-1-git-send-email-lee.jones@linaro.org> References: <1355501979-1157-1-git-send-email-lee.jones@linaro.org> X-Gm-Message-State: ALoCoQnBhDjhfST6BlU9sFjjev5rOEWt1wnAvEGeoQDsuy4ZQjoX8pqfcG8etZwf466tgCNozXwY From: Yang QU Missing initial value in ab8540 gpio configuration function. So initialize it and fix this warning. Signed-off-by: Lee Jones Signed-off-by: Yang QU Reviewed-by: Rabin VINCENT --- drivers/gpio/gpio-ab8500.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpio/gpio-ab8500.c b/drivers/gpio/gpio-ab8500.c index b4f631a..833d4c2 100644 --- a/drivers/gpio/gpio-ab8500.c +++ b/drivers/gpio/gpio-ab8500.c @@ -673,6 +673,8 @@ int ab8540_gpio_config_vinsel(struct device *dev, goto out; } + pos = (gpio - AB8500_PIN_GPIO(51)) << 1; + ret = abx500_mask_and_set_register_interruptible(dev, AB8500_MISC, AB8540_GPIO_VINSEL_REG, AB8540_GPIO_VINSEL_MASK << pos, val << pos);