From patchwork Fri Nov 23 07:00:18 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tushar Behera X-Patchwork-Id: 13123 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id EE75123FC1 for ; Fri, 23 Nov 2012 07:06:41 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id A01DDA18AD0 for ; Fri, 23 Nov 2012 07:06:41 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id c10so1454579ieb.11 for ; Thu, 22 Nov 2012 23:06:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=3AnFhJHg+R88nArLMfLGOcOCQTm9NNEOMbYYN4J6MWc=; b=E1fQKnI965wXmr1Gwj6dA0e0orTmu+fSh9PcBopC6tLexOeJ+2vCgSzM2y0INHFI7w S7n6kEEBQumIHbfbXiCttihQLseKTEwFUDjJTtyA3uksTBVsUJ81kVRho8F7YaVFozPB Zgiy64fE8YOmdvA5YbhUtU/OfTZWor4WVrKi/UHds1nwG+CZ8GNWxpALPIJXlxrYHavV /7iu3aCG/O4Xl2gEf43n/wwmGEvGMFcK3yLVX5ugDEx4YxKPWSPzNDNc77OlzF4OZrBO 9lXnG3Jd7T8IVfFNpdnyeApYWy7CKoh/uc4wrRQ0Yh11nr11yH1yKhm/9d6glYmAqCKy JbJA== Received: by 10.43.125.133 with SMTP id gs5mr2380997icc.54.1353654401447; Thu, 22 Nov 2012 23:06:41 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.67.148 with SMTP id n20csp312438igt; Thu, 22 Nov 2012 23:06:41 -0800 (PST) Received: by 10.66.79.168 with SMTP id k8mr8213722pax.12.1353654400721; Thu, 22 Nov 2012 23:06:40 -0800 (PST) Received: from mail-pa0-f41.google.com (mail-pa0-f41.google.com [209.85.220.41]) by mx.google.com with ESMTPS id zo3si7726818pbc.150.2012.11.22.23.06.40 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 22 Nov 2012 23:06:40 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.41 is neither permitted nor denied by best guess record for domain of tushar.behera@linaro.org) client-ip=209.85.220.41; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.41 is neither permitted nor denied by best guess record for domain of tushar.behera@linaro.org) smtp.mail=tushar.behera@linaro.org Received: by mail-pa0-f41.google.com with SMTP id bj3so2409109pad.14 for ; Thu, 22 Nov 2012 23:06:40 -0800 (PST) Received: by 10.68.238.72 with SMTP id vi8mr11774369pbc.55.1353654400408; Thu, 22 Nov 2012 23:06:40 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id nm9sm3349142pbc.46.2012.11.22.23.06.37 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 22 Nov 2012 23:06:39 -0800 (PST) From: Tushar Behera To: linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com Cc: a.zummo@towertech.it, patches@linaro.org Subject: [PATCH 1/2] drivers/rtc/rtc-s3c.c: Remove unnecessary err_nores label Date: Fri, 23 Nov 2012 12:30:18 +0530 Message-Id: <1353654019-1099-2-git-send-email-tushar.behera@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1353654019-1099-1-git-send-email-tushar.behera@linaro.org> References: <1353654019-1099-1-git-send-email-tushar.behera@linaro.org> X-Gm-Message-State: ALoCoQmL7oFA47twhMqF2JxMl/B1euNzoQS9zDqVl6MUD4mZEPMIDRZiDxxZiilMf/0dFN7olkxE err_nores label redirects to a simple return statement. Move the return statement to caller location and remove the label. Signed-off-by: Tushar Behera --- drivers/rtc/rtc-s3c.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c index 77823d2..df7b478 100644 --- a/drivers/rtc/rtc-s3c.c +++ b/drivers/rtc/rtc-s3c.c @@ -501,8 +501,7 @@ static int __devinit s3c_rtc_probe(struct platform_device *pdev) if (s3c_rtc_mem == NULL) { dev_err(&pdev->dev, "failed to reserve memory region\n"); - ret = -ENOENT; - goto err_nores; + return -ENOENT; } s3c_rtc_base = ioremap(res->start, resource_size(res)); @@ -612,8 +611,6 @@ static int __devinit s3c_rtc_probe(struct platform_device *pdev) err_nomap: release_resource(s3c_rtc_mem); - - err_nores: return ret; }