From patchwork Fri Nov 16 06:50:35 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tushar Behera X-Patchwork-Id: 12886 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id E215323E13 for ; Fri, 16 Nov 2012 06:57:08 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id 97A37A19389 for ; Fri, 16 Nov 2012 06:57:08 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id e10so3064408iej.11 for ; Thu, 15 Nov 2012 22:57:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=Oz/5ME2M1zZ8LS+0FzymWYxH8QCPVyjxctyq94IkSmM=; b=XkBKYedi5aQdpfrlZCtvPxixcxuhE/K2uhds0ydchpMr8g53taZaNZh3rxbb76Mwnm eWmDV/jG65fd/oIoG8Ewv3JJeEmPednRrsee+5uokesqYxeSU0z6DvLXku7bthHMRp7t XXYTNK5UBZcexgENLnUBoKk+rI9GlfBj82AD5lPlYleRQe1SMzXzxK7yl0zBsv0t4XFP m9hrYONWv6FPnsLvL6ACYSrJfll0Yb8r3OvpbxOuPvZ6nFakl5XUeL823/VDcZk7bQFy OI2yNybEH8hfb8WXF6PMDzHKWHRFqzMLxr9TzO/rsTKKEBBlJdS1ja6BWC/TWNOISAQd 1yjw== Received: by 10.50.186.199 with SMTP id fm7mr2081714igc.62.1353049028371; Thu, 15 Nov 2012 22:57:08 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.67.148 with SMTP id n20csp23330igt; Thu, 15 Nov 2012 22:57:08 -0800 (PST) Received: by 10.68.253.4 with SMTP id zw4mr6430375pbc.143.1353049027750; Thu, 15 Nov 2012 22:57:07 -0800 (PST) Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com [209.85.220.54]) by mx.google.com with ESMTPS id m5si1167202paw.78.2012.11.15.22.57.07 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 15 Nov 2012 22:57:07 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.54 is neither permitted nor denied by best guess record for domain of tushar.behera@linaro.org) client-ip=209.85.220.54; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.54 is neither permitted nor denied by best guess record for domain of tushar.behera@linaro.org) smtp.mail=tushar.behera@linaro.org Received: by mail-pa0-f54.google.com with SMTP id kp6so1778446pab.13 for ; Thu, 15 Nov 2012 22:57:07 -0800 (PST) Received: by 10.66.77.199 with SMTP id u7mr10383021paw.7.1353049027518; Thu, 15 Nov 2012 22:57:07 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id mz10sm753915pbc.37.2012.11.15.22.57.04 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 15 Nov 2012 22:57:06 -0800 (PST) From: Tushar Behera To: linux-kernel@vger.kernel.org Cc: patches@linaro.org, Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: [PATCH 03/14] [media] saa7134: Remove redundant check on unsigned variable Date: Fri, 16 Nov 2012 12:20:35 +0530 Message-Id: <1353048646-10935-4-git-send-email-tushar.behera@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1353048646-10935-1-git-send-email-tushar.behera@linaro.org> References: <1353048646-10935-1-git-send-email-tushar.behera@linaro.org> X-Gm-Message-State: ALoCoQkwXiTfEsGioUHGeemWU3QZ+z1Vd14QmWXzyuyZ0ChfwJwKwMgakefylPnpDlduuloVaCmN No need to check whether the unsigned variable is less than 0. CC: Mauro Carvalho Chehab CC: linux-media@vger.kernel.org Signed-off-by: Tushar Behera --- drivers/media/pci/saa7134/saa7134-video.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/pci/saa7134/saa7134-video.c b/drivers/media/pci/saa7134/saa7134-video.c index 4a77124..3abf527 100644 --- a/drivers/media/pci/saa7134/saa7134-video.c +++ b/drivers/media/pci/saa7134/saa7134-video.c @@ -2511,7 +2511,7 @@ int saa7134_video_init1(struct saa7134_dev *dev) /* sanitycheck insmod options */ if (gbuffers < 2 || gbuffers > VIDEO_MAX_FRAME) gbuffers = 2; - if (gbufsize < 0 || gbufsize > gbufsize_max) + if (gbufsize > gbufsize_max) gbufsize = gbufsize_max; gbufsize = (gbufsize + PAGE_SIZE - 1) & PAGE_MASK;