From patchwork Thu Sep 20 18:48:03 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Paul E. McKenney" X-Patchwork-Id: 11595 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 3594C23E54 for ; Thu, 20 Sep 2012 18:48:56 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id DE4AAA1823C for ; Thu, 20 Sep 2012 18:48:55 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id e10so3419662iej.11 for ; Thu, 20 Sep 2012 11:48:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-content-scanned:x-cbid:x-gm-message-state; bh=/7KrgRfOdmPFxJuxH7/0bk4P8DvQf+rV+bBL+coiW6c=; b=mNBMhYfbZS+5PMIN50XkX/pamSPlwalHmyjuAMYaQjLnPKoWkXOaHuGs1CTw3KeMqg GasF/AIVAn2oHN/RwxdYS3pKpYRz+Anx9CLymalf7tefuZYJFr6yqUMQ55Rn5bAqpyal XmtgCVuyZ+S1YC21KO+betGUj1pXj2L7wNZssm2I6ex+3/Nnik4YiHOuycq4o1x6tetL WE/Q4jffYJNfmhbpuV6jPnFUfeO/28Kzyn1wDpcWKFsumu4AZ4Avuzn47PDR/H2b/GXs DsIMVt3d8AygJ03mO/ZAgpqbzru+j+OERcjpcT7iZu5XxhoeRAgGu0nIMoglYSxI7Qvb EwlA== Received: by 10.50.242.3 with SMTP id wm3mr3406237igc.0.1348166935697; Thu, 20 Sep 2012 11:48:55 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.232 with SMTP id ex8csp92217igc; Thu, 20 Sep 2012 11:48:55 -0700 (PDT) Received: by 10.50.197.231 with SMTP id ix7mr2577323igc.54.1348166935159; Thu, 20 Sep 2012 11:48:55 -0700 (PDT) Received: from e35.co.us.ibm.com (e35.co.us.ibm.com. [32.97.110.153]) by mx.google.com with ESMTPS id 13si9803426igm.24.2012.09.20.11.48.54 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 20 Sep 2012 11:48:55 -0700 (PDT) Received-SPF: pass (google.com: domain of paulmck@linux.vnet.ibm.com designates 32.97.110.153 as permitted sender) client-ip=32.97.110.153; Authentication-Results: mx.google.com; spf=pass (google.com: domain of paulmck@linux.vnet.ibm.com designates 32.97.110.153 as permitted sender) smtp.mail=paulmck@linux.vnet.ibm.com Received: from /spool/local by e35.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 20 Sep 2012 12:48:52 -0600 Received: from d03dlp03.boulder.ibm.com (9.17.202.179) by e35.co.us.ibm.com (192.168.1.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 20 Sep 2012 12:48:44 -0600 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id AC53619D8070; Thu, 20 Sep 2012 12:48:41 -0600 (MDT) Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q8KIma6R245614; Thu, 20 Sep 2012 12:48:37 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q8KImPlc021003; Thu, 20 Sep 2012 12:48:36 -0600 Received: from paulmck-ThinkPad-W500 ([9.47.24.72]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q8KImNcP020787; Thu, 20 Sep 2012 12:48:24 -0600 Received: by paulmck-ThinkPad-W500 (Postfix, from userid 1000) id ECA41EC523; Thu, 20 Sep 2012 11:48:21 -0700 (PDT) From: "Paul E. McKenney" To: linux-kernel@vger.kernel.org Cc: mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca, josh@joshtriplett.org, niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, Valdis.Kletnieks@vt.edu, dhowells@redhat.com, eric.dumazet@gmail.com, darren@dvhart.com, fweisbec@gmail.com, sbw@mit.edu, patches@linaro.org, "Paul E. McKenney" , "Paul E. McKenney" Subject: [PATCH tip/core/rcu 07/23] rcu: Prevent offline CPUs from executing RCU core code Date: Thu, 20 Sep 2012 11:48:03 -0700 Message-Id: <1348166900-18716-7-git-send-email-paulmck@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.8 In-Reply-To: <1348166900-18716-1-git-send-email-paulmck@linux.vnet.ibm.com> References: <20120920184751.GA18657@linux.vnet.ibm.com> <1348166900-18716-1-git-send-email-paulmck@linux.vnet.ibm.com> X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12092018-6148-0000-0000-000009DB2014 X-Gm-Message-State: ALoCoQnXAksYdY9cu6HrIx9S1iGiM/SiQHkZ5l92tMh3P2QF5GWuWZCZgeYZk0q8/dMFqqZ/hf20 From: "Paul E. McKenney" Earlier versions of RCU invoked the RCU core from the CPU_DYING notifier in order to note a quiescent state for the outgoing CPU. Because the CPU is marked "offline" during the execution of the CPU_DYING notifiers, the RCU core had to tolerate being invoked from an offline CPU. However, commit b1420f1c (Make rcu_barrier() less disruptive) left only tracing code in the CPU_DYING notifier, so the RCU core need no longer execute on offline CPUs. This commit therefore enforces this restriction. Signed-off-by: Paul E. McKenney Signed-off-by: Paul E. McKenney Reviewed-by: Josh Triplett --- kernel/rcutree.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/kernel/rcutree.c b/kernel/rcutree.c index f061740..c5938e8 100644 --- a/kernel/rcutree.c +++ b/kernel/rcutree.c @@ -1890,6 +1890,8 @@ static void rcu_process_callbacks(struct softirq_action *unused) { struct rcu_state *rsp; + if (cpu_is_offline(smp_processor_id())) + return; trace_rcu_utilization("Start RCU core"); for_each_rcu_flavor(rsp) __rcu_process_callbacks(rsp);