From patchwork Thu Aug 30 21:05:40 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Paul E. McKenney" X-Patchwork-Id: 11082 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 40DC223E52 for ; Thu, 30 Aug 2012 21:14:17 +0000 (UTC) Received: from mail-iy0-f180.google.com (mail-iy0-f180.google.com [209.85.210.180]) by fiordland.canonical.com (Postfix) with ESMTP id 8D6C4A181FC for ; Thu, 30 Aug 2012 21:13:40 +0000 (UTC) Received: by iafj25 with SMTP id j25so3686184iaf.11 for ; Thu, 30 Aug 2012 14:14:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-content-scanned:x-cbid:x-gm-message-state; bh=ZbUppCimbSTOQeWKG+OduahY7Bsd3OSt54VeUD2mLFk=; b=i6j35IEdUCD3OjU1X6SEOEMZlCQhOAFhQhadSK+OG6uulap+cLcVTWbyh907howG7d vf0KRbqC6W0ju0KZ9VT51joPJ9iCuVDO0PedFsexXEG2J8n8h9KfN1X4UQEpWM3nokNb gniYEteBHOFxjq8TFg90fNeKXqdEzCEsf7jcWc9OP4+StARZHUwt/lYBcGTyjUviNsuz PxsXgzImnyiqERgnNQk04e+LRSnYG4VtIaE5VM5VXgnxxQyYWta02ICArRigV5/o3HAi gTF9auFIvzkAWTgbYlGNO5YoZHzksRfXqexZFHvtP7nwxUZg3oQybc8cSTuULTpor9D3 IJjw== Received: by 10.50.217.227 with SMTP id pb3mr2455327igc.28.1346361256234; Thu, 30 Aug 2012 14:14:16 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.232 with SMTP id ex8csp31645igc; Thu, 30 Aug 2012 14:14:15 -0700 (PDT) Received: by 10.182.174.68 with SMTP id bq4mr6052004obc.53.1346361255469; Thu, 30 Aug 2012 14:14:15 -0700 (PDT) Received: from e37.co.us.ibm.com (e37.co.us.ibm.com. [32.97.110.158]) by mx.google.com with ESMTPS id im8si3516340obb.22.2012.08.30.14.14.15 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 30 Aug 2012 14:14:15 -0700 (PDT) Received-SPF: pass (google.com: domain of paulmck@linux.vnet.ibm.com designates 32.97.110.158 as permitted sender) client-ip=32.97.110.158; Authentication-Results: mx.google.com; spf=pass (google.com: domain of paulmck@linux.vnet.ibm.com designates 32.97.110.158 as permitted sender) smtp.mail=paulmck@linux.vnet.ibm.com Received: from /spool/local by e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 30 Aug 2012 15:14:14 -0600 Received: from d03dlp01.boulder.ibm.com (9.17.202.177) by e37.co.us.ibm.com (192.168.1.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 30 Aug 2012 15:13:49 -0600 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id C25421FF0043 for ; Thu, 30 Aug 2012 15:13:47 -0600 (MDT) Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q7ULDlbJ127922 for ; Thu, 30 Aug 2012 15:13:47 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q7ULDXQT009139 for ; Thu, 30 Aug 2012 15:13:38 -0600 Received: from paulmck-ThinkPad-W500 (sig-9-65-153-225.mts.ibm.com [9.65.153.225]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q7ULDWJT009014; Thu, 30 Aug 2012 15:13:33 -0600 Received: by paulmck-ThinkPad-W500 (Postfix, from userid 1000) id 8ABC4EA850; Thu, 30 Aug 2012 14:05:47 -0700 (PDT) From: "Paul E. McKenney" To: linux-kernel@vger.kernel.org Cc: mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca, josh@joshtriplett.org, niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, Valdis.Kletnieks@vt.edu, dhowells@redhat.com, eric.dumazet@gmail.com, darren@dvhart.com, fweisbec@gmail.com, sbw@mit.edu, patches@linaro.org, "James E.J. Bottomley" , Helge Deller , Parisc , "3.2.x.." , "Paul E. McKenney" Subject: [PATCH tip/core/rcu 23/26] parisc: Add missing RCU idle APIs on idle loop Date: Thu, 30 Aug 2012 14:05:40 -0700 Message-Id: <1346360743-3628-23-git-send-email-paulmck@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.8 In-Reply-To: <1346360743-3628-1-git-send-email-paulmck@linux.vnet.ibm.com> References: <20120830210520.GA2824@linux.vnet.ibm.com> <1346360743-3628-1-git-send-email-paulmck@linux.vnet.ibm.com> X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12083021-7408-0000-0000-0000080B5677 X-Gm-Message-State: ALoCoQkziHjPTVaQyvgCRQ0zMZAhscVIz1yzpTZ8zzC+9Jar7KI/w7nxrORZrWRWKSaGhSo8ZGnX From: Frederic Weisbecker In the old times, the whole idle task was considered as an RCU quiescent state. But as RCU became more and more successful overtime, some RCU read side critical section have been added even in the code of some architectures idle tasks, for tracing for example. So nowadays, rcu_idle_enter() and rcu_idle_exit() must be called by the architecture to tell RCU about the part in the idle loop that doesn't make use of rcu read side critical sections, typically the part that puts the CPU in low power mode. This is necessary for RCU to find the quiescent states in idle in order to complete grace periods. Add this missing pair of calls in the parisc's idle loop. Reported-by: Paul E. McKenney Signed-off-by: Frederic Weisbecker Cc: James E.J. Bottomley Cc: Helge Deller Cc: Parisc Cc: 3.2.x.. Cc: Paul E. McKenney Reviewed-by: Josh Triplett --- arch/parisc/kernel/process.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch/parisc/kernel/process.c b/arch/parisc/kernel/process.c index d4b94b3..c54a4db 100644 --- a/arch/parisc/kernel/process.c +++ b/arch/parisc/kernel/process.c @@ -48,6 +48,7 @@ #include #include #include +#include #include #include @@ -69,8 +70,10 @@ void cpu_idle(void) /* endless idle loop with no priority at all */ while (1) { + rcu_idle_enter(); while (!need_resched()) barrier(); + rcu_idle_exit(); schedule_preempt_disabled(); check_pgt_cache(); }