From patchwork Thu Aug 30 21:05:39 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Paul E. McKenney" X-Patchwork-Id: 11097 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 17FED23E52 for ; Thu, 30 Aug 2012 21:14:32 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id 7B65AA181FC for ; Thu, 30 Aug 2012 21:13:55 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id k11so1133617iea.11 for ; Thu, 30 Aug 2012 14:14:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-content-scanned:x-cbid:x-gm-message-state; bh=4Zi/j+h6lFzLFWxQJ8ZndswDFd9wMKkMPsPS15bcYco=; b=PWIq6xm3MxTuWqYr19/Gl4WwfdA68LyvGieTHu+9jMewUxXlcOU/PTIG6ucSlmaKt8 RRd67CA0GB0I4UzWAyml5J3ix4yVvtbDrLf8VARr1ox3ifPLaxsEQTE/wB61pFQATjY1 HPZ0Q/3HRUcU5ZnWl77TkOzukxpeC0UhY2ZvBW4Mu3n3xliaxjqAyNZd+xWLeCaEW0y4 jroEa/hrnjf3O4uKaBYfLdvYYY+ZSXuTkxSlhQfQ7tdg7Tz5QEU57HdQ5hxTSFRrK1hM iSCzI3mhgxGn/eLINJA2ClR2Qd/fU6Q+9lnCqE3/7tc2JXlHIeL8jrt2TOcN98TJz1/2 SvUw== Received: by 10.42.60.139 with SMTP id q11mr6294258ich.53.1346361271519; Thu, 30 Aug 2012 14:14:31 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.232 with SMTP id ex8csp31687igc; Thu, 30 Aug 2012 14:14:31 -0700 (PDT) Received: by 10.50.88.195 with SMTP id bi3mr2370637igb.50.1346361271213; Thu, 30 Aug 2012 14:14:31 -0700 (PDT) Received: from e31.co.us.ibm.com (e31.co.us.ibm.com. [32.97.110.149]) by mx.google.com with ESMTPS id zz5si4609587icb.20.2012.08.30.14.14.31 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 30 Aug 2012 14:14:31 -0700 (PDT) Received-SPF: pass (google.com: domain of paulmck@linux.vnet.ibm.com designates 32.97.110.149 as permitted sender) client-ip=32.97.110.149; Authentication-Results: mx.google.com; spf=pass (google.com: domain of paulmck@linux.vnet.ibm.com designates 32.97.110.149 as permitted sender) smtp.mail=paulmck@linux.vnet.ibm.com Received: from /spool/local by e31.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 30 Aug 2012 15:14:30 -0600 Received: from d03dlp03.boulder.ibm.com (9.17.202.179) by e31.co.us.ibm.com (192.168.1.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 30 Aug 2012 15:14:28 -0600 Received: from d03relay05.boulder.ibm.com (d03relay05.boulder.ibm.com [9.17.195.107]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id 38EEB19D8042 for ; Thu, 30 Aug 2012 15:13:57 -0600 (MDT) Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay05.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q7ULDqVl110672 for ; Thu, 30 Aug 2012 15:13:52 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q7ULDbGq009515 for ; Thu, 30 Aug 2012 15:13:50 -0600 Received: from paulmck-ThinkPad-W500 (sig-9-65-153-225.mts.ibm.com [9.65.153.225]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q7ULDZgn009395; Thu, 30 Aug 2012 15:13:36 -0600 Received: by paulmck-ThinkPad-W500 (Postfix, from userid 1000) id 766B8EA84F; Thu, 30 Aug 2012 14:05:47 -0700 (PDT) From: "Paul E. McKenney" To: linux-kernel@vger.kernel.org Cc: mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca, josh@joshtriplett.org, niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, Valdis.Kletnieks@vt.edu, dhowells@redhat.com, eric.dumazet@gmail.com, darren@dvhart.com, fweisbec@gmail.com, sbw@mit.edu, patches@linaro.org, Koichi Yasutake , "3.2.x.." , "Paul E. McKenney" Subject: [PATCH tip/core/rcu 22/26] mn10300: Add missing RCU idle APIs on idle loop Date: Thu, 30 Aug 2012 14:05:39 -0700 Message-Id: <1346360743-3628-22-git-send-email-paulmck@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.8 In-Reply-To: <1346360743-3628-1-git-send-email-paulmck@linux.vnet.ibm.com> References: <20120830210520.GA2824@linux.vnet.ibm.com> <1346360743-3628-1-git-send-email-paulmck@linux.vnet.ibm.com> X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12083021-7282-0000-0000-00000C766236 X-Gm-Message-State: ALoCoQlrwh4llh1EsIiYBOoq+BauT4BCeTw5bCF2qeEGtWHAxgDNFnFh/Uct5b8Ig19ygF0nPokY From: Frederic Weisbecker In the old times, the whole idle task was considered as an RCU quiescent state. But as RCU became more and more successful overtime, some RCU read side critical section have been added even in the code of some architectures idle tasks, for tracing for example. So nowadays, rcu_idle_enter() and rcu_idle_exit() must be called by the architecture to tell RCU about the part in the idle loop that doesn't make use of rcu read side critical sections, typically the part that puts the CPU in low power mode. This is necessary for RCU to find the quiescent states in idle in order to complete grace periods. Add this missing pair of calls in the mn10300's idle loop. Reported-by: Paul E. McKenney Signed-off-by: Frederic Weisbecker Cc: David Howells Cc: Koichi Yasutake Cc: 3.2.x.. Cc: Paul E. McKenney Reviewed-by: Josh Triplett --- arch/mn10300/kernel/process.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch/mn10300/kernel/process.c b/arch/mn10300/kernel/process.c index 7dab0cd..e9cceba 100644 --- a/arch/mn10300/kernel/process.c +++ b/arch/mn10300/kernel/process.c @@ -25,6 +25,7 @@ #include #include #include +#include #include #include #include @@ -107,6 +108,7 @@ void cpu_idle(void) { /* endless idle loop with no priority at all */ for (;;) { + rcu_idle_enter(); while (!need_resched()) { void (*idle)(void); @@ -121,6 +123,7 @@ void cpu_idle(void) } idle(); } + rcu_idle_exit(); schedule_preempt_disabled(); }