From patchwork Thu Aug 30 18:56:20 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Paul E. McKenney" X-Patchwork-Id: 11118 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id B518C23F27 for ; Thu, 30 Aug 2012 21:48:51 +0000 (UTC) Received: from mail-iy0-f180.google.com (mail-iy0-f180.google.com [209.85.210.180]) by fiordland.canonical.com (Postfix) with ESMTP id F18AEA192CE for ; Thu, 30 Aug 2012 21:48:14 +0000 (UTC) Received: by iafj25 with SMTP id j25so3733888iaf.11 for ; Thu, 30 Aug 2012 14:48:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-content-scanned:x-cbid:x-gm-message-state; bh=6uhQQ+e79PPVGXA4gw62lVBWPMTX+9KGwmA83u2X4Bs=; b=EMc+urHV2e7b9h3NTkxUpR/F0HNUXoTAeUxpn1RWR15SIMNrhy1xiJCOlZHJwsspNG g2Wg+feMz10/0lkJhUstjvwd9RVgAOy4tk0fzKXLlOVWfQETjvU6MGnBBYimijOAMkjo cKd5aehQfh9xdMpOZYqy0NC9MbBMYqVd7MDMiYSjYifmDabjp/u80FxLJQhRMOJBTPSf leXtxlupKdvyevpRxLNx9BXtLtNfQbTx+M5VBd9AwMM7oTKUFZCaB71HYfMNMZd1F2El ZCZao34vBhOD3rBmpa0WngiT9YkezXGj+EPsKfzQLBb5lGUnLCR5aOhgOZKfltf7nmyS h3Ow== Received: by 10.42.109.194 with SMTP id m2mr6331578icp.48.1346363330776; Thu, 30 Aug 2012 14:48:50 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.232 with SMTP id ex8csp33088igc; Thu, 30 Aug 2012 14:48:50 -0700 (PDT) Received: by 10.50.220.196 with SMTP id py4mr2033744igc.46.1346363021125; Thu, 30 Aug 2012 14:43:41 -0700 (PDT) Received: from e36.co.us.ibm.com (e36.co.us.ibm.com. [32.97.110.154]) by mx.google.com with ESMTPS id qa7si4678354icb.55.2012.08.30.14.43.40 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 30 Aug 2012 14:43:41 -0700 (PDT) Received-SPF: pass (google.com: domain of paulmck@linux.vnet.ibm.com designates 32.97.110.154 as permitted sender) client-ip=32.97.110.154; Authentication-Results: mx.google.com; spf=pass (google.com: domain of paulmck@linux.vnet.ibm.com designates 32.97.110.154 as permitted sender) smtp.mail=paulmck@linux.vnet.ibm.com Received: from /spool/local by e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 30 Aug 2012 15:43:40 -0600 Received: from d03dlp01.boulder.ibm.com (9.17.202.177) by e36.co.us.ibm.com (192.168.1.136) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 30 Aug 2012 15:43:38 -0600 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id 4666D1FF0040; Thu, 30 Aug 2012 15:43:37 -0600 (MDT) Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q7ULhZTZ156442; Thu, 30 Aug 2012 15:43:36 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q7ULhY4O026539; Thu, 30 Aug 2012 15:43:35 -0600 Received: from paulmck-ThinkPad-W500 (sig-9-65-153-225.mts.ibm.com [9.65.153.225]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q7ULhXVg026415; Thu, 30 Aug 2012 15:43:33 -0600 Received: by paulmck-ThinkPad-W500 (Postfix, from userid 1000) id 0DEDFEA82E; Thu, 30 Aug 2012 11:56:30 -0700 (PDT) From: "Paul E. McKenney" To: linux-kernel@vger.kernel.org Cc: mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca, josh@joshtriplett.org, niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, Valdis.Kletnieks@vt.edu, dhowells@redhat.com, eric.dumazet@gmail.com, darren@dvhart.com, fweisbec@gmail.com, sbw@mit.edu, patches@linaro.org, "Paul E. McKenney" , "Paul E. McKenney" Subject: [PATCH tip/core/rcu 07/15] rcu: Fix obsolete rcu_initiate_boost() header comment Date: Thu, 30 Aug 2012 11:56:20 -0700 Message-Id: <1346352988-32444-7-git-send-email-paulmck@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.8 In-Reply-To: <1346352988-32444-1-git-send-email-paulmck@linux.vnet.ibm.com> References: <20120830185607.GA32148@linux.vnet.ibm.com> <1346352988-32444-1-git-send-email-paulmck@linux.vnet.ibm.com> X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12083021-7606-0000-0000-00000334FF73 X-Gm-Message-State: ALoCoQlFkTlMNDmfQ4jWnYSvooELm6yhQtOKQgpP0+AO2rMjFOtcz2+HOSdEH0izD+q/S7UOB+uG From: "Paul E. McKenney" Commit 1217ed1b (rcu: permit rcu_read_unlock() to be called while holding runqueue locks) made rcu_initiate_boost() restore irq state when releasing the rcu_node structure's ->lock, but failed to update the header comment accordingly. This commit therefore brings the header comment up to date. Signed-off-by: Paul E. McKenney Signed-off-by: Paul E. McKenney Reviewed-by: Josh Triplett --- kernel/rcutree_plugin.h | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/rcutree_plugin.h b/kernel/rcutree_plugin.h index c930a47..3ea60c9 100644 --- a/kernel/rcutree_plugin.h +++ b/kernel/rcutree_plugin.h @@ -1193,9 +1193,9 @@ static int rcu_boost_kthread(void *arg) * kthread to start boosting them. If there is an expedited grace * period in progress, it is always time to boost. * - * The caller must hold rnp->lock, which this function releases, - * but irqs remain disabled. The ->boost_kthread_task is immortal, - * so we don't need to worry about it going away. + * The caller must hold rnp->lock, which this function releases. + * The ->boost_kthread_task is immortal, so we don't need to worry + * about it going away. */ static void rcu_initiate_boost(struct rcu_node *rnp, unsigned long flags) {