From patchwork Thu Aug 30 18:18:17 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Paul E. McKenney" X-Patchwork-Id: 11048 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 245B923EFE for ; Thu, 30 Aug 2012 18:19:42 +0000 (UTC) Received: from mail-iy0-f180.google.com (mail-iy0-f180.google.com [209.85.210.180]) by fiordland.canonical.com (Postfix) with ESMTP id DD341A180C3 for ; Thu, 30 Aug 2012 18:19:05 +0000 (UTC) Received: by mail-iy0-f180.google.com with SMTP id j25so3403526iaf.11 for ; Thu, 30 Aug 2012 11:19:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-content-scanned:x-cbid:x-gm-message-state; bh=V7awBbnkQeQMM3g2c0dtJBcAumV1bqsyarN1n79bBwY=; b=cIUwXlkYWaIo25AkIQ+Hz1A3CF+K8vo8/Mfhgb8Px5SzSbNkFubpjBHGLdtPCBjulI g3ujVDyuM3oEz8cta1Ic4fAVw6RSzaBET40GFT4ROL+C9xxXJLL5v6qtmUMNxyUEwvU5 M16ivUHL2tVhEgR+DyW8zgqVMTeuu4CqwqP38g1gEwdqhzs2QfCGZYpkKn0A2LX7rorj P7k6ysYjHTvsLQ6XqhRIiWS03G1UnxT92x/P4z/aCrzqhtvksRvRgKBIu52yLO2pVwbv zoVqF+LX7sHSqMHVGy3STNFK2f4OuE5wUZzK09tXp8i/L3TrGacZ1kCodtfWEs28Y18y z2YQ== Received: by 10.50.45.162 with SMTP id o2mr1910456igm.0.1346350781586; Thu, 30 Aug 2012 11:19:41 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.232 with SMTP id ex8csp24727igc; Thu, 30 Aug 2012 11:19:41 -0700 (PDT) Received: by 10.60.5.229 with SMTP id v5mr5538331oev.70.1346350780793; Thu, 30 Aug 2012 11:19:40 -0700 (PDT) Received: from e2.ny.us.ibm.com (e2.ny.us.ibm.com. [32.97.182.142]) by mx.google.com with ESMTPS id hm7si3079411obc.140.2012.08.30.11.19.40 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 30 Aug 2012 11:19:40 -0700 (PDT) Received-SPF: pass (google.com: domain of paulmck@linux.vnet.ibm.com designates 32.97.182.142 as permitted sender) client-ip=32.97.182.142; Authentication-Results: mx.google.com; spf=pass (google.com: domain of paulmck@linux.vnet.ibm.com designates 32.97.182.142 as permitted sender) smtp.mail=paulmck@linux.vnet.ibm.com Received: from /spool/local by e2.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 30 Aug 2012 14:19:38 -0400 Received: from d01dlp02.pok.ibm.com (9.56.250.167) by e2.ny.us.ibm.com (192.168.1.102) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 30 Aug 2012 14:19:23 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 3BD576E804F for ; Thu, 30 Aug 2012 14:19:10 -0400 (EDT) Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q7UIJ7cH159258 for ; Thu, 30 Aug 2012 14:19:08 -0400 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q7UIIfLB018667 for ; Thu, 30 Aug 2012 12:18:43 -0600 Received: from paulmck-ThinkPad-W500 (sig-9-77-132-62.mts.ibm.com [9.77.132.62]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q7UIIdp9018612; Thu, 30 Aug 2012 12:18:40 -0600 Received: by paulmck-ThinkPad-W500 (Postfix, from userid 1000) id AD0C8E4D88; Thu, 30 Aug 2012 11:18:39 -0700 (PDT) From: "Paul E. McKenney" To: linux-kernel@vger.kernel.org Cc: mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca, josh@joshtriplett.org, niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, Valdis.Kletnieks@vt.edu, dhowells@redhat.com, eric.dumazet@gmail.com, darren@dvhart.com, fweisbec@gmail.com, sbw@mit.edu, patches@linaro.org, "Paul E. McKenney" Subject: [PATCH tip/core/rcu 02/23] rcu: Allow RCU grace-period initialization to be preempted Date: Thu, 30 Aug 2012 11:18:17 -0700 Message-Id: <1346350718-30937-2-git-send-email-paulmck@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.8 In-Reply-To: <1346350718-30937-1-git-send-email-paulmck@linux.vnet.ibm.com> References: <20120830181811.GA29154@linux.vnet.ibm.com> <1346350718-30937-1-git-send-email-paulmck@linux.vnet.ibm.com> X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12083018-5112-0000-0000-00000BA6C49F X-Gm-Message-State: ALoCoQlnsmN1tzYHL2a8a09/CSevTlqaY3xmK6FE1KCSxa3a9x6Nb/YqEI+G1YCwlIl4T9bJ9CO7 From: "Paul E. McKenney" RCU grace-period initialization is currently carried out with interrupts disabled, which can result in 200-microsecond latency spikes on systems on which RCU has been configured for 4096 CPUs. This patch therefore makes the RCU grace-period initialization be preemptible, which should eliminate those latency spikes. Similar spikes from grace-period cleanup and the forcing of quiescent states will be dealt with similarly by later patches. Reported-by: Mike Galbraith Reported-by: Dimitri Sivanich Signed-off-by: Paul E. McKenney Reviewed-by: Josh Triplett --- kernel/rcutree.c | 17 ++++++++++------- 1 files changed, 10 insertions(+), 7 deletions(-) diff --git a/kernel/rcutree.c b/kernel/rcutree.c index e1c5868..ef56aa3 100644 --- a/kernel/rcutree.c +++ b/kernel/rcutree.c @@ -1069,6 +1069,7 @@ static int rcu_gp_kthread(void *arg) * don't start another one. */ raw_spin_unlock_irqrestore(&rnp->lock, flags); + cond_resched(); continue; } @@ -1079,6 +1080,7 @@ static int rcu_gp_kthread(void *arg) */ rsp->fqs_need_gp = 1; raw_spin_unlock_irqrestore(&rnp->lock, flags); + cond_resched(); continue; } @@ -1089,10 +1091,10 @@ static int rcu_gp_kthread(void *arg) rsp->fqs_state = RCU_GP_INIT; /* Stop force_quiescent_state. */ rsp->jiffies_force_qs = jiffies + RCU_JIFFIES_TILL_FORCE_QS; record_gp_stall_check_time(rsp); - raw_spin_unlock(&rnp->lock); /* leave irqs disabled. */ + raw_spin_unlock_irqrestore(&rnp->lock, flags); /* Exclude any concurrent CPU-hotplug operations. */ - raw_spin_lock(&rsp->onofflock); /* irqs already disabled. */ + get_online_cpus(); /* * Set the quiescent-state-needed bits in all the rcu_node @@ -1112,7 +1114,7 @@ static int rcu_gp_kthread(void *arg) * due to the fact that we have irqs disabled. */ rcu_for_each_node_breadth_first(rsp, rnp) { - raw_spin_lock(&rnp->lock); /* irqs already disabled. */ + raw_spin_lock_irqsave(&rnp->lock, flags); rcu_preempt_check_blocked_tasks(rnp); rnp->qsmask = rnp->qsmaskinit; rnp->gpnum = rsp->gpnum; @@ -1123,15 +1125,16 @@ static int rcu_gp_kthread(void *arg) trace_rcu_grace_period_init(rsp->name, rnp->gpnum, rnp->level, rnp->grplo, rnp->grphi, rnp->qsmask); - raw_spin_unlock(&rnp->lock); /* irqs remain disabled. */ + raw_spin_unlock_irqrestore(&rnp->lock, flags); + cond_resched(); } rnp = rcu_get_root(rsp); - raw_spin_lock(&rnp->lock); /* irqs already disabled. */ + raw_spin_lock_irqsave(&rnp->lock, flags); /* force_quiescent_state() now OK. */ rsp->fqs_state = RCU_SIGNAL_INIT; - raw_spin_unlock(&rnp->lock); /* irqs remain disabled. */ - raw_spin_unlock_irqrestore(&rsp->onofflock, flags); + raw_spin_unlock_irqrestore(&rnp->lock, flags); + put_online_cpus(); } return 0; }