From patchwork Mon Aug 20 14:47:21 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Vorontsov X-Patchwork-Id: 10806 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id A486E23E56 for ; Mon, 20 Aug 2012 14:50:07 +0000 (UTC) Received: from mail-gg0-f180.google.com (mail-gg0-f180.google.com [209.85.161.180]) by fiordland.canonical.com (Postfix) with ESMTP id 82287A18B68 for ; Mon, 20 Aug 2012 14:50:01 +0000 (UTC) Received: by mail-gg0-f180.google.com with SMTP id i2so5358432ggm.11 for ; Mon, 20 Aug 2012 07:50:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=p/kWpoIxbmOilCPgdtlfnLwScRjWGa1PsfxvN1ORpo0=; b=HLxhCsBGx2sFMPS+jA17xEmLDoF42Q9ZNEoyXGtXO1BDgJUZhFXHq5jn3n9oo1Aumj +yDTXz/uWCub+4Gzcm0wQoSwaNRMp2QNjjf70/SKnVgk40OKOT9gXWk39snKX7g6Q5kT jKxWll7TnzXQD3A0XpeI0Xe3C/1Gm41PffDn+TsR+SUt58ktYfRaMUH2stcxASIrd57F H8RE5O5iGdw1SaUbIQUR0BoOAO2yWP2Jsugr7Uwixy66v6k9S5qwN2+jtTf+cDHl7Lm3 r0vBio6pqAUr2w1Cf75kK2T9mSfdlwuDG3JqPFTPqFsJaV5fbpqJK87hgfGOOzeg/xoK KH8g== Received: by 10.50.182.162 with SMTP id ef2mr9964343igc.43.1345474206566; Mon, 20 Aug 2012 07:50:06 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.232 with SMTP id ex8csp87696igc; Mon, 20 Aug 2012 07:50:06 -0700 (PDT) Received: by 10.66.87.132 with SMTP id ay4mr30032743pab.82.1345474206105; Mon, 20 Aug 2012 07:50:06 -0700 (PDT) Received: from mail-pb0-f50.google.com (mail-pb0-f50.google.com [209.85.160.50]) by mx.google.com with ESMTPS id ip5si26175824pbc.348.2012.08.20.07.50.05 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 20 Aug 2012 07:50:06 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.160.50 is neither permitted nor denied by best guess record for domain of anton.vorontsov@linaro.org) client-ip=209.85.160.50; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.160.50 is neither permitted nor denied by best guess record for domain of anton.vorontsov@linaro.org) smtp.mail=anton.vorontsov@linaro.org Received: by mail-pb0-f50.google.com with SMTP id md12so7851964pbc.37 for ; Mon, 20 Aug 2012 07:50:05 -0700 (PDT) Received: by 10.66.87.138 with SMTP id ay10mr30120810pab.38.1345474205789; Mon, 20 Aug 2012 07:50:05 -0700 (PDT) Received: from localhost (c-71-204-165-222.hsd1.ca.comcast.net. [71.204.165.222]) by mx.google.com with ESMTPS id pj3sm11229138pbc.53.2012.08.20.07.50.04 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 20 Aug 2012 07:50:05 -0700 (PDT) From: Anton Vorontsov To: Russell King , Jason Wessel , Greg Kroah-Hartman , Alan Cox Cc: =?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?= , Colin Cross , John Stultz , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linaro-kernel@lists.linaro.org, patches@linaro.org, kernel-team@android.com, kgdb-bugreport@lists.sourceforge.net Subject: [PATCH 03/12] kdb: Turn KGDB_KDB=n stubs into static inlines Date: Mon, 20 Aug 2012 07:47:21 -0700 Message-Id: <1345474050-8339-3-git-send-email-anton.vorontsov@linaro.org> X-Mailer: git-send-email 1.7.11.5 In-Reply-To: <20120820144449.GA32560@lizard> References: <20120820144449.GA32560@lizard> X-Gm-Message-State: ALoCoQlhwiitIjLGyfwPwgcOg0p3MrJTeLtr3qN2RdJQ5V8zBfdFg5JCP7HhHJyiojQZGBeVktl0 This makes the stubs actually usable, since e.g. 'foo = kdb_register();' leads to build errors in !KGDB_KDB case. Plus, with static inlines we do type checking. Signed-off-by: Anton Vorontsov --- include/linux/kdb.h | 29 ++++++++++++++++------------- 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/include/linux/kdb.h b/include/linux/kdb.h index 42d9e86..7f6fe6e 100644 --- a/include/linux/kdb.h +++ b/include/linux/kdb.h @@ -13,6 +13,14 @@ * Copyright (C) 2009 Jason Wessel */ +typedef enum { + KDB_REPEAT_NONE = 0, /* Do not repeat this command */ + KDB_REPEAT_NO_ARGS, /* Repeat the command without arguments */ + KDB_REPEAT_WITH_ARGS, /* Repeat the command including its arguments */ +} kdb_repeat_t; + +typedef int (*kdb_func_t)(int, const char **); + #ifdef CONFIG_KGDB_KDB #include #include @@ -32,14 +40,6 @@ extern atomic_t kdb_event; #define KDB_MAXARGS 16 /* Maximum number of arguments to a function */ -typedef enum { - KDB_REPEAT_NONE = 0, /* Do not repeat this command */ - KDB_REPEAT_NO_ARGS, /* Repeat the command without arguments */ - KDB_REPEAT_WITH_ARGS, /* Repeat the command including its arguments */ -} kdb_repeat_t; - -typedef int (*kdb_func_t)(int, const char **); - /* KDB return codes from a command or internal kdb function */ #define KDB_NOTFOUND (-1) #define KDB_ARGCOUNT (-2) @@ -149,11 +149,14 @@ extern int kdb_register_repeat(char *, kdb_func_t, char *, char *, short, kdb_repeat_t); extern int kdb_unregister(char *); #else /* ! CONFIG_KGDB_KDB */ -#define kdb_printf(...) -#define kdb_init(x) -#define kdb_register(...) -#define kdb_register_repeat(...) -#define kdb_uregister(x) +static inline __printf(1, 2) int kdb_printf(const char *fmt, ...) { return 0; } +static inline void kdb_init(int level) {} +static inline int kdb_register(char *cmd, kdb_func_t func, char *usage, + char *help, short minlen) { return 0; } +static inline int kdb_register_repeat(char *cmd, kdb_func_t func, char *usage, + char *help, short minlen, + kdb_repeat_t repeat) { return 0; } +static inline int kdb_unregister(char *cmd) { return 0; } #endif /* CONFIG_KGDB_KDB */ enum { KDB_NOT_INITIALIZED,