From patchwork Sat May 26 13:07:53 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Vorontsov X-Patchwork-Id: 8990 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 4370123E37 for ; Sat, 26 May 2012 13:10:38 +0000 (UTC) Received: from mail-yx0-f180.google.com (mail-yx0-f180.google.com [209.85.213.180]) by fiordland.canonical.com (Postfix) with ESMTP id 14666A18927 for ; Sat, 26 May 2012 13:10:37 +0000 (UTC) Received: by yenq6 with SMTP id q6so1072029yen.11 for ; Sat, 26 May 2012 06:10:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=1snQQfRt3XT+WOBj7BpMmbeMa+gZqFPfNaE1fWvcLck=; b=GHzjDaDI63rBuE8H8/hqRrStiBLI4soJesdNCq/vEoD4vW/kbmxOfPbjtsQlCQRveZ yE/GABe7waNenSqZOemQpzTKF7bL6H7smuD3iBSz81KH5GOjpCot5t1BoVu8+97pfIbN QcOECL598ysjVzch3EL4qtBU5/dOAHLD8cMG/9Pi8ioZxxhtkltqVCIPzAns4IsRnzqr mtwV3AGv6cHtEjP23YbkZCwyG4bk7tlgG1ROaZ4ztcVUCpyPNj1sU4hxsIat4tXHaQRU 4MM2hAETbafaj2JQXSoEW7++b3qaR0hmjXeRsFcWIxM0LkxqyhMzA8X02Du7z6TdpU0X eDeA== Received: by 10.50.46.232 with SMTP id y8mr923988igm.57.1338037837412; Sat, 26 May 2012 06:10:37 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.231.24.148 with SMTP id v20csp85873ibb; Sat, 26 May 2012 06:10:35 -0700 (PDT) Received: by 10.68.135.229 with SMTP id pv5mr7697521pbb.70.1338037835495; Sat, 26 May 2012 06:10:35 -0700 (PDT) Received: from mail-pb0-f50.google.com (mail-pb0-f50.google.com [209.85.160.50]) by mx.google.com with ESMTPS id hs4si9890161pbc.266.2012.05.26.06.10.35 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 26 May 2012 06:10:35 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.160.50 is neither permitted nor denied by best guess record for domain of anton.vorontsov@linaro.org) client-ip=209.85.160.50; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.160.50 is neither permitted nor denied by best guess record for domain of anton.vorontsov@linaro.org) smtp.mail=anton.vorontsov@linaro.org Received: by mail-pb0-f50.google.com with SMTP id rr4so3284264pbb.37 for ; Sat, 26 May 2012 06:10:35 -0700 (PDT) Received: by 10.68.132.195 with SMTP id ow3mr7699699pbb.78.1338037833882; Sat, 26 May 2012 06:10:33 -0700 (PDT) Received: from localhost (c-71-204-165-222.hsd1.ca.comcast.net. [71.204.165.222]) by mx.google.com with ESMTPS id z2sm12508592pbv.34.2012.05.26.06.10.31 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 26 May 2012 06:10:33 -0700 (PDT) From: Anton Vorontsov To: Greg Kroah-Hartman , Kees Cook , Colin Cross , Tony Luck Cc: Arnd Bergmann , John Stultz , Shuah Khan , arve@android.com, Rebecca Schultz Zavin , Jesper Juhl , Randy Dunlap , Stephen Boyd , Thomas Meyer , Andrew Morton , Marco Stornelli , WANG Cong , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, linaro-kernel@lists.linaro.org, patches@linaro.org, kernel-team@android.com Subject: [PATCH 5/5] pstore/inode: Make pstore_fill_super() static Date: Sat, 26 May 2012 06:07:53 -0700 Message-Id: <1338037673-19909-5-git-send-email-anton.vorontsov@linaro.org> X-Mailer: git-send-email 1.7.9.2 In-Reply-To: <20120526130650.GA6242@lizard> References: <20120526130650.GA6242@lizard> X-Gm-Message-State: ALoCoQlngVvUf8Yz0LBvtZ2vs5L+xLtz0OL+PTdQhGb1N6x4oNkFLD+1b0pNjDdGvn3oH5Rqe59m There's no reason to extern it. The patch fixes the annoying sparse warning: CHECK fs/pstore/inode.c fs/pstore/inode.c:264:5: warning: symbol 'pstore_fill_super' was not declared. Should it be static? Signed-off-by: Anton Vorontsov Acked-by: Kees Cook --- fs/pstore/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/pstore/inode.c b/fs/pstore/inode.c index 1950788..49b40ea 100644 --- a/fs/pstore/inode.c +++ b/fs/pstore/inode.c @@ -258,7 +258,7 @@ fail: return rc; } -int pstore_fill_super(struct super_block *sb, void *data, int silent) +static int pstore_fill_super(struct super_block *sb, void *data, int silent) { struct inode *inode;